[Trigger] help with a spell

[wolfman]

I am working on a spell similar to black arrow (skeleton spawns when you kill a unit) but i want to make it so when you kill a unit with the spell, that unit that you just killed respawns but for you. The base spell was black arrow. If there seems to be no way to fix this i was thinking of a passive ability where there is a percent chance that the unit will spawn, but i dont know how to do this.

This is the trigger i made but it doesnt really work all the time, sometimes more than one unit spawns and idk how to fix this:

• Possessive Arrow
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set Possessive_Owner[(Player number of (Owner of (Attacking unit)))] = (Owner of (Attacking unit))
    • Set Possessive_Target[(Player number of (Owner of (Attacked unit)))] = (Attacked unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Possessive_Target[(Player number of (Owner of (Attacked unit)))] has buff Possessive Arrow ) Equal to True
      • Then - Actions
        • Wait until ((Possessive_Target[(Player number of (Owner of (Attacked unit)))] is dead) Equal to True), checking every 0.10 seconds
        • Unit - Create 1 (Unit-type of Possessive_Target[(Player number of (Owner of (Attacked unit)))]) for Possessive_Owner[(Player number of (Owner of (Attacking unit)))] at (Position of Possessive_Target[(Player number of (Owner of (Attacked unit)))]) facing Default building facing degrees
      • Else - Actions
        • Do nothing

 

[Day-Elven]

Because you use (Player number of (Owner of (Attacking unit))) and (Player number of (Owner of (Attacked unit))). Just use local variables without arrays instead of global arrays and it will work.

 

[TheBlooddancer]

And remove the 'Do nothing' action.

Nothing is the same as Do nothing, and gives one less line for your script.

 

[Kwah]

And is hence more efficient, just in case you didn't understand that.

 

[Dr Super Good]

Leaks execution threads and has problems with not firing when the target gets hit.

Recomend an attack hit detection system (jass) with a better way of checking when the unit dies than an infinate timer.

 

[Kwah]

Yes, that too.

Search around, and you'll find a few nice systems that are quite easy to use.

I would recommend this, but be sure to give credit.

 

[wolfman]

you said not to use arrays, but what if 2 players have that hero and use the ability at the same time on 2 different units, then wouldnt that mess it up?

 

[Day-Elven]

It won't if you'll use local variables. Only globals can mess up in that way. Just add custom scripts.

 

[wolfman]

idk how to use custom scripts >.<
is there a tutorial you can lead me to?

 

[Dr Super Good]

Any JASS tutorial will help you to do so. It is pretty easy to learn if you already know a few programming languages.