Kill X units quest...

[NightSong]

Can someone help me optimize this?

• Killing Spiders
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Spider
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Owner of (Killing unit)) controller) Equal to User
        • SpidersKilled[(Player number of (Owner of (Killing unit)))] Less than (SpidersRequirement[(Player number of (Owner of (Killing unit)))] - 1)
        • QuestSpider[(Player number of (Owner of (Killing unit)))] Equal to started
      • Then - Actions
        • Set SpidersKilled[(Player number of (Owner of (Killing unit)))] = (SpidersKilled[(Player number of (Owner of (Killing unit)))] + 1)
        • Game - Display to (Player group((Owner of (Killing unit)))) the text: ((Spiders killed: + (String(SpidersKilled[(Player number of (Owner of (Killing unit)))]))) + (/ + (String(SpidersRequirement[(Player number of (Owner of (Killing unit)))]))))
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • QuestSpider[(Player number of (Owner of (Killing unit)))] Equal to started
          • Then - Actions
            • Set SpidersKilled[(Player number of (Owner of (Killing unit)))] = SpidersRequirement[(Player number of (Owner of (Killing unit)))]
            • Game - Display to (Player group((Owner of (Killing unit)))) the text: ((Spiders killed: + (String(SpidersKilled[(Player number of (Owner of (Killing unit)))]))) + (/ + (String(SpidersRequirement[(Player number of (Owner of (Killing unit)))]))))
            • Game - Display to (Player group((Owner of (Killing unit)))) the text: Quest Complete!
            • Set QuestSpider[(Player number of (Owner of (Killing unit)))] = requirementcomplete
          • Else - Actions
            • Do nothing

I don't know if this is leakless or not, but if someone could help me clean it up and whatnot, that'd be great!
Thanks!

 

[ap0calypse]

I think this leaks:

• Game - Display to (Player group((Owner of (Killing unit)))) the text: ((Spiders killed: + (String(SpidersKilled[(Player number of (Owner of (Killing unit)))]))) + (/ + (String(SpidersRequirement[(Player number of (Owner of (Killing unit)))]))))

Since it is a Player Group.

You can fix it with:

Fixed Example

• Set TempForce is (Player group((Owner of (Killing unit))))
• Game - Display to TempForce the text: ((Spiders killed: + (String(SpidersKilled[(Player number of (Owner of (Killing unit)))]))) + (/ + (String(SpidersRequirement[(Player number of (Owner of (Killing unit)))]))))
• call DestroyForce(udg_TempForce)

 

[NightSong]

Alright cool..
Also, could I convert this to custom text and turn all the globals into locals or would that cause the entire thing to stop working? I guess I'll go try that now!

 

[Teelo]

Thats what you're supposed to do.


Also, get rid of this:

• Else - Actions
• Do nothing