Help me! JAWS are eating me.

[chobibo]

Oh man, you get less sleep than I do, you must be popular with the girls, I need to sleep less often! Darn! Darn! Aaaaaaaah! *takes chill pill* Oh. Pardon me.

 

[Malhorne]

No I sleep around 6-7h atm by night.

 

[Vinz]

8hrs every day doesn't matter if it is Saturday/Sunday.
Oh look another offtopic!

Wait. WHAT?

 

[Malhorne]

Yes we should stop off-topic now

 

[Paliouras]

What's wrong with my post Wrathion?

 

[chobibo]

Paliouras has a pretty girl beside him right now

 

[Paliouras]

Hey stop stalking!

 

[chobibo]

Oh damn, what are you guys doing... I guess it's okay, nobody else is home...

 

[Vinz]

Dudes and dudessess, please, what is a 'constant'?
If I remove that word from a function will everything remain normal?

 

[Vinz]

Oh also I would like to ask how do I simulate back-to-guardpos situations? Where the creep goes to its camp and highly regenerates HP.

 

[Malhorne]

Constant variables -> Mean you can't change them
Constant functions -> They are inline by JASSHelper so you can abuse them.

 

[Vinz]

Okay, so I learned JASS about 3 months ago, and I never delved deeper than basics and tricks. So what is inline(weird I got to vJASS without knowing)?

 

[Malhorne]

Constant is a func that will work as constant variables.
It means that they are replaced in the code directly.
So you can clearly abuse it in the config part of your code.

 

[Vinz]

What's the use of constant var vs normal global var?

 

[Vinz]

At the very end of (life) code.

 

[Malhorne]

Search for a missing endif or a endloop

 

[Vinz]

function InitialDeath_Actions takes nothing returns nothing

Unexpected takes?

 

[Malhorne]

oO ?
Post the buggy trigger.

 

[Vinz]

function InitialDeath_Actions takes nothing returns nothing
    local real f
    local real r
    if ( GetUnitTypeId(GetTriggerUnit()) == 'H001' ) or ( GetUnitTypeId(GetTriggerUnit()) == 'H000' ) then
        set f = GetUnitX(GetTriggerUnit())
        set r = GetUnitY(GetTriggerUnit())
        call DestroyEffect(AddSpecialEffect("Objects\\Spawnmodels\\Other\\NeutralBuildingExplosion\\NeutralBuildingExplosion.mdl", f, r ))
    endif
    if ( GetUnitAbilityLevel(GetTriggerUnit(), 'A03K') > 0 ) then
        set udg_A = 1
        loop
            exitwhen udg_A > udg_GB_Index
            if ( GetTriggerUnit() == udg_GB_Caster[udg_A] ) and ( GetTriggerUnit() == udg_GB_Target[udg_A] ) then
                set udg_TempReals[0] = GetUnitX(GetTriggerUnit())
                set udg_TempReals[1] = GetUnitY(GetTriggerUnit())
                set udg_TempTag = CreateTextTag()
                call SetTextTagText(udg_TempTag, ( udg_PlayerColor[GetConvertedPlayerId(GetOwningPlayer(GetKillingUnit()))] + ( udg_PlayerName[GetConvertedPlayerId(GetOwningPlayer(GetKillingUnitBJ()))] + ( " has won " + ( I2S(( 6 + ( 3 * GetUnitAbilityLevel(udg_GB_Caster[udg_A], 'A01W') ) )) + " Vitality!|r" ) ) ) ), 0.00)
                call SetTextTagPos(udg_TempTag, f, r, 0.00)
                call SetTextTagColor(udg_TempTag, PercentTo255(100.00), PercentTo255(100.00), PercentTo255(100.00), PercentTo255(100.0-100.00))
                call SetTextTagVelocityBJ( udg_TempTag, 124.00, 90 )
                call SetTextTagSuspended( udg_TempTag, false )
                call SetTextTagPermanent( udg_TempTag, false )
                call SetTextTagLifespan( udg_TempTag, 3.00 )
                call SetTextTagFadepoint( udg_TempTag, 1.50 )
                call SetHeroStr(GetKillingUnit(), ( 6 + ( 3 * GetUnitAbilityLevel(udg_GB_Caster[udg_A], 'A01W') ) ), true )
                set udg_GB_Duration[udg_A] = 0.00
                call UnitRemoveAbility(GetKillingUnit(), 'B019' )
                call UnitRemoveAbility(GetTriggerUnit(), 'B019' )
            else
            endif
            set udg_A = udg_A + 1
        endloop
    else
    endif
    if ( GetTriggerPlayer() == Player(PLAYER_NEUTRAL_AGGRESSIVE) ) then
    
    else
    endif
endfunction

 

[Malhorne]

Post the whole trigger with init functions and everything
Also you have some bad coding pratice :
- Store GetTriggerUnit into a variable since you're using twice or more.
- Don't use useless BJ like Percent to 255 and SettextTagVelocityBJ or GetConvertedPlayerId
- Also Player(PLAYER_NEUTRAL_AGGRESSIVE) -> Player(12) or Player(13) or Player(14) have to find.

 

[Vinz]

Don't use useless BJ like Percent to 255 and SettextTagVelocityBJ or GetConvertedPlayerId

I need the second since it does what I need to do. And is pretty long.

library InitialDeath
function InitialDeath_Actions takes nothing returns nothing
    local real f
    local real r
    local unit u
    if ( GetUnitTypeId(GetTriggerUnit()) == 'H001' ) or ( GetUnitTypeId(GetTriggerUnit()) == 'H000' ) then
        set u = GetTriggerUnit()
        set f = GetUnitX(u)
        set r = GetUnitY(u)
        call DestroyEffect(AddSpecialEffect("Objects\\Spawnmodels\\Other\\NeutralBuildingExplosion\\NeutralBuildingExplosion.mdl", f, r ))
    endif
    if ( GetUnitAbilityLevel(u, 'A03K') > 0 ) then
        set udg_A = 1
        loop
            exitwhen udg_A > udg_GB_Index
            if ( u == udg_GB_Caster[udg_A] ) or ( u == udg_GB_Target[udg_A] ) then
                set udg_TempReals[0] = GetUnitX(u)
                set udg_TempReals[1] = GetUnitY(u)
                set udg_TempTag = CreateTextTag()
                call SetTextTagText(udg_TempTag, ( udg_PlayerColor[GetPlayerId(GetOwningPlayer(GetKillingUnit()))] + ( udg_PlayerName[GetConvertedPlayerId(GetOwningPlayer(GetKillingUnitBJ()))] + ( " has won " + ( I2S(( 6 + ( 3 * GetUnitAbilityLevel(udg_GB_Caster[udg_A], 'A01W') ) )) + " Vitality!|r" ) ) ) ), 0.00)
                call SetTextTagPos(udg_TempTag, f, r, 0.00)
                call SetTextTagColor(udg_TempTag, 255.00, 255.00, 255.00, 0.00)
                call SetTextTagVelocityBJ( udg_TempTag, 124.00, 90 )
                call SetTextTagSuspended( udg_TempTag, false )
                call SetTextTagPermanent( udg_TempTag, false )
                call SetTextTagLifespan( udg_TempTag, 3.00 )
                call SetTextTagFadepoint( udg_TempTag, 1.50 )
                call SetHeroStr(GetKillingUnit(), ( 6 + ( 3 * GetUnitAbilityLevel(udg_GB_Caster[udg_A], 'A01W') ) ), true )
                set udg_GB_Duration[udg_A] = 0.00
                call UnitRemoveAbility(GetKillingUnit(), 'B019' )
                call UnitRemoveAbility(u, 'B019' )
            else
            endif
            set udg_A = udg_A + 1
        endloop
    else
    endif
    if ( GetTriggerPlayer() == Player(12) ) then
    //Neutral Stuff
    else
    endif
    set u = null
endfunction

//===========================================================================
private function AddEventID takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( t, function InitialDeath_Actions )
    set t = null
endfunction

endlibrary

 

[Malhorne]

Indent after the library.
You want your function AddEventID to be run on the initialization ?

 

[Vinz]

Yes. Weirdly, some functions.. function on init.

Still 'unexpected' takes.

 

[Malhorne]

I'll explain this in evening I've an exam right now
See ya everyone

 

[T. D. W.]

i remember fixing an unexpected takes in KB3D but i can't remember how...
Try rewriting the library, and not CnP or looking what have done and doing the same, just erase, and repeat, you have a backup if you need to

 

[Vinz]

Now everything I've saved right in the last few saves have some non-functional takes. You know where the problems is pushing me? To abandon this motherfucking worthless project. Abandon all life. Because fuck it.

 

[Malhorne]

library YourLibraryName initializer init

    private function DoingSomething takes nothing returns nothing
        //DO
        //Your
        //Stuff
    endfunction

    private function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        //....
        set t = null
    endfunction
endlibrary

 

[Vinz]

How about the 'takes' problem? Everything is throwing an error at my face.

Try rewriting the library, and not CnP or looking what have done and doing the same, just erase, and repeat, you have a backup if you need to

Dude it's just inadmissible. The libraries are too long.

 

[Malhorne]

Send me the map

 

[Vinz]

Sent. Don't leak it please.

 

[Malhorne]

What do you mean by leaking ?

 

[Vinz]

You know, spread the map.
It's not presentable at any time near yet.

 

[Vinz]

Oke so I give up, I hereby request line damage. Thanks..

 

[Malhorne]

Okay

 

[Malhorne]

What do you think about this :

library LineDamage

    globals
        private constant attacktype ATTACK_TYPE = ATTACK_TYPE_MAGIC
        private constant damagetype DAMAGE_TYPE = DAMAGE_TYPE_MAGIC
    endglobals
    
    struct LineDamage extends array
        private static group G
        private static rect R
        
        static method add takes real x1, real y1, real x2, real y2, real dmg, unit caster, boolean hitAlly, boolean hitCaster returns nothing
            local unit u
            local player p = GetOwningPlayer(caster)
            set R = Rect(x1, y1, x2, y2)
            call GroupEnumUnitsInRect(G, R, null)
            if not hitCaster then
                call GroupRemoveUnit(G, caster)
            endif
            loop
                set u = FirstOfGroup(G)
                exitwhen u == null
                call GroupRemoveUnit(G,u)
                if hitAlly or IsUnitEnemy(u, p) then
                    call UnitDamageTarget(caster, u, dmg, true, false, ATTACK_TYPE, DAMAGE_TYPE, null)
                endif
            endloop
            set p = null
            call RemoveRect(R)
            set R = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set G = CreateGroup()
        endmethod
    endstruct
endlibrary

To add one to this

call LineDamage.add(x1, y1, x2, y2, damage, caster, hitally, hitcaster)

The coordinates are the ones of point A and point B :

A
|----------------------------------------|
|                                                 |
|----------------------------------------|B

 

[Malhorne]

Fuc this ASCII gometry !
Dat TYPO :3

 

[Vinz]

You are truly amazing, Almighty Malhorne. One thing though. Attack/Damage type configurable.

 

[Malhorne]

You don't want this to be constant at the begginning you want to give them to the func too ?

 

[Vinz]

Umm nope. Most of the time it"s not magic.
And I'll use it for a gazillion spells.

Oh wait. Please support.. ground fx and a dummy that will be used as a projectile..

 

[Malhorne]

Ok so I'll change it a bit

 

[Malhorne]

Btw it is untested but I don't think it will bug on something like thiis

EDIT:

library LineDamage
    
    struct LineDamage extends array
        private static group G
        private static rect R
        
        static method add takes real x1, real y1, real x2, real y2, real dmg, unit caster, boolean hitAlly, boolean hitCaster, attacktype a_type, damagetype d_type returns nothing
            local unit u
            local player p = GetOwningPlayer(caster)
            set R = Rect(x1, y1, x2, y2)
            call GroupEnumUnitsInRect(G, R, null)
            if not hitCaster then
                call GroupRemoveUnit(G, caster)
            endif
            loop
                set u = FirstOfGroup(G)
                exitwhen u == null
                call GroupRemoveUnit(G,u)
                if hitAlly or IsUnitEnemy(u, p) then
                    call UnitDamageTarget(caster, u, dmg, true, false, a_type, d_type, null)
                endif
            endloop
            set p = null
            call RemoveRect(R)
            set R = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set G = CreateGroup()
        endmethod
    endstruct
endlibrary

call LineDamage.add(x1,y1,x2,y2,dmg,caster,hitAlly,hitCaster,a_type,d_type)

 

[Vinz]

My last post please sorry for being a bother..

 

[Malhorne]

Oh that needs more

Okay explain more what do you want !
I might do it tomorrow morning (I did it before so I'll CnP and change a bit) or I'll do it tomorrow evening (I'll have to go to bed).

Where the ground fx should should be and when ?

 

[Vinz]

Along the line from whence the enemies are picked. And if possible, I will create the dummies manually, so I can set their facing angle configurably. So the argument would take a unit, not a sfx to be created on the dummy.

Wait. We can use items as dummies right? Though some configurability is lost, with Item Cleanup, it is admissible, right? because items are cleaned and units leak.

 

[Malhorne]

Write the arguments you need and I'll do it tomorrow

I'm going to bed see you

 

[Vinz]

unit dummy, string line_sfx

 

[Malhorne]

So you want a func that call
call LineDamage.add(x1, y1, x2, y2, caster, dummy, line_sfx, hitAlly)
?

 

[Vinz]

Yup..

 

[Malhorne]

Ok expect it this evening or tomorrow I have a friend birthday this afternoon and then I've a preparation to do in English for monday xD

 

[Vinz]

Can scopes require libraries?