hashtable and damage blocking issue

[Battlehound]

Hello Hive

I'm trying to create a spell where an Enchantress Hero periodically shields her allied Heroes for 50 points.
The Shield is applied to all allied Heroes, picked through a unit group. The units have a special effect applied to them (A mana shield) and the shield value assigned in a hashtable.

The shield is supposed to stack, so whenever the trigger runs without the unit having taken 50+ damage since last time, another "stack" of 50 points is added to the shield.
I've gotten the shield part working, and the unit seems to be blocking and stacking properly. However the special effect (the mana shield model) attached to the unit doesn't seem to be removed, it just gets thicker and thicker, not dissappearing along with the shield.
Can anyone give me advice to this?

The trigger is twofold, a periodic trigger for applying shield and saving stuff in hashtables, and the actual damagereduction trigger (Thx for Bribe for this bit).

Shield Apply

• Events
  • Time - Every 15.00 seconds of game time

Damage Reduction

• Warden ShieldBlocking
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventSource belongs to an enemy of Player 1 (Red)) Equal to True
    • (Unit-type of DamageEventTarget) Not equal to Enchantress (Healer)
  • Actions
    • Unit Group - Pick every unit in Ward_Tempug and do (Actions)
      • Loop - Actions
        • -------- Loads the ShieldAmount real from Ward_hash --------
        • Game - Display to (All players) for 2.00 seconds the text: (Shield amount for blocking = + (String(Ward_Tempr1)))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DamageEventAmount Greater than or equal to Ward_Tempr1
          • Then - Actions
            • -------- If the Damage is greater than or equal to the shield size, the shield is removed, but damage still reduced by however much was left --------
            • Set Ward_ShieldEffect = (Load (Key ShieldEffect) of (Key (Picked unit)) in Ward_hash)
            • Special Effect - Destroy Ward_ShieldEffect
            • Set DamageEventAmount = (DamageEventAmount - Ward_Tempr1)
            • Set Ward_Tempr1 = 0.00
            • Hashtable - Save Ward_Tempr1 as (Key ShieldAmount) of (Key (Picked unit)) in Ward_hash
            • Game - Display to (All players) for 2.00 seconds the text: ([1]Damage down to = + (String(Ward_Tempr1)))
          • Else - Actions
            • -------- If the shield is greater than the damage dealt, the shield persists and both remaining shield and damage are reduced --------
            • Set Ward_Tempr1 = (Ward_Tempr1 - DamageEventAmount)
            • Set DamageEventAmount = 0.00
            • Hashtable - Save Ward_Tempr1 as (Key ShieldAmount) of (Key (Picked unit)) in Ward_hash
            • Game - Display to (All players) for 2.00 seconds the text: ([2]Damage down to = + (String(Ward_Tempr1)))

Any help is much appreciated.

 

[ivofena]

Hello Hive

I'm trying to create a spell where an Enchantress Hero periodically shields her allied Heroes for 50 points.
The Shield is applied to all allied Heroes, picked through a unit group. The units have a special effect applied to them (A mana shield) and the shield value assigned in a hashtable.

The shield is supposed to stack, so whenever the trigger runs without the unit having taken 50+ damage since last time, another "stack" of 50 points is added to the shield.
I've gotten the shield part working, and the unit seems to be blocking and stacking properly. However the special effect (the mana shield model) attached to the unit doesn't seem to be removed, it just gets thicker and thicker, not dissappearing along with the shield.
Can anyone give me advice to this?

The trigger is twofold, a periodic trigger for applying shield and saving stuff in hashtables, and the actual damagereduction trigger (Thx for Bribe for this bit).

Shield Apply

• Events
  • Time - Every 15.00 seconds of game time

Damage Reduction

• Warden ShieldBlocking
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventSource belongs to an enemy of Player 1 (Red)) Equal to True
    • (Unit-type of DamageEventTarget) Not equal to Enchantress (Healer)
  • Actions
    • Unit Group - Pick every unit in Ward_Tempug and do (Actions)
      • Loop - Actions
        • -------- Loads the ShieldAmount real from Ward_hash --------
        • Game - Display to (All players) for 2.00 seconds the text: (Shield amount for blocking = + (String(Ward_Tempr1)))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DamageEventAmount Greater than or equal to Ward_Tempr1
          • Then - Actions
            • -------- If the Damage is greater than or equal to the shield size, the shield is removed, but damage still reduced by however much was left --------
            • Set Ward_ShieldEffect = (Load (Key ShieldEffect) of (Key (Picked unit)) in Ward_hash)
            • Special Effect - Destroy Ward_ShieldEffect
            • Set DamageEventAmount = (DamageEventAmount - Ward_Tempr1)
            • Set Ward_Tempr1 = 0.00
            • Hashtable - Save Ward_Tempr1 as (Key ShieldAmount) of (Key (Picked unit)) in Ward_hash
            • Game - Display to (All players) for 2.00 seconds the text: ([1]Damage down to = + (String(Ward_Tempr1)))
          • Else - Actions
            • -------- If the shield is greater than the damage dealt, the shield persists and both remaining shield and damage are reduced --------
            • Set Ward_Tempr1 = (Ward_Tempr1 - DamageEventAmount)
            • Set DamageEventAmount = 0.00
            • Hashtable - Save Ward_Tempr1 as (Key ShieldAmount) of (Key (Picked unit)) in Ward_hash
            • Game - Display to (All players) for 2.00 seconds the text: ([2]Damage down to = + (String(Ward_Tempr1)))

Any help is much appreciated.

Make a unit group for the special effect only. If the shielded unit is in the group then do nothing, if it isn't add the special effect to the unit and add the unit to the unit group. Upon shield end remove special effect from the unit and remove the unit from the unit group.

 

[Maker]

You could check if the shield is saved into the hashtable, handle type. Boolean -> Hashtable - value exists. If the effect exists, don't create a new one.

 

[Nichilus]

Dunno if this is correct, but the damage modifying trigger picks all units Ward_tempug. Basically an enemy deals 25 damage to some hero and that damage is applied to all units in ward_tempug.

 

[Wietlol]

I suggest re-organizing the spell.

When you add it, you increase a number in the hashtable saved under the key of the target (the one who gets the shield) and save the effect on it (if it didnt already had one).

Then when a unit takes damage, check if that value in the hashtable is bigger than 0, this means that the target has a shield.
So you can then remove the shield properly.

However, I dont really know how you make the shield bigger... so there might be something that wouldnt work because of how you intent to do that.

Also, I suggest you to use a unit indexer with arrays instead of a hashtable or use Table (but that is JASS only actually).

 

[Bribe]

Battlehound, please update to DamageEngine 3 as I have fixed the issues with modifying damage.

Also, since Unit Indexer is already in the map, just use an array to store the sfx to the custom value of the unit.

 

[Battlehound]

I don't have access to the map just now, but I will update this thread at some later time. For now, thanks for all the feedback. I'll go through it in some time, but am rather busy at the moment as well.