Hashtable and Damage Blocking Ability Help Needed

[Woodenplank]

Hello Hive!

I'm in need of some help for a Shield Spell that I'm triggering. The spell is called "Cragskin" (you'll see that in variable names) and it targets an ally, giving them a buff. Based off of Frost Armor.

The spell is supposed to reduce the damage of the next 3 incoming attacks/damage sources by a percentage. So when the buff is on, the trigger should count to 3 (using Bribe's Damage Detection Engine) and reduce those attacks by for instance 45%, then the buff should be removed after 3 attacks.

Problem here is that the hashtable I use to save the Hits-Taken for each affected unit always returns 0, can anyone here spot the problem?

Triggers

• Cragskin Activate
  • Events
    • Unit - A unit owned by Player 1 (Red) Starts the effect of an ability
    • Unit - A unit owned by Player 2 (Blue) Starts the effect of an ability
    • Unit - A unit owned by Player 3 (Teal) Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Cragskin
  • Actions
    • Set Cragskin_r = (0.25 + (0.15 x (Real((Level of (Ability being cast) for (Triggering unit))))))
    • Set Cragskin_Counteri = 3
    • Hashtable - Save (Real(Cragskin_Counteri)) as (Key HitsCounter) of (Key (Target unit of ability being cast)) in Cragskin_hash

• Cragskin HitTaken
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventTarget has buff Cragskin ) Equal to True
  • Actions
    • Game - Display to (All players) the text: Run
    • Set Cragskin_Tempu1 = DamageEventTarget
    • Unit Group - Pick every unit in (Units in (Playable map area) matching ((Matching unit) Equal to Cragskin_Tempu1)) and do (Actions)
      • Loop - Actions
        • Set Cragskin_Tempu2 = (Picked unit)
        • Set Cragskin_Counteri = (Load (Key HitsCounter) of (Key (Picked unit)) from Cragskin_hash)
        • Game - Display to (All players) the text: (String(Cragskin_Counteri))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Cragskin_Counteri Greater than or equal to 1
          • Then - Actions
            • Set DamageEventAmount = (DamageEventAmount - (DamageEventAmount x Cragskin_r))
            • Hashtable - Save (Real((Cragskin_Counteri - 1))) as (Key HitsCounter) of (Key (Picked unit)) in Cragskin_hash
          • Else - Actions
            • Unit - Remove Cragskin buff from Cragskin_Tempu2

thanks in advance.

 

[Wietlol]

First of all... why don't you use a generic starts the effect of an ability event?

Secondly... why group all units in the map and check if they are a specific unit?
You already have that unit so no need to loop through all of em.

For the problem... I think that a hashtable does not return an integer if you did LoadReal().
Try LoadInteger() instead.

 

[Woodenplank]

Secondly... why group all units in the map and check if they are a specific unit?
You already have that unit so no need to loop through all of em.

I did it to be capable of using the "handle: Picked unit" in the hashtable, is there a way to work around this handle method?

And also, the hashtables concerning the integer all use save/load integer () now, but they still don't work.

 

[Wietlol]

Key of (DamageEventTarget) not working?

Make 2 actions "Game - Display text" and let them show the key you are using, check if they are the same. (One on spellcast and the other on take damage.)

Also where does HitsCounter come from?

I suppose that that could just be an integer instead of a key.

 

[Woodenplank]

I tried what you suggested (assuming that I understood the suggestion properly), and it seems that the integer is set correctly (to 3) on spell cast, but immediatly goes to 0 when damage is taken. Here are the triggers as of now:

That's my trigger

• Cragskin Activate
  • Events
    • Unit - A unit owned by Player 1 (Red) Starts the effect of an ability
    • Unit - A unit owned by Player 2 (Blue) Starts the effect of an ability
    • Unit - A unit owned by Player 3 (Teal) Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Cragskin
  • Actions
    • Set Cragskin_r = (0.25 + (0.15 x (Real((Level of (Ability being cast) for (Triggering unit))))))
    • Set Cragskin_Counteri = 3
    • Hashtable - Save Cragskin_Counteri as 1 of (Key (Target point of ability being cast)) in Cragskin_hash
    • Game - Display to (All players) the text: ((Load (Key (Target unit of ability being cast)) of 1 from (Last created hashtable)) + (String(Cragskin_Counteri)))

• Cragskin HitTaken
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventTarget has buff Cragskin ) Equal to True
  • Actions
    • Game - Display to (All players) the text: Run noUg
    • Set Cragskin_Counteri = (Load 1 of (Key (Target unit of ability being cast)) from Cragskin_hash)
    • Set Cragskin_Tempu2 = DamageEventTarget
    • Game - Display to (All players) the text: ((Load (Key (Target unit of ability being cast)) of 1 from (Last created hashtable)) + (String(Cragskin_Counteri)))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Cragskin_Counteri Greater than or equal to 1
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount - (DamageEventAmount x Cragskin_r))
        • Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (Target unit of ability being cast)) in Cragskin_hash
      • Else - Actions
        • Unit - Remove Cragskin buff from Cragskin_Tempu2

 

[Wietlol]

Then I think you forgot to create the hashtable.
"Hashtable - Create a hashtable"
"Set Cragskin_hash = Last Created Hashtable"

 

[Woodenplank]

Then I think you forgot to create the hashtable.
"Hashtable - Create a hashtable"
"Set Cragskin_hash = Last Created Hashtable"

Nope, I did that alright.

 

[Woodenplank]

Bumping for help.

 

[Wietlol]

Well... you could use my Effect Over Time System to make the effect.
However it is not yet finished and will take up to a week to be finished.

If you can wait until then you have a perfect working one.
It has an in-built hashtable that grants easy control over the data.
You will also have some nice features about buffs.

But again, I cannot see what the problem is in your trigger.
So someone else should help you or you have to wait a week.
If so I can make this spell for you. It is not that hard.

 

[Gismo359]

You save Cragskin_Counteri as 1 of Key (...) but load it as Key (...) of 1.

 

[Wietlol]

Only in the message which doesn't make any sense... because it is a message you know.

 

[Gismo359]

Ah, I didnt see that. Your trigger event has nothing to do with abilities (the second one), so there is no "Target unit of ability being cast".

 

[Woodenplank]

Ah, I didnt see that. Your trigger event has nothing to do with abilities (the second one), so there is no "Target unit of ability being cast".

That's why I went with the "picked unit" work-around from the initial bit, is there other way to do this?

 

[Wietlol]

Now that I tried it myself...
I cannot pick any unit at all.
I can only pick handle variables.

I cannot do (Key of (Picked unit)) nor the one of (Triggering unit) or (Targeted unit of ability being cast)
Am I doing something wrong?

 

[Gismo359]

In that one you pick every unit that is equal to DamageEventTarget. Just use DamageEventTarget. Also makes sure HitsCounter stays the same, so you load the correct value.

E: Cragskin_Counteri is getting changed everytime the second trigger triggers, so if multiple units cast it there will surely be a problem. You can replace this:

• Set Cragskin_Tempu2 = DamageEventTarget

with: local unit udg_Cragskin_Tempu2 = udg_DamageEventTarget

@Wietlol GUI hashtables arent in JNGP. If you have a trigger with them, it will work correctly but you cant actualy create those actions.

 

[Wietlol]

In that one you pick every unit that is equal to DamageEventTarget. Just use DamageEventTarget. Also makes sure HitsCounter stays the same, so you load the correct value.

E: Cragskin_Counteri is getting changed everytime the second trigger triggers, so if multiple units cast it there will surely be a problem. You can replace this:

• Set Cragskin_Tempu2 = DamageEventTarget

with: local unit udg_Cragskin_Tempu2 = udg_DamageEventTarget

That is not entirely true because he sets that value to the value from the hashtable.

However you can use this instead:

• Set TempUnit = DamageEventTarget
• Custom script: set udg_TempInteger = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_TempUnit), 1)
• Set Cragskin_Counteri = TempInteger

You require 2 variables "TempUnit : unit" and "TempInteger : integer".
That code is the best way to do it... you can indeed just use one custom script:

• Custom script: set udg_Cragskin_Counteri = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_DamageEventTarget), 1)

But that can only be used in that trigger.
If you have other problems, the first one can also be applied to other triggers.

@Wietlol GUI hashtables arent in JNGP. If you have a trigger with them, it will work correctly but you cant actualy create those actions.

So lame -_-
However as I said before I never use GUI.
So I guess that I don't really have to care

 

[Woodenplank]

I followed your advice Wietl, and the trigger now looks like this

Trigger On-Hit

• Cragskin HitTaken
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventTarget has buff Cragskin ) Equal to True
  • Actions
    • Game - Display to (All players) the text: Run noUg
    • Set Cragskin_Tempu2 = DamageEventTarget
    • Custom script: set udg_TempInteger = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_Cragskin_Tempu2), 1)
    • Set Cragskin_Counteri = TempInteger
    • Game - Display to (All players) the text: ((Load (Key (Target unit of ability being cast)) of 1 from Cragskin_hash) + (String(Cragskin_Counteri)))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Cragskin_Counteri Greater than or equal to 1
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount - (DamageEventAmount x Cragskin_r))
        • Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (Target unit of ability being cast)) in Cragskin_hash
      • Else - Actions
        • Unit - Remove Cragskin buff from Cragskin_Tempu2

But it still doesn't work, the buff is immediatly removed and no damage is negated.

 

[Wietlol]

• Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (Target unit of ability being cast)) in Cragskin_hash

Use Cragskin_Tempu2 + custom script again (Cragskin_Tempu2 should be TempUnit to reduce your amount of global variables)

• Game - Display to (All players) the text: ((Load (Key (Target unit of ability being cast)) of 1 from Cragskin_hash) + (String(Cragskin_Counteri)))

Try to put the Cragskin_Counteri in it instead and see if the data is stored properly... Because it is not. Otherwise the damage would be reduced.

 

[Woodenplank]

• Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (Target unit of ability being cast)) in Cragskin_hash

Use Cragskin_Tempu2 + custom script again (Cragskin_Tempu2 should be TempUnit to reduce your amount of global variables)

• Game - Display to (All players) the text: ((Load (Key (Target unit of ability being cast)) of 1 from Cragskin_hash) + (String(Cragskin_Counteri)))

Try to put the Cragskin_Counteri in it instead and see if the data is stored properly... Because it is not. Otherwise the damage would be reduced.

Sorry I do not quite understand, where are each of these supposed to go? Which lines in my trigger should be changed?

 

[Wietlol]

Those are both from the trigger you posted -_-
At the bottom you save again but then on "Target unit of ability being cast".
That should be that custom script again.

The display message should use the exact same reference as what you use... which is Cragskin_Counteri rather than loading from the hashtable again. (not for performance but to avoid mistakes)
Also try to diplay the name of the targeted unit and the number of the stacks.

 

[Gismo359]

• Set Cragskin_Tempu2 = DamageEventTarget
• Custom script: set udg_TempInteger = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_Cragskin_Tempu2), 1)
• Set Cragskin_Counteri = TempInteger

->

• Custom script: set udg_Cragskin_Counteri = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_DamageEventTarget), 1)

Also:

• Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (Target unit of ability being cast)) in Cragskin_hash

->

• Hashtable - Save (Cragskin_Counteri - 1) as 1 of (Key (DamageEventTarget)) in Cragskin_hash

 

[Wietlol]

You cannot use variables inside the key method of hashtables.

Also:

• Set TempUnit = DamageEventTarget
• Custom script: set udg_TempInteger = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_TempUnit), 1)
• Set Cragskin_Counteri = TempInteger

You require 2 variables "TempUnit : unit" and "TempInteger : integer".
That code is the best way to do it... you can indeed just use one custom script:

• Custom script: set udg_Cragskin_Counteri = LoadInteger(udg_Cragskin_hash, GetHandleId(udg_DamageEventTarget), 1)

But that can only be used in that trigger.
If you have other problems, the first one can also be applied to other triggers.

 

[Gismo359]

Yeah, I saw you posted it but I though he didnt(judging from his post).

Also, call SaveInteger(udg_Cragskin_hash, GetHandleId(udg_DamageEventTarget), 1, udg_Cragskin_Counteri - 1) then. Stupid, if you ask me.

 

[Wietlol]

Yea it seems that JNGP doesn't support any handles in the Key() GUI function and the regular editor does not allow variables... I guess.