GUI Movement System v1.6

[Moderator]

17:30 Dec 3, 2012
Magtheridon96: Approved.
This is a useful and robust system.

 

[CHA_Owner]

*Subscribing*

Please let me know of any changes or leaks that you may find.

 

[doomhammer99]

You've done a Great Job. 4/5

 

[Chaosy]

I agree this is useful the code looks better than most of the systems out there so 4/5 from me.

 

[stonneash]

Well Coded 5\5

 

[Almia]

Maybe ,you can cache those uncached variables like picked player and stuff.
Also,You have 8 leaks,all locations.

If i am right,you can actually remove the other events because they have already the same.So you are running to events at the same time,w/c is ugly.

I suggest put some camera rotations and angle of attack because it will be good for you system,just like The_Witchers movement system.

This system needs to be marked as needs fix.

 

[CHA_Owner]

Maybe ,you can cache those uncached variables like picked player and stuff.
Also,You have 8 leaks,all locations.

If i am right,you can actually remove the other events because they have already the same.So you are running to events at the same time,w/c is ugly.

I suggest put some camera rotations and angle of attack because it will be good for you system,just like The_Witchers movement system.

This system needs to be marked as needs fix.

Updated all leaks now fixed and this is just a simple movement system so i am not including any type of camera system along with it.

 

[Almia]

You still have leaks,thats because you are using offsets.
Offsets leaks twice if you dont cache the other location inside it.
You leak this:
position of blah blah

 

[TKF]

You must create 2 points when using offsets to clean up both point leaks, because offset is also a point which leaks.

Set GMS_TempPoint = position of unit
Set GMS_TempPoint2 = ((Position of (GMS_TempPoint)) offset by GMS_MovementOffset towards GMS_DownDegree degrees)


Then you should be a bit closer to approval.

 

[Almia]

Set GMS_TempPoint2 = ((Position of (GMS_TempPoint)) offset by GMS_MovementOffset towards GMS_DownDegree degrees)

You make me laugh Position of (GMS_TempPoint
Position of Position

 

[TKF]

You make me laugh Position of (GMS_TempPoint
Position of Position

So you are telling me this is wrong?
http://www.hiveworkshop.com/forums/275051-post2.html

 

[rulerofiron99]

You make me laugh Position of (GMS_TempPoint
Position of Position

TKF is correct.

 

[doomhammer99]

You must create 2 points when using offsets to clean up both point leaks, because offset is also a point which leaks.

Set GMS_TempPoint = position of unit
Set GMS_TempPoint2 = ((Position of (GMS_TempPoint)) offset by GMS_MovementOffset towards GMS_DownDegree degrees)

Then you should be a bit closer to approval.[/QUOTE]

He's wrong; Position of TempPoint????

• Set GMS_TempPoint2 = GMS_TempPoint offset by GMS_MovementOffset towards GMS_DownDegree degrees

This is the Correct trigger

 

[CHA_Owner]

Okay now all the point leaks should be taken care of and also on the next version i was thinking of making it to were you can change the movement offset to w/e for each arrow key instead of just 1 offset for all sound like a good idea?

EDIT*

common guys i need some suggestions should i make each offset changeable seperately or should it remain how it is?

if i changed it then you would be able to customize how far the unit could move with each arrow key seperately but if i did that then there would be 7 more variables added to the list and the question is that too much overhead? if not ill definitely update but other than that i think this system is good to go at this point!

EDIT 2*

New version now uploaded with the offsets being set individually and all comments and the how to import updated!

 

[CHA_Owner]

*BUMP*

approval please?

EDIT*

working on update right now

 

[CHA_Owner]

Update made due to moderator review the movement controller trigger is now more efficient and shorter!

 

[Magtheridon96]

Geries was able to make your trigger shorter:

Trigger

• Movement Controller
  • Events
  • Conditions
  • Actions
    • Custom script: set udg_GMS_id = GetHandleId( GetTriggerEventId() ) - 260
    • Set GMS_TempPlayer = (Triggering player)
    • Set GMS_TriggerPlayer = (Player number of GMS_TempPlayer)
    • -------- Updating key status --------
    • Custom script: if udg_GMS_id / 2 * 2 != udg_GMS_id then
    • -------- If pressing --------
    • Set GMS_Keys[((( GMS_id / 2 ) + 1 ) + ( GMS_TriggerPlayer * 12 ))] = True
    • Player Group - Add GMS_TempPlayer to GMS_TriggerPlayerGroup
    • Custom script: else
    • -------- If releasing --------
    • Set GMS_Keys[(( GMS_id / 2 ) + ( GMS_TriggerPlayer * 12 ))] = False
    • -------- If no arrow keys are pressed then it removes the player from the system. --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • GMS_Keys[( GMS_TriggerPlayer * 12 )] Equal to (==) False
        • GMS_Keys[( 1 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
        • GMS_Keys[( 2 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
        • GMS_Keys[( 3 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
      • Then - Actions
        • Player Group - Remove GMS_TempPlayer from GMS_TriggerPlayerGroup
      • Else - Actions
    • Custom script: endif

He used the same method that Bribe used in ArrowKeyEvent.

This way, you only use 1 array.
I'd recommend speaking to him about it

 

[CHA_Owner]

Geries was able to make your trigger shorter:

Trigger

• Movement Controller
  • Events
  • Conditions
  • Actions
    • Custom script: set udg_GMS_id = GetHandleId( GetTriggerEventId() ) - 260
    • Set GMS_TempPlayer = (Triggering player)
    • Set GMS_TriggerPlayer = (Player number of GMS_TempPlayer)
    • -------- Updating key status --------
    • Custom script: if udg_GMS_id / 2 * 2 != udg_GMS_id then
    • -------- If pressing --------
    • Set GMS_Keys[((( GMS_id / 2 ) + 1 ) + ( GMS_TriggerPlayer * 12 ))] = True
    • Player Group - Add GMS_TempPlayer to GMS_TriggerPlayerGroup
    • Custom script: else
    • -------- If releasing --------
    • Set GMS_Keys[(( GMS_id / 2 ) + ( GMS_TriggerPlayer * 12 ))] = False
    • -------- If no arrow keys are pressed then it removes the player from the system. --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • GMS_Keys[( GMS_TriggerPlayer * 12 )] Equal to (==) False
        • GMS_Keys[( 1 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
        • GMS_Keys[( 2 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
        • GMS_Keys[( 3 + ( GMS_TriggerPlayer * 12 ))] Equal to (==) False
      • Then - Actions
        • Player Group - Remove GMS_TempPlayer from GMS_TriggerPlayerGroup
      • Else - Actions
    • Custom script: endif

He used the same method that Bribe used in ArrowKeyEvent.

This way, you only use 1 array.
I'd recommend speaking to him about it

hmmmm thanks for showing me this im looking into it now.

 

[CHA_Owner]

Updated thanks to mag for showing me a better way to register the arrowkey events

 

[hrky]

i am sooo.. going to use this in my map great system 5/5, +rep

 

[Losam]

What is this system? I do not understand.

 

[Almia]

this is system is just like for rpgs and some arena thingys.
this lets you to move w/ up,down,left,right arrow keys just like platformers.

 

[Losam]

Thank you.

 

[CHA_Owner]

*BUMP*

approval please?

 

[CHA_Owner]

System updated should be as efficient as possible now!

 

[Mekket]

Hello, first off I'd like to say that this is probably the most smooth GUI arrow key movement system I've come across so far.

However, there seems to be a problem with handling collision. Whenever my unit bumps into anything that has collision except units (pathing blocker, tree, cliff, etc.), the unit gets stuck for a few seconds. You have to release all arrow keys and then wait until the 'stop' order is issued before you can do anything at all again. For some reason this does not happen when you collide with other units. I suggest spawning a few trees, a cliff and a wall of pathing blockers for yourself to test it out. It can get really frustrating at times.

I just figured to put it out there if you have any intention of further improving an already great system. Thanks!

 

[ukn0wnD3str0y3r]

Before I use this, can anyone tell me if i want to make the setting after Picked hero, how to do it? o.0