Greater Heal v1.4 (GUI)

[Moderator]

16:35, 24th Jul 2010
TriggerHappy:

You cleaned the leaks and it works fine.

 

[tjordell]

The spell will be more flexible if you use

• (Triggering unit)

Instead of

• (Casting unit)

Because the triggering unit is the same as the casting unit. (The triggering unit is the one that triggers off the whole trigger (casting unit)).

So for mor flexibility of you'r spell, change all casting unit to triggering unit because then the World Editor picks the triggering unit right away instead of "searching" for the casting unit and if there's no triggering unit the function will return NULL.

You leak this one below because you dont destroy the Special effect.

• Special Effect - Create a special effect at (Position of (Casting unit)) using Abilities\Spells\Items\AIma\AImaTarget.mdl

The most special effects should be destroyed right after it has been created (the effect will still occur). Put this following right after the action above

• Special Effect - Destroy (Last created special effect)

Also in the

• Special Effect - Create a special effect at (Position of (Casting unit)) using Abilities\Spells\Items\AIma\AImaTarget.mdl

you leak a location.
Create a Variable called like "Loc" with array 1 and have it as a point variable and do this below

• Set Loc[1] = (Position of (Triggering unit))
• Special Effect - Create a special effect at Loc[1] using Abilities\Spells\Items\AIma\AImaTarget.mdl
• Custom script: call RemoveLocation (udg_Loc[1])

Also you should remove all the actions

• Do nothing

because if you remove it, the trigger will not do anything in all cases. The action Do nothing just makes the trigger bigger and that makes the spell a little slower.

Here in the condition below

• ((Target unit of ability being cast) is in (Units in (Playable map area) matching (((Target unit of ability being cast) belongs to an ally of (Owner of (Casting unit))) Equal to True))) Equal to True

You must change Target unit of ability being cast to Matching Unit and also the Casting unit to Triggering unit as i said. Makes also the spell more flexible.

You leak a unit group and a location here below

• Unit Group - Pick every unit in (Units within 800.00 of (Position of (Target unit of ability being cast)) matching (((Matching unit) Not equal to (Target unit of ability being cast)) and (((Owner of (Matching unit)) is an ally of (Owner of (Casting unit))) Equal to True))) and do (Actions)

You should do this below (Create a variable called like "Group" and set it to Unit Group)

• Set Loc[2] = (Position of (Target unit of ability being cast))
• Set Group = (Units within 800.00 of Loc[2] matching ((Matching unit) Not equal to (Target unit of ability being cast))) /// and load in with more of the conditions you want
• Unit Group - Pick every unit in Group and do (Actions)
  • Loop - Actions
    • Load in with Actions here
• Custom script: call DestroyGroup (udg_Group) /// Do this after the Unit group action.
• Custom script: call RemoveLocation (udg_Loc[2]) /// Destroys the leak.

Also you do the same misstake TWICE a bit below that Unit Group Leak

Well that was all. This spell is not going to be approven because of all the leaks and stuffs. Well good calculating. You must learn some more about how to avoid leaks. Well here is the best place. Go to Tutorials and search there for a way to learn how to avoid this.

 

[Lethien]

Quote

The spell will be more flexible if you use

• (Triggering unit)

Instead of

• (Casting unit)

Because the triggering unit is the same as the casting unit. (The triggering unit is the one that triggers off the whole trigger (casting unit)).

So for mor flexibility of you'r spell, change all casting unit to triggering unit because then the World Editor picks the triggering unit right away instead of "searching" for the casting unit and if there's no triggering unit the function will return NULL.

You leak this one below because you dont destroy the Special effect.

• Special Effect - Create a special effect at (Position of (Casting unit)) using Abilities\Spells\Items\AIma\AImaTarget.mdl

The most special effects should be destroyed right after it has been created (the effect will still occur). Put this following right after the action above

• Special Effect - Destroy (Last created special effect)

Also in the

• Special Effect - Create a special effect at (Position of (Casting unit)) using Abilities\Spells\Items\AIma\AImaTarget.mdl

you leak a location.
Create a Variable called like "Loc" with array 1 and have it as a point variable and do this below

• Set Loc[1] = (Position of (Triggering unit))
• Special Effect - Create a special effect at Loc[1] using Abilities\Spells\Items\AIma\AImaTarget.mdl
• Custom script: call RemoveLocation (udg_Loc[1])

Also you should remove all the actions

• Do nothing

because if you remove it, the trigger will not do anything in all cases. The action Do nothing just makes the trigger bigger and that makes the spell a little slower.

Here in the condition below

• ((Target unit of ability being cast) is in (Units in (Playable map area) matching (((Target unit of ability being cast) belongs to an ally of (Owner of (Casting unit))) Equal to True))) Equal to True

You must change Target unit of ability being cast to Matching Unit and also the Casting unit to Triggering unit as i said. Makes also the spell more flexible.

You leak a unit group and a location here below

• Unit Group - Pick every unit in (Units within 800.00 of (Position of (Target unit of ability being cast)) matching (((Matching unit) Not equal to (Target unit of ability being cast)) and (((Owner of (Matching unit)) is an ally of (Owner of (Casting unit))) Equal to True))) and do (Actions)

You should do this below (Create a variable called like "Group" and set it to Unit Group)

• Set Loc[2] = (Position of (Target unit of ability being cast))
• Set Group = (Units within 800.00 of Loc[2] matching ((Matching unit) Not equal to (Target unit of ability being cast))) /// and load in with more of the conditions you want
• Unit Group - Pick every unit in Group and do (Actions)
  • Loop - Actions
    • Load in with Actions here
• Custom script: call DestroyGroup (udg_Group) /// Do this after the Unit group action.
• Custom script: call RemoveLocation (udg_Loc[2]) /// Destroys the leak.

Also you do the same misstake TWICE a bit below that Unit Group Leak

Well that was all. This spell is not going to be approven because of all the leaks and stuffs. Well good calculating. You must learn some more about how to avoid leaks. Well here is the best place. Go to Tutorials and search there for a way to learn how to avoid this.

thx was kinda hoping for suggestions

 

[tjordell]

Hehe it took me like 20 minutes to write and check everything xD

 

[eennffoo]

uhmmm...found a little bug...the spell heals dead units, too.

 

[Noobsmoke]

the bug can be removed with only 1 condition

 

[Darkzealot_128]

It seems to have leaks.

 

[tjordell]

Hehe guys! I've told him everything now xD Watch the first post xD

EDIT: Change the things i told you and then you give me a PM and i'll make a new review. Dont forget to set the spell name to "Greater Heal 1.1 (GUI)" after that so ppls can see that you've changed the spell =)

 

[.OmG.]

If abity casted then level of this ability >= 1 - 100%
You don`t need condition

• If - Conditions
• (Level of Focus for (Casting unit)) Greater than 0

 

[Lethien]

Have been on holiday, will upload v1.1 within a week.

If - Conditions
(Level of Focus for (Casting unit)) Greater than 0

Focus is not the spell that's being cast, its a modifier for the spell that's beeing cast.

Edit:... Kk, all was fixed, until my world editor crashed when using Edit>Find.

-.-

Edit 2: Update. v1.1 is now uploaded, thanks for your help so far.

Edit 3: Update. v1.2 is uploaded, the spell will now fit in a 'normal' warcraft 3 (melee) map. Don't hesitate to comment. Allso, .2 was a crapload of work because I kept doing everything wrong.

Edit 4: Update. v1.3 is uploaded, it was not a major update but I fixed a leak of which I knew it was there but I was unable to fix it before. Thanks Tjordell, anyway, hope its leak free now.
_______________________________________
wait for 1.3b before downloading, found a bug where u nearly die when using the spell on the abomination. can't find the problem :/
_______________________________________
Edit 5: Opdate. v1.3b is now uploaded. Removed a set variable action.
Replaced a really stupid bug where ur hero would lose a huge amount of health when having an offensive critical strike.

Edit 6: Update. v1.3c is uploaded. There was a bug in the Focus ability, which increased the amount healed by an additional 100% per level, but this has been changed and now works properly.

Edit 7: (Final?) Update. v1.4 is now uploaded. I fixed the tooltips of all abilities, decreased the range of Greater Heal and Holy Excess and added a dummy ability to show the tooltip of Focus. Also fixed the percentage of mana regained if Focus procs. All abilities are now also keybinded accordingly. Also fixed my horrible spelling from 2 years ago.