Gold and / or Lumber Banking System v 1.0.0.6

[Moderator]

18:27, 19th Aug 2013
PurgeandFire: Changes made, approved.

 

[Daffa]

I suggest you use different string for gold and lumber.

 

[Chaosy]

I see a few flaws.

1. combine the triggers
2. you got the same string for lumber it will clash
3. I want to check the trigger not read a book, pput it in a info trigger
and how do you select how much you want to withdraw?

 

[deathismyfriend]

1) what do u mean combine triggers ?
2) what do u mean the same string ? oops i forgot to change them lol
3) its preset to -withdraw . so u type in -wthdraw200 or - withdraw 200. that will withdraw 200 from bank.

edit: updated with fixes except number 1.

 

[Chaosy]

1. you got 2 init triggers

 

[deathismyfriend]

1. you got 2 init triggers

thats because these are 2 independent systems. if someone wants one they dont need the other.

 

[Daffa]

Is this MUI?

 

[deathismyfriend]

its MPI. its a banking system.

I could make an MUI banking system but I never saw a point in one

 

[Magtheridon96]

Could you use demo code or a demo trigger as the screenshot if an in-game screenshot can't be pulled off?

 

[deathismyfriend]

ill c what i can do for the screenshot.

 

[deathismyfriend]

updated: fixed a small bug in the file were the wrong amount was added to the bank.

will upload pic after work.

 

[deathismyfriend]

fixed a bug.

This can now be used by everyone.

 

[PurgeandFire]

Overall it is a neat idea.

Review:

• In the init:
  

      function InitTrig_GoldBankingSystemCode takes nothing returns nothing
          local timer tmr = CreateTimer()
          call TimerStart( tmr, 0.00, false, function GoldBankingSystemSetup)
          set tmr = null
      endfunction

  You can simplify it to:
  call TimerStart(CreateTimer(), 0.00, false, function GoldBankingSystemSetup)
• In "GoldBankingSystemSetup", you can just use:
  call DestroyTimer(GetExpiredTimer())
  Instead of assigning it to a local, destroying it, then nulling the local.
• Only register chat events for players who are playing.
• Why did you save: PLAYER_STATE_RESOURCE_GOLD?
  Okay, I see that you might've wanted to use it for a shorter name. Instead you may just want to assign an integer to GetPlayerState(p1, PLAYER_STATE_RESOURCE_GOLD) and use that.
• For this line:
  set udg_goldBankGold[ p] = R2I( I2R( udg_goldBankGold[ p]) * r)
  You should be able to just have:
  set udg_goldBankGold[ p] = R2I( udg_goldBankGold[ p] * r)
  When you multiply an integer by a real, it will return a real, so you don't need to typecast it.
• Same things for the lumber system.
• Bug: In the test map, I type -dlumber and it deposits my gold. It also will withdraw my gold when I type -wlumber. It should be withdrawing/depositing my lumber, but it doesn't.
• Suggestions: You might want to add a check to see if the script starts with the command before applying the effect. Why? A lot of people ask each other what the commands are. If someone types:
  "hey nub, type -wgold ### to withdraw your gold from your bank"
  It'll show the person's gold because it detects the -wgold part of the string. I'm not saying it will bug out--your system handles it nicely and will only display the gold they have in their bank--it won't actually do anything if they type an invalid message (which is good). This is just an optional suggestion.

Other than that, nice job with the system. Fix those and it will be approvable!

 

[deathismyfriend]

Overall it is a neat idea.

Review:
In the init:

    function InitTrig_GoldBankingSystemCode takes nothing returns nothing
        local timer tmr = CreateTimer()
        call TimerStart( tmr, 0.00, false, function GoldBankingSystemSetup)
        set tmr = null
    endfunction

You can simplify it to:
call TimerStart(CreateTimer(), 0.00, false, function GoldBankingSystemSetup)
In "GoldBankingSystemSetup", you can just use:
call DestroyTimer(GetExpiredTimer())
Instead of assigning it to a local, destroying it, then nulling the local.

I will do that. For some reason i didn't think about doing that lol.

Only register chat events for players who are playing.

will do

Why did you save: PLAYER_STATE_RESOURCE_GOLD?
Okay, I see that you might've wanted to use it for a shorter name. Instead you may just want to assign an integer to GetPlayerState(p1, PLAYER_STATE_RESOURCE_GOLD) and use that.

I did that to make it shorter yes. It makes it easier to read. Also if i set an integer to getplayerstate then when i use set player state i can't use the shorter variable. I'd rather leave that that way. Also i do store get player state to an integer already.

For this line:
set udg_goldBankGold[ p] = R2I( I2R( udg_goldBankGold[ p]) * r)
You should be able to just have:
set udg_goldBankGold[ p] = R2I( udg_goldBankGold[ p] * r)
When you multiply an integer by a real, it will return a real, so you don't need to typecast it.
Same things for the lumber system.

changed that. Thanks

Bug: In the test map, I type -dlumber and it deposits my gold. It also will withdraw my gold when I type -wlumber. It should be withdrawing/depositing my lumber, but it doesn't.

That was my mistake. Fixed that

Suggestions: You might want to add a check to see if the script starts with the command before applying the effect. Why? A lot of people ask each other what the commands are. If someone types:
"hey nub, type -wgold ### to withdraw your gold from your bank"
It'll show the person's gold because it detects the -wgold part of the string. I'm not saying it will bug out--your system handles it nicely and will only display the gold they have in their bank--it won't actually do anything if they type an invalid message (which is good). This is just an optional suggestion.

There is a string that allows players to check the gold / lumber in their bank if they want. Is that what you mean ?

Other than that, nice job with the system. Fix those and it will be approvable!

Thanks changes have been made hope to see this approved soon.

 

[PurgeandFire]

I just meant that if someone types "-wgold" anywhere in their chat message, it will show their deposit. It isn't that bad since your system checks if they put in a valid number, but someone can say something like this:
"test test test -wgold test test test"
And it will show the gold number. This isn't a big issue though.

 

[deathismyfriend]

ooo i see what you mean. Thanks for the approval purge.

 

[CfWolfy]

idk about triggers much but....this is cool instanted to write Greedisgood 999999......5/5

 

[deathismyfriend]

idk about triggers much but....this is cool instanted to write Greedisgood 999999......5/5

thanks for the rating. Glad it helped you.