[Trigger] Getting rid of if/then/elses

[CHA_Owner]

okay in my system; http://www.hiveworkshop.com/forums/spells-569/model-effects-viewer-v1-9-a-225837/

i have way too many if/then/elses and i need to replace them with a loop so i can condense my code and increase performance but im not sure how to do that can someone please post an example of making a loop through lets say the weather indexs in my system?

 

[Anvil]

From a part of your trigger, you can do something like this.

• Set Sky[1] = Environment\\Sky\\BlizzardSky\\BlizzardSky.mdl
• Set Sky[2] = Environment\\Sky\\DalaranSky\\DalaranSky.mdl
• Set Sky[3] = Environment\\Sky\\FelwoodSky\\FelwoodSky.mdl
• Set Sky[4] = Environment\\Sky\\FoggedSky\\FoggedSky.mdl
• Set Sky[5] = Environment\\Sky\\Sky\\SkyLight.mdl
• For each (Integer SkyVar) from 1 to MaxSkyNumber, do (Actions)
  • Bucle: Acciones
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SkyIndex Igual a SkyVar
      • Then - Actions
        • Custom script: call SetSkyModel( udg_Sky[udg_SkyVar] )
      • Else - Actions

You can do the same for the filters and weather effects.

 

[WaterKnight]

Why not just

• Custom script: call SetSkyModel( udg_Sky[udg_SkyVar] )

 

[Anvil]

Yeah you're right, I was tired in the night. :/ You don't need the loop or the if/then/else.

• -
  • // Set your variables in start.
  • Set Sky[1] = Environment\\Sky\\BlizzardSky\\BlizzardSky.mdl
  • Set Sky[2] = Environment\\Sky\\DalaranSky\\DalaranSky.mdl
  • Set Sky[3] = Environment\\Sky\\FelwoodSky\\FelwoodSky.mdl
  • Set Sky[4] = Environment\\Sky\\FoggedSky\\FoggedSky.mdl
  • Set Sky[5] = Environment\\Sky\\Sky\\SkyLight.mdl
  • -
  • // When you need to change the sky do this:
  • Custom script: call SetSkyModel( udg_Sky[udg_SkyIndex] )

Thanks WaterKnight.-

 

[CHA_Owner]

Yeah you're right, I was tired in the night. :/ You don't need the loop or the if/then/else.

• -
  • // Set your variables in start.
  • Set Sky[1] = Environment\\Sky\\BlizzardSky\\BlizzardSky.mdl
  • Set Sky[2] = Environment\\Sky\\DalaranSky\\DalaranSky.mdl
  • Set Sky[3] = Environment\\Sky\\FelwoodSky\\FelwoodSky.mdl
  • Set Sky[4] = Environment\\Sky\\FoggedSky\\FoggedSky.mdl
  • Set Sky[5] = Environment\\Sky\\Sky\\SkyLight.mdl
  • -
  • // When you need to change the sky do this:
  • Custom script: call SetSkyModel( udg_Sky[udg_SkyIndex] )

Thanks WaterKnight.-

okay and with creating the variables to do that would they all be the same type for fade filters/skys/and weather and what type of variable would you create to enter a custom path? thanks guys

 

[Dr Super Good]

GUI abstracts variable types in silly ways. For some objects you might need to use JASS/vJASS to create proper generic variables or to reference a generic GUI variable in a generic way (as some types such as "unit type" are actually more simple integers).

A custom path, such as for models, would be a string.

 

[CHA_Owner]

GUI abstracts variable types in silly ways. For some objects you might need to use JASS/vJASS to create proper generic variables or to reference a generic GUI variable in a generic way (as some types such as "unit type" are actually more simple integers).

A custom path, such as for models, would be a string.

Thanks i got it now but the only one im still having problems with is the weathers so far i get a fatal error everytime when making a string for the weathers to refer to in the string would you have to place it like "RAhr" or 'RAhr' or even just RAhr? no matter which way i try it doesnt work.....

 

[Anvil]

Weather effects are integers. Set the Id with the quotes like this:

• Set Weather = 'RAhr'

 

[CHA_Owner]

Weather effects are integers. Set the Id with the quotes like this:

• Set Weather = 'RAhr'

okay so just set the weather variable to integer type and be sure to put the quotes around it.

im trying it now thanks again for all the help guys!