GetAbilityMaxLevels

[Ofel]

I used this on my spell to set variables related with ability levels, so I want to share with you cuz I'm still unsure too about things like: is it okay to use this (create a unit) on map initialization? What's the best unit type to use? And is this effective?

function GetAbilityMaxLevels takes integer abilCode returns integer
    local integer result
    local unit dummy = CreateUnit(Player(PLAYER_NEUTRAL_PASSIVE), 'Naka', 0, 0, 0)
   
    call UnitAddAbility(dummy, abilCode)
    call SetUnitAbilityLevel(dummy, abilCode, 100)
    set result = GetUnitAbilityLevel(dummy, abilCode)
   
    call RemoveUnit(dummy)
    set dummy = null
   
    return result
endfunction

 

[IcemanBo]

A global dummy unit can exist in your map that is never removed, but rest seems fine. "best unit type" just depends on object editor settings, the unti doesn't need model/shadow/collision/food/ and so on.

 

[Ofel]

A global dummy unit can exist in your map that is never removed

Actually I want this to be submitted to JASS section so, I guess it can only be properly achieved by making library?
I don't think it's reasonable to make this single function a library, need to add more useful functions.

 

[IcemanBo]

I don't think it's reasonable to make this single function a library, need to add more useful functions.

Mostly a system should not have as much functionality as possible, but rather the opposite is better. The thinking to have extra more functionality for the sense of submitting should happen carefully. ;P

In my opinion it's a bit too simple for a submission, not only from JASS-side, but the concept in general. One can also replicate this functionality pretty easy using GUI. Lab seems fine imo, or also maybe here Small Code Snippets.

 

[Ofel]

or also maybe here Small Code Snippets

Completely forgot this section.
I found lots of function I really need, thanks. I never fully explore the Hive yet since the day I got here. :v

 

[Wareditor]

It would be better to save the max level into a table on the first call for a given id so if the function is called a second time for the same id you could just return the entry in the table.