[General] Game Lags Every Second

[Neruvatar]

When I test map (Ctrl+F9), and play the game, I found out the game lags around every second and resume speed. What could be causing it?

I've checked there's no leak, except one "Pan Camera as..." which I've yet to resolve, but I didn't use that trigger either when I was playing. I couldn't detect any problem.

Can somebody help?

 

[Chaosy]

Disable all triggers and see if it lags.

 

[Jampion]

Lag does not necessarily mean leaks. Especially if the lag already happens when you just started the map. leaks are not causing it. You probably have triggers that either run very often (periodic triggers for example) or have long loops (unit groups, normal loops).

 

[Chaosy]

Possibly infinite loops, but instead of thinking of 100 scenarios it is easier to just disable everything to check

 

[Neruvatar]

Hmm, I have a few triggers that runs as "Every xxxx seconds of game time". So these are the ones causing lags as well? What should I do if I really want to check a few triggers for every few seconds?

 

[Jampion]

It's no problem to have these kind of triggers. It's normal to have those, but these triggers must be highly efficient. At first you need to find the trigger that is causing the lag, by disabling one trigger and test the game. After that you disable the next trigger and test etc. Once the lag is gone, the last trigger you disabled is the one you are looking for. Post it here and I can tell you what is causing the lag.

 

[Neruvatar]

OK... there's a huge list of trigger.... need time. Hold on.

 

[Jampion]

You only need to check the triggers that run often though (periodic, "is attacked", "is ordered", ...).

 

[Dr Super Good]

Is AI running for any computer players? If so they will cause a periodic frame drop if they cannot find a path to a valid target.

 

[Neruvatar]

I didn't set any AI. Unless making them patrol around counts?

 

[Dehua_Darbuya]

Could you post one of the triggers you think may be responsible for the lag in your map?

There might be a possibility that it is caused by certain GUI actions that inherently lag. For example:

• Example
  • Events
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units within 512.00 of (Center of (Playable map area)) matching (((Matching unit) is A structure) Equal to True)) and do (Actions)
      • Loop - Actions

 

[Neruvatar]

Xparka Firebreathers

• Events
  • Time - Every (Random real number between 7.00 and 13.00) seconds of game time
• Conditions
• Actions
  • Unit Group - Pick every unit in (Units owned by Player 12 (Brown) of type Xp'arka air) and do (Unit - Order (Picked unit) to Neutral Pandaren Brewmaster - Breath Of Fire ((Position of (Picked unit)) offset by 256.00 towards (Facing of (Picked unit)) degrees))
  • Set unitgroup[3] = (Units of type Xp'arka air)
  • Custom script: call DestroyGroup(udg_unitgroup[3])

This?

 

[Jampion]

It leaks and the last two actions don't make any sense (destroying a group before you do anything with it?), but it should not causing too much lag, as the leaks can only be noticed after playing for a while. This trigger could lag whenever it fires do to the unit group, but that would only be every 7 to 13 seconds.
Still remove the leaks and the unnecessary actions and try again.

 

[Neruvatar]

So, ahem, how should I put it? LOL. Sorry not really good at triggering. I remove the last two lines, then?

 

[Jampion]

The last two lines do nothing at the moment. I am not sure what you want to achieve, so I don't know what to do either.
First of all instead of "unit-group do action" always use "uni-group do actions", so you can put multiple actions in the unit group. You should never use the group function, that only allows one action, as the other is much easier to edit and gives you more options.
Never use "units of type". Use "units matching (unit type of matching unit is equal to ...)" instead.
Tell me what you want and I can tell how you need to make your trigger.

 

[Neruvatar]

Basically I want my unit to cast Breath of Fire every 7 to 13 seconds, my unit has Wander ability, so in the end, my result would be, that unit will cast Breath of Fire ahead of it periodically whenever it goes.

 

[Jampion]

If you use "every 7 to 13 seconds" all units in the unit will cast at the same time. They are multiple units or is it just one?

 

[Neruvatar]

Multiple, hehe. If I can have different units of the same type casting differently between 7 to 13 seconds, that would be awesome.

 

[Jampion]

• BreathOfFire
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup[0] = (Units in (Playable map area) matching (((Owner of (Matching unit)) Equal to Player 12 (Brown)) and ((Unit-type of (Matching unit)) Equal to Footman)))
    • Unit Group - Pick every unit in TempGroup[0] and do (Actions)
      • Loop - Actions
        • Set TempPoint[0] = (Position of (Picked unit))
        • Set TempPoint[1] = (TempPoint[0] offset by 256.00 towards (Facing of (Picked unit)) degrees)
        • Unit - Order (Picked unit) to Neutral Pandaren Brewmaster - Breath Of Fire TempPoint[1]
        • Custom script: call RemoveLocation(udg_TempPoint[0])
        • Custom script: call RemoveLocation(udg_TempPoint[1])
    • Custom script: call DestroyGroup(udg_TempGroup[0])

This would be a simple trigger to order them to cast breath of fire every second. You have several options to make them only cast every 7 to 13 seconds:

• Make them unable to cast in the meantime (remove ability, remove mana, cooldown)
• Store the time for every unit (more complicated)

 

[Dr Super Good]

Time - Every (Random real number between 7.00 and 13.00) seconds of game time

Just so you are aware, the random number is only generated once at map initialization when attaching the event. The period remains the same for the entire session instead of having some variation.

 

[Neruvatar]

• BreathOfFire
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup[0] = (Units in (Playable map area) matching (((Owner of (Matching unit)) Equal to Player 12 (Brown)) and ((Unit-type of (Matching unit)) Equal to Footman)))
    • Unit Group - Pick every unit in TempGroup[0] and do (Actions)
      • Loop - Actions
        • Set TempPoint[0] = (Position of (Picked unit))
        • Set TempPoint[1] = (TempPoint[0] offset by 256.00 towards (Facing of (Picked unit)) degrees)
        • Unit - Order (Picked unit) to Neutral Pandaren Brewmaster - Breath Of Fire TempPoint[1]
        • Custom script: call RemoveLocation(udg_TempPoint[0])
        • Custom script: call RemoveLocation(udg_TempPoint[1])
    • Custom script: call DestroyGroup(udg_TempGroup[0])

This would be a simple trigger to order them to cast breath of fire every second. You have several options to make them only cast every 7 to 13 seconds:

• Make them unable to cast in the meantime (remove ability, remove mana, cooldown)
• Store the time for every unit (more complicated)

Thank you, I'll try that out soon... =D

Just so you are aware, the random number is only generated once at map initialization when attaching the event. The period remains the same for the entire session instead of having some variation.

Yeah, I've just realised that as well... Thanks for pointing it out!

 

[Neruvatar]

One more issue and I'm unsure whether this will cause lag:

"Every 1 second of game time, play UNITX's decay flesh animation."

I am trying to create a permanent corpse that can be 'killed' and drop items...

 

[Jampion]

Don't think it leaks. But you can also play the animation when the "corpse" is created and set animation speed to 0% (you might have to delay it, if you want to show a more decayed version).