FullScreenItemShop 3.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

InitShopRegions should just be a Map Initialization event. This event has less overhead and is safer than a timer event.

AntiOut trigger doesn't register events for players 11 and 12, what happened?

"Game - Display to (Player group((Triggering player))) the text: Maximal value is 32!"

- This leaks a player group.

"(Integer((Entered chat string))) Greater than or equal to 33"

So the chat string is a number? That's pretty unstable. So the event will fire for simple chatter. It should be command-line based such as "-antiout #"

SetShopCamera only works for player 1 ...

Maker, v3.0, 14.07.2011
Player group leak:

• Game - Display to (Player group((Owner of FSS_PausedUnit[(Player number of (Owner of (Buying unit)))]))) for...

Leak:

• Camera - Pan camera for (Triggering player) to (Position of FSS_Hero[(Player number of (Triggering player))]) over 0.00 seconds

Leak:

• Cinematic - Clear the screen of text messages for (Player group((Triggering player)))

Get rid of all player group leaks.

 

[Marsal]

khm... Author: OxygenD?

 

[OxygenD]

Yes, OxygenD is me. Is my account in Garena. Do you doubt that it was me?

 

[Magtheridon96]

i recommend that you change your name. That's what i did. Just go to Admin Contact in the Forums and start a thread.

Anyways, this system looks useful.
I'll check the triggering right now...

Nothing's wrong with ur triggers. Your system is amazing. It may have like 70 triggers, but it's worth it.

Since it proves to be very useful and it's bug-free, i'll give it a good 5/5

 

[OxygenD]

is my first sistem))

 

[baassee]

This looks weird so it has to be checked out.

 

[OxygenD]

See in the screenshot at the corner of the menu is written in Russian. Written in Russian because I am from Russia. This proves once again that I am the author of this system. I have already submitted an application to change the nickname.

 

[baassee]

So I've checked this one out and it's not good at all. Discovered a few points.

• It leaks. Example:
  • Item - Create InitSoldItem1[1] at (Center of ItemSlot1 <gen>)
• Way too many triggers. Use substrings to reduce all these click and info triggers to 1.
• Not even MPI as it only works for one player; and you used one specific. Player Red.

Yeah that was pretty much it.

 

[OxygenD]

It is made of only 1 player in the event, but if you put in a lot of players that everything would work. I tried to do this in a trigger, using strings. But I failed. I'll try to fix it. Thank you checked out my system.

 

[xorkatoss]

very nice idea man!! 4/5
but the triggers in the "GetItem" folder could all be merged into one lol
here i made a quick example for you...

Item & Info

• Item n Info
  • Events
    • Player - Player 1 (Red) types a chat message containing <Empty String> as An exact match
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Substring((Entered chat string), 1, 7)) Equal to -info 1
      • Then - Actions
        • Game - Display to (Player group((Triggering player))) the text: (|cFFFFFF00Item information + ((Name of InitShopItem[1]) + ( Cost + ( |cFF00FF00 + (String(ItemShopCost[1]))))))
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Substring((Entered chat string), 1, 7)) Equal to -item 1
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Player 1 (Red) Current gold) Greater than or equal to ItemShopCost[1]
              • Then - Actions
                • Cinematic - Clear the screen of text messages for (All players)
                • Player - Add (ItemShopCost[1] - (ItemShopCost[1] x 2)) to (Triggering player) Current gold
                • Game - Display to (Player group((Triggering player))) the text: (|cFFFFFF00Вы преобрели предмет + (Name of InitShopItem[1]))
                • Hero - Create InitSoldItem1[1] and give it to A_UNIT_HERO[(Player number of (Triggering player))]
              • Else - Actions
                • Cinematic - Clear the screen of text messages for (All players)
                • Game - Display to (Player group((Triggering player))) the text: |cFFFF0000You do no...
          • Else - Actions

although if you merge them all into 1 it will be a super long trigger lol

also as baassee said you leak a point when you create an item...
here is how a leak-less item at a point trigger should have been...

Leak Removed

• Click1
  • Events
    • Player - Player 1 (Red) types a chat message containing -item 1 as An exact match
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 1 (Red) Current gold) Greater than or equal to ItemShopCost[1]
      • Then - Actions
        • Cinematic - Clear the screen of text messages for (All players)
        • Player - Add (ItemShopCost[1] - (ItemShopCost[1] x 2)) to (Triggering player) Current gold
        • Game - Display to (Player group((Triggering player))) the text: (|cFFFFFF00Вы преобрели предмет + (Name of InitShopItem[1]))
        • Set Point = (Position of A_UNIT_HERO[(Player number of (Triggering player))])
        • Item - Create InitSoldItem1[1] at Point
        • Hero - Give (Last created item) to A_UNIT_HERO[(Player number of (Triggering player))]
        • Custom script: call RemoveLocation(udg_Point)
      • Else - Actions
        • Cinematic - Clear the screen of text messages for (All players)
        • Game - Display to (Player group((Triggering player))) the text: |cFFFF0000You do not have enough money!

anyway you should try to merge them and remove the leaks when you have some free time
after that it will be worth giving you a 5.5!!

 

[Noobsmoke]

Remove excessive triggers and leaks please --> 3/5

 

[OxygenD]

xorkatoss thank you!!!! I will definitely do this in my spare time.

 

[OxygenD]

I edit my sistem. Now you must enter only slot of item 1-32. And it working in 1 trigger! But an item info also composes 32 trigger. Working on it. Who have any suggestions?

 

[baassee]

Make it the same as you did with the first trigger.

 

[OxygenD]

It does not, as in the first trigger, I have only used the numbers entered as an array variable. A Ie you type in the numbers and they also come as an array without extra letters. But I can not make those balk array of numbers or letters as well for viewing information.

 

[baassee]

We'll see when you update this.

 

[OxygenD]

Oh, sorry error. In the screen written below into the condition only for the red player. But in the file is already fixed.

 

[OxygenD]

I update version. I think its good...

 

[Adiktuz]

pretty tedious for the end-user to use since they need to type and type and type in order to buy/get info/etc...

 

[InfernalTater]

Oxygend, have you ever heard of arrays or hashtables?

 

[Adiktuz]

Game - Display to (Player group((Triggering player))) the text: Maximal value is 32!
-->isnt there a Game - Display Text to player?

 

[OxygenD]

Hey guys! This is my very old system. One of these days will update it.

 

[Pel-man]

Oh interesting sistem. Good Idea

 

[Kanadaj]

in short: doesn't work

longer version:
removes money even if you don't have, writes half the amount it takes, and it gives NO item

 

[Rufus]

That is nice!