Melting Phoenixes V. 3.0

[Moderator]

21:28, 29th Jun 2013
Magtheridon96: Approved.
People could generally find this spell useful.

 

[~DARK~]

Nice like yourself you are a good GUIer

 

[T. D. W.]

Nice like yourself you are a good GUIer

Thanks

 

[DivineLight]

cool.. but cursed the phone cam.. it's make things look bad..
i see you use clear child hashtable in there ;D

 

[T. D. W.]

Hhh, not that much

 

[GreeN!X]

Why are you using cameras to make your screenshots? There's that Print Screen button in your keyboard you know.

Anyway, Spell looks cool. Though you're using a lot of triggers for just a single spell and I'm too lazy to check out all of them so I won't rate it yet.

EDIT: you might want to put these lines into another map init. just sayin'

Visibility - Disable fog of war Visibility - Disable black mask

 

[T. D. W.]

Why are you using cameras to make your screenshots? There's that Print Screen button in your keyboard you know.

Anyway, Spell looks cool. Though you're using a lot of triggers for just a single spell and I'm too lazy to check out all of them so I won't rate it yet.

I don't think i told you that before, but my screen capture thingie is broken It does not work
Ok catch up late

@ Visibility
Not much important, a whole trigger just for 2 lines

 

[DivineLight]

tommorow i give you the screenshot.. tonight i'm sleepy ;D

 

[deathismyfriend]

u really need to apply more time to efficiency. this is probably the 10th time i have told u. anything u use twice or more store into a variable and use the variable. ex: picked unit and key picked unit. store them.

 

[DivineLight]

everytime we upload a spell here we need to considering it's efficiency
but mine not accepted yet

 

[Magtheridon96]

Because we're more like people rather than robots ;__;

 

[T. D. W.]

I'm 50% complete with the changes
EDIT: Updated

 

[Magtheridon96]

• Set Key = (Key (Picked unit))
• Hashtable - Save y2 as 1 of (Key (Picked unit)) in MP_HA

Hmmmm.

edit
Also, you can move Unit - Order HarvestDummy to Stop outside of the Then/Else blocks and put it once under the If block since you're calling it in both blocks in either case.

 

[T. D. W.]

UPDATED AGAIN, do not see triggers on hive, see in map, will correct that tomorrow with better screenshots
EDIT:

I think it would be cleaner to have the Damage Trigger just iterate over the units in the group. The trigger running it would have to clean the group on its own. In programming, it's best to make it so that every object cleans up after itself!

I think i fixed that

In the Knockback, it would be faster to use SetUnitX/SetUnitY in custom scripts instead of moving the unit with the GUI action:

I won't do that, for one reason: if i use your technique, the knockback will ignore the pathing which is unwanted

You might want to make the order (War Stomp) configurable too in the map initialization trigger.

what do you mean with that???

Tip

will try and see if will change it

 

[Magtheridon96]

Yeah, a better screenshot would be a valid change to this spell resource.

I'd also recommend combining all the extra triggers into the loop trigger to make the spell run faster because executing and evaluating triggers a lot is computationally expensive :/

 

[DivineLight]

i've send your sceeny
change your screenshot, bro!

 

[T. D. W.]

Updated

 

[Magtheridon96]

UPDATED AGAIN, do not see triggers on hive, see in map, will correct that tomorrow with better screenshots
EDIT:

I think i fixed that

I won't do that, for one reason: if i use your technique, the knockback will ignore the pathing which is unwanted

what do you mean with that???

will try and see if will change it

Okay, so, to wrap it up, all I want from you right now:

- Update the actual in-game screenshot of this spell that shows up in the spells section
- Change the scaling to use (y3, 0, 0) instead of (y3, y3, y3)
- Combine the Hash Save and Damage triggers into the loop. Running a trigger is quite expensive as an operation.
- Make an Order/string/integer or whatever variable and set it to (Tauren Chieftain - War Stomp) on map init in the configuration trigger so people can change it without having to go through your code.

 

[T. D. W.]

@screenshots (DONE)
@scale (DONE)
@combination, you want the spell to be 100% efficient, you will have to make 2 other trigfer for the damage and hash save (you can not pick unit groups in the same time) i merged the loop trigger and the knock ack loop trigger thaught
@order string, what is the usefullness of that, i set a variable ability to the warstomp ability, and another one for the main spell, so only if the other users want to change the warstomp, there is no specific need to make a whole story about the order string since it will stay the same
(All those changes are in the current version of the spell)

 

[Magtheridon96]

you want the spell to be 100% efficient, you will have to make 2 other trigfer for the damage and hash save (you can not pick unit groups in the same time)

The 2 other triggers just make it slower because what's happening under the hood is the same as what would happen if you merged the damage/hash save triggers into the loop trigger + this extra heavy code twice:

if TriggerEvaluate(trig) then
    call TriggerExecute(trig)
endif

TriggerEvaluate followed by TriggerExecute 66 times per minute is really a speed killer

edit

Oh, and one other point: In Warcraft III GUI/JASS, no two things happen at once. Everything is procedural, sequential and synchronous.

Warcraft III is single-threaded after all

 

[T. D. W.]

Just to say, if i pick a group, while i am already picking another group, if i use (Picked Unit) which unit will refer the picked unit, to the first group or second, ex;

• trigger
• Unit Group - pick every units in Ugroup 1 do actions
  • Unit Group - pick every units in Ugroup 2 do actions
    • Set Unit = Picked Unit

In this case, picked unit will refer to to which group, i think it will go to the first
Note: i am out of reach from my laptop now, so can't test it now

 

[Magtheridon96]

It will refer to the (Picked unit) in the deepest loop. (Ugroup2)

 

[T. D. W.]

ok, tried it, works perfectly
anthing else before updating?

 

[Magtheridon96]

Nah, go ahead ;D

edit
In case you ever feel like it, there's room for improvement in the Cast trigger: You could cache (Key(Last created unit))

 

[T. D. W.]

Finally my first spell lol
I will change that cache in the next version

 

[DivineLight]

not too bright right? i'm edit it with Photoshop

 

[T. D. W.]

Yeah, they're good

 

[DivineLight]

ok, enjoy!

 

[Daffa]

Good job with the spell, will evaluate the code later, too many codes here and there for the spell which makes me lazy

 

[T. D. W.]

Hahah, okk wil wait

UPDATE, minor changes in triggers, one new screenshot

 

[Daffa]

• Set x = (Level of (Ability being cast) for (Triggering unit))

Why don't use your own variable for the spell?

• Set loc1 = (loc offset by ((Load 2 of Key from MP_HA) x 0.03) towards (Load 0 of Key from MP_HA) degrees)

Unless I'm mistaken, isn't this already loaded in the first part and can use the variable instead?

This can't be accurate since I'm on mobile.
Seems a nice spell
4/5

 

[T. D. W.]

• Set x = (Level of (Ability being cast) for (Triggering unit))

Why don't use your own variable for the spell?

the spell has it's variable, but i didn't change that line

• Set loc1 = (loc offset by ((Load 2 of Key from MP_HA) x 0.03) towards (Load 0 of Key from MP_HA) degrees)

Unless I'm mistaken, isn't this already loaded in the first part and can use the variable instead?

You are mistaken, the part you are referring to is the knockback part, so it has nothing related to the first one, there is a comment that clears where the knockback system starts:

• -------- Knockback Loop --------

This can't be accurate since I'm on mobile.
Seems a nice spell
4/5

Thanks, you can see the new screenshot (V 1.5), it clarifies how the spell really looks like

 

[DivineLight]

and it is from me

 

[T. D. W.]

and it is from me

Hhahah, 2 from you, 1 from me, check them

 

[DivineLight]

yes, but mine is much clearer xD [ no offense ]
but yours is cooler (i'm not saying freezer)

 

[T. D. W.]

Sorry for the Double Update, but i gorgot the triggers on the first one
Anw
Updated

 

[T. D. W.]

Spell Updated, to V. 2.0 which is the Final Version (Yh, right... i lied xD)
This update has the feature to prevent users to get Bugs noticed like wrong unit-type for the creation in the loop trigger

Hope you like this spell ~~ DotCa

 

[I_am_Death]

yay, nice

 

[T. D. W.]

yay, nice

Thanks

 

[T. D. W.]

Update
V. 3.0

• Name Changed to Melting Phoenixes
• Now you can make more than one phoenix loop in the AoE
• Now Phoenixes are able to pass through the map border (no possible in last versions)
• Melting of phoenixes no longer stuns
• Knocback is more smooth
• Knockback now doesn't affect the unit's order
• Removed the Stun+damage ability (war stomp)
• Added a variable for damage instead of the ability based damage
• Trigger Optimization

 

[T. D. W.]

That's a very good idea, thanks, and that was fast lol!

EDIT: where did the post go!??

 

[Anderhil]

I'll definaely use this. Great job brother! 5/5

 

[T. D. W.]

Thanks man

 

[Henry_AC]

¡Maravilloso!:RE:RE:RE

 

[Henry_AC]

Muy Recomendado