[Trigger] Flying hieght

[Lord_of_sausage]

Hello all
Im making on a map named Aircraft (https://www.hiveworkshop.com/forums/showthread.php?t=43148)
But i need a trigger i cant do myself. This is what it should:
Every 0.01 sec it should pick all units owned by players and set their flying hieght to thier flyinghieght - the ground hieght. If theyre flying hight is lower than 1, the flying hieght would be set to 1. If the flying hieght is 1 the picked unit will die.
If you have troubles understand it maybe this could help:

• Event:
  • Every 0.01 seconds of gametime
• Actions:
  • Unit Group - Pick all units in units in playable map area and do actions:
  • If/then/else
    • If Condition:
      • Player - Owner of picked unit is a player equal to true
    • Then Actions:
      • Unit - Set Picked units flying hieght to Flying hieght of picked unit - ground hieght of ground at posision of picked unit

hmm something like that i think
Hope i could get some help ^^

 

[GhostWolf]

• Unknown
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Current flying height of (Picked unit)) Less than or equal to 1.00
          • Then - Actions
            • Unit - Kill (Picked unit)
          • Else - Actions
    • -------- I would never understand how to remove groups so no leaks :( --------

 

[PurplePoot]

Here's your trigger without leaks, GhostWolf:

• ]Unknown
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Current flying height of (Picked unit)) Less than or equal to 1.00
          • Then - Actions
            • Unit - Kill (Picked unit)
          • Else - Actions

 

[GhostWolf]

That custom script tells WE to remove the group after it finished to use it ? or when the trigger finishes ?

 

[Silvenon]

No, it destroys the group after the "Pick every unit in group" action. So before every "picking" you would have to put that custom script.

 

[Lord_of_sausage]

Thats great guys, but that doesent solve my problem # 2:
It should:
Every 0.01 (maybe in same trigger as you typed?)
set the flying hieght of the picked unit to:
(The flying hieght of the picked unit) - (the hieght of the ground beneath the picked unit. Not Cliff hieght but ground hieght)

 

[GhostWolf]

Couldn't find ground height anywhere, only cliff level
There has to be a way to do this (by the way whats Terrain Variance ?)

 

[PurplePoot]

Erm, what's the difference between Cliff Height and Ground Height?

Anyhow, I think this is what you want:

(uses real ZHeight, and point TempPoint)

• Set TempPoint = (Somewhere)
• Custom script: set udg_ZHeight = GetLocationZ(udg_TempPoint)
• Custom script: call RemoveLocation(udg_TempPoint)

 

[GhostWolf]

You can change the ground's height without cliffs

[offtopic] custom scripts pwn ^^

 

[Lord_of_sausage]

Erm, what's the difference between Cliff Height and Ground Height?

As GhostWolf said:

You can change the ground's height without cliffs

(why did i post that??)

[offtopic] custom scripts pwn ^^

Agree ^^

When i start the game, it says that your Custom script set udg_ZHeight = GetLocationZ(udg_TempPoint)
got errors, and the trigger will be disabled....
Should TempPoint be a Variable whit Point type?

 

[PurplePoot]

Yes, TempPoint is a Point variable, ZHeight is a Real variable.

 

[Lord_of_sausage]

ok, but should i made a Set Variable trigger for Zhieght in GUI or is it done in the customscript? Just make a FULL trigger, i just copy it down and give you credits ofcause ^^ (full trigger is: Set hieght, if hieght = 1 or lower then kill. Remmember Events and etc conditions plz )

 

[GhostWolf]

Thanks to the custom script you can do it like this

• Unknown
  • Events
    • Events
  • Conditions
  • Actions
    • Set TempLoc = (Position of (Triggering unit))
    • Custom script: set udg_ZHeight = GetLocationZ(udg_TempLoc)
    • Custom script: call RemoveLocation(udg_TempLoc)
    • Set Real = ((Current flying height of (Triggering unit)) - ZHeight)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Real Equal to 0.00
      • Then - Actions
        • Unit - Explode (Triggering unit)
      • Else - Actions

 

[Lord_of_sausage]

Stil bugs and how do you make the Set Real trigger?
I can make the first but how do i say Zhieght? where is it?

 

[Silvenon]

Shit, son, variable editor. There you can define global variables, haven't you ever heard of them?

 

[GhostWolf]

ZHeight and Real are both Real variables.
You don't put "set ZHeight" because thats what the custom script does.
And you can call it whatever you want, doesn't have to be Real and ZHeight.

 

[Lord_of_sausage]

Ok thank you, im going to test it as soon i can

 

[Lord_of_sausage]

Hmm it still dont work, trigger disables. This is the Bug Report:

function Trig_Test_Func001Func005C takes nothing returns boolean
if ( not ( udg_Real <= 1.00 ) ) then
return false
endif
return true
endfunction

function Trig_Test_Func001A takes nothing returns nothing
set udg_TempLoc = GetUnitLoc(GetEnumUnit())
set udg_ZHeight = GetLocationZ(udg_TempLoc)
call RemoveLocation(udg_TempLoc)
set udg_Real = ( GetUnitFlyHeight(GetEnumUnit()) - udg_Zhieght )
if ( Trig_Test_Func001Func005C() ) then
call KillUnit( GetEnumUnit() )
else
endif
endfunction

function Trig_Test_Actions takes nothing returns nothing
call ForGroupBJ( GetUnitsInRectAll(GetPlayableMapRect()), function Trig_Test_Func001A )
endfunction

//===========================================================================
function InitTrig_Test takes nothing returns nothing
set gg_trg_Test = CreateTrigger( )
call TriggerRegisterTimerEventPeriodic( gg_trg_Test, 0.01 )
call TriggerAddAction( gg_trg_Test, function Trig_Test_Actions )
endfunction

 

[Silvenon]

That's just your code written in JASS. What does it say in the bug report? (in that top white area, or console, or whatever you call it)

Examples:

- invalid number of arguments
- undefined variable
- sintax error
- constant function calling a non-constant function

Get it?

 

[Lord_of_sausage]

i i think... when the script pops up theres some text marked... i should post that?

 

[GhostWolf]

Yes.
abcdefghi (lol sorry... can't post undearneath 15 characters -.-)

 

[Lord_of_sausage]

set udg_ZHeight = GetLocationZ(udg_TempLoc)

 

[GhostWolf]

Are you sure your variables look exacly like this (ZHeight) (TempLoc) because its CaSe SenSitive.

 

[Silvenon]

What does it say about that line? (Look up from it, that white area))

 

[Lord_of_sausage]

hmm yes, but i can check ^^

 

[Lord_of_sausage]

Its says the trigger has errors -.- not more :S

 

[GhostWolf]

Post your trigger/map please.

 

[Lord_of_sausage]

ok, Ketila has tryed make a copy of the triggers and changed them abit, it worked partly: when flying over hills, your flyinghieght does not change, but when you reached the top of the mountain, it worked as it should, and then down the mountain, the trigger "disabled"

 

[Lord_of_sausage]

Ive fixed it, it works now, but ULTRA MEGA UNPLAYABLE IMBA lagg....

edit: reduced lagg enough to see what happens:
Your hieght gets reduced to more than -100 and you die instantly, anyone knows why? and how to fix?

 

[Lord_of_sausage]

this is the trigger for my hieght, anyone spots bugs?
even though my movement trigger is 0.01 and the increase hieght by arrowkeys is in, i still can increase hieght.. is it because i die or?
im sorry for the bad quallity, i hope you can read it :/

 

[Lord_of_sausage]

ok, ive found the bug and fixed it, now i enabled the hieght trigger and this is what happens:

Your hieght is changed to 0 everytime the trigger runs (0.07). But you dont die, even if the real is 0. Whats wrong whit the ZHieght or the trigger?



its the Hieght Trigger

Edit: Whit 1 in the real condition, you will die
Comeon... someone post!

 

[Lord_of_sausage]

ok, i found out why im always in 1 hieght, ZHieght is more than 40x as much as flying hieght, dividing whit 40 or more does not work... any ideas?

 

[Lord_of_sausage]

i found out - Illidan(evil)x helped me an moderator may close this thread.