Floating Text - Damage&Spells v2

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

13:08, 30th May 2011
Maker:
You're registering the event even for units that can't cast abilities.
Why do you register the event for all units, why not use Unit - A unit Starts the effect of an ability event
?

 

[Marsal]

post the triggers

 

[SpasMaster]

My thoughts on this System:

[+]From what I see, it's leakless.
[+]It's properley working, and it's not causing bugs.
[+]I like the hovering spell names!
[+]Easy to understand and import.
[+]The hovering damage has it color set to the one who is doing the damage.

[=]Healing could be added. Would be cool.

5/5 from me. Getting it in my map in no time. Credits will be given

 

[.VTZ.]

Best Dmg System i haved seen (pwn any vJass Sys)
5/5
My rewiew is the same
[+]From what I see, it's leakless.
[+]It's properley working, and it's not causing bugs.
[+]I like the hovering spell names!
[+]Easy to understand and import.
[+]The hovering damage has it color set to the one who is doing the damage.

[=]Healing could be added. Would be cool.

5/5 from me. Getting it in my map in no time. Credits will be given

 

[Magtheridon96]

gj
5/5 from me:
-Leakless
-Bugless
-Easy to Import
-Elegant
-Lagless


But there's one problem: If neutral hostile attacked you. Just fix that by adding an exta variable declaration

 

[Juliano]

Thanks for the comments, I'll be posting the triggers there in a minute.
EDIT: posted the triggers in the description

Mabster
If neutral hostile attacks you, the color is white, because black(original color) is almost unreadable depending on the tilesets.

 

[iAyanami]

It isn't leakless. Your method of setting up "Any unit takes damage" leaks trigger event. This can be solved via JASS, though I'm not sure if it can be done in GUI.

 

[88WaRCraFT3]

Well it's okey i'll give 5/5 because all did, but in my opinion it's so easy and simple.

 

[Magtheridon96]

Juliano,
That really helped me just now. thanks. +rep

 

[Catch_ya]

Best Dmg System i haved seen (pwn any vJass Sys)

Of course it pwns any vJass/Jass system for a GUI user because its harder for you to configure Jass. GUI will never be able to "own" Jass. Not that this isn't a good system, from what I can see the system looks good.

But it leaks when you register the "unit takes damage".

 

[Adiktuz]

this leaks when the units registered dies... not to say that there is another very easy to use GUI-usable DDS on hive which pawns this...

 

[Juliano]

iAyanami and Catch_ya
Cant it be fixed via custom scripts? Never heard of this 'event' leaking though...

Adiktuz
Can you give me the link of the other system? I'd like to learn from it, if its better.

 

[Adiktuz]

it was actually in vJASS but it requires no jass knowledge to be used as its meant for GUI users. And it supports different actions that would fire on the damage event... search for it, it was GUI friendly damage detection by Weep...

 

[iAyanami]

Here's how an event leak occurs (quoted from Weep).

1. You add an event to a trigger.
2. The event loses relevance (eg. if it's a unit event, and the unit gets removed from the game.)
3. You don't do anything else, and now there's a useless event attached to a trigger taking up memory.

To combat this, use dynamic triggers; supposedly, destroying a trigger destroys its events and conditions, but not its actions. (I'm just going by what I've read that others have reported, and how many systems are coded.)

 

[-Kobas-]

You miss conditions to hide floating text if for example dummy unit cast spell.

 

[Juliano]

Updated the spell, now the system uses Weep's Damage Detection to clean the leaks on the event when a unit takes damage, also added a condition to prevent dummy floating text creation, as suggested by kobas.

 

[Adiktuz]

I don't see the use of this system, its just a very simple implementation of Weep's system...

 

[Juliano]

I implemented Weep's system just to make it leakless.

I haven't found any other system like this one uploaded in hive and I have no doubt some people will find good use of it, since it can be used almost in any map.

Also, I don't think it needs to be complicated to be useful, since most of our community doesn't know much on triggering.

 

[andre5913]

I haven't noticed any leaking when unit dies , and i 'm getting any other errors , ii bote for aproval

 

[Vlad727]

Neat system.
I am going to use this system in my project for sure.
My opinion 5/5 reasons:
- first time a Jass code did not crash (with my editor)
- works properly
- good documentation (in my opinion)
- really useful for: rpg maps, melee maps, and almost anything else
+ rep and vote for approval.

 

[Mick23]

not work for me. i copied triger to my map dmg numbers doesent show

 

[Adiktuz]

well, are you sure the you configured it correctly... and have you imported the system by Weep too?

 

[Ayrayen]

It's a very usefull system.

Just 1 problem. When you cast shadow strike ( Miev's ability ) there is allready floating text to it. And i dont want 2 text's coming up, how to fix that?

 

[88WaRCraFT3]

Just add condition, boolean [unit has specific buff (Shadow Strike)] equal to false.

 

[Ayrayen]

Just add condition, boolean [unit has specific buff (Shadow Strike)] equal to false.

Yeh should be simple enough thx

 

[Maximum_Evil]

Awesome very usefull!

 

[xorkatoss]

awesome system man!! +rep 5/5
gonna use it in my map, are you going to add healing detection?

 

[Vlad727]

Could you configure it so we could also see healing,
Because that would be really sweet & Awesome for ORPG players/creators

 

[Fud]

It will create double text for Critical Strikes, wind walk, and shadow strike...
also like everyone else said please add healing (though you've probably run out of colors by now ><.)

You could make healing displays yellow white and bigger than others with "+" on each side... this would easily distinguish it from the damage...

 

[gorillabull]

This is very well made and saved me some time +++m-m-m-m-m-m-m-m-m-m-m-monster rep!!!!!!!!!!!!!!!

 

[TinyTeaser]

soo is healing going to be added lol, still a great system!

 

[KI60]

Simple but till this day it's still good.