Equipment System, Version 2.2a

[Moderator]

22:52, 11th Apr 2009
Eccho:

I would say this might will be useful for some. It works as intended and does not leak, and is perfectly MPI. However, some thing bugs me.

*As I mentioned, the green "invalid" icons which shows up, looks horrible. However, I allow you to import them into your map as "BTN" ones even though they are darkened. Make sure to document this as well if you do so.
*The second thing about the system is, that you have to click on the item everytime you want to drop it. It would be nice, if it was added to the backpack instantly, to be honest.
*The third thing is the triggering. You did a good job reducing the lag ingame to nothing, but still, the triggering could be better like I said in my post further down.

But overall, yeah it does lack at the moment, but it is functional in game. Approved.

 

[Kingz]

It's not MUI it's MPI, MUI means that an infinite number of units may use something at the same time.
EDIT:
Why is it missing an extenstion?
It also laggs when the equipment starts(click on an item).
You have undefined trigger conditions in several triggers.
Simple inventory system which really needs some kind of improvement.

 

[lolreported]

Ah, my mistake xD Thx

Edit:

What do you mean with "missing an extenstion"?
And I know that it laggs, but it only lag once per item type (except amulets and rings)
I know that there are undefined trigger conditions.
What kind of improvement?

thx for reviewing!

 

[Eccho]

In the Jass initialization, as an improvement (basically to do it faster and not create unneccessary triggers, slightly change the triggers:

function Trig_Ring_Initialization_Actions takes nothing returns nothing
    set udg_i[6] = ( udg_i[6] + 1 )
    set udg_Ring_IType[udg_i[6]] = 'I00D'
    set udg_Ring_Str_Bonus[udg_i[6]] = 10
    set udg_Ring_Agi_Bonus[udg_i[6]] = 3
    set udg_Ring_Int_Bonus[udg_i[6]] = 5
    set udg_Ring_Ability_1[udg_i[6]] = 'A002'
    set udg_Ring_Ability_2[udg_i[6]] = 'A002'
    set udg_Ring_Ability_3[udg_i[6]] = 'A002'
    set udg_Ring_Ability_4[udg_i[6]] = 'A002'
    // ----------------------------------------
    set udg_TotalRingItems = udg_i[6]
endfunction

//===========================================================================
function InitTrig_Ring_Initialization takes nothing returns nothing
    set gg_trg_Ring_Initialization = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Ring_Initialization, function Trig_Ring_Initialization_Actions )
endfunction

to

function InitTrig_Ring_Initialization takes nothing returns nothing
    set udg_i[6] = ( udg_i[6] + 1 )
    set udg_Ring_IType[udg_i[6]] = 'I00D'
    set udg_Ring_Str_Bonus[udg_i[6]] = 10
    set udg_Ring_Agi_Bonus[udg_i[6]] = 3
    set udg_Ring_Int_Bonus[udg_i[6]] = 5
    set udg_Ring_Ability_1[udg_i[6]] = 'A002'
    set udg_Ring_Ability_2[udg_i[6]] = 'A002'
    set udg_Ring_Ability_3[udg_i[6]] = 'A002'
    set udg_Ring_Ability_4[udg_i[6]] = 'A002'
    // ----------------------------------------
    set udg_TotalRingItems = udg_i[6]
endfunction

The lag is once per item that is correct, due to the abilities. Please preload all the abilities by creating a dummy unit upon map init, add all abilities to him, and then remove the unit from the game.

• -------- Place the unequiped item back in inventory --------
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Item_Normal1[(Player number of (Owner of (Triggering unit)))] Equal to (Item-type of No item)
  • Then - Actions
    • Set UnequipDebug = True
    • Set Item_Normal1[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item being manipulated))
  • Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • Item_Normal2[(Player number of (Owner of (Triggering unit)))] Equal to (Item-type of No item)
        • UnequipDebug Equal to False
  • Then - Actions
    • Set UnequipDebug = True
    • Set Item_Normal2[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item being manipulated))
  • Else - Actions
• //and so on.

It seems rather pointless to check if is "no item" several times. Just place everything under an if condition checking that and then add the other evaluations inside.

Overall, I would actually recommend this system for a Gui user. But please merge as much as possible, and make it as efficient GUI as possible.

Give me a reply/PM/VM when you've done so.

 

[Super-Sheep]

DL doesnt work.

 

[Kingz]

In the file name there isn't a .w3x extension, it downloads as something else so you need to rename the file and add a .w3x on it's end.

 

[Eccho]

It does. Just add .w3x and it should work fine.

Flood, fix that as well.

Edit: Kingz, nice timing

 

[Balrog]

Good

 

[PurpleHephalump]

Wow at the same time and it's both 911! Conspiracy?

 

[lolreported]

In the Jass initialization, as an improvement (basically to do it faster and not create unneccessary triggers, slightly change the triggers:

function Trig_Ring_Initialization_Actions takes nothing returns nothing
    set udg_i[6] = ( udg_i[6] + 1 )
    set udg_Ring_IType[udg_i[6]] = 'I00D'
    set udg_Ring_Str_Bonus[udg_i[6]] = 10
    set udg_Ring_Agi_Bonus[udg_i[6]] = 3
    set udg_Ring_Int_Bonus[udg_i[6]] = 5
    set udg_Ring_Ability_1[udg_i[6]] = 'A002'
    set udg_Ring_Ability_2[udg_i[6]] = 'A002'
    set udg_Ring_Ability_3[udg_i[6]] = 'A002'
    set udg_Ring_Ability_4[udg_i[6]] = 'A002'
    // ----------------------------------------
    set udg_TotalRingItems = udg_i[6]
endfunction

//===========================================================================
function InitTrig_Ring_Initialization takes nothing returns nothing
    set gg_trg_Ring_Initialization = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Ring_Initialization, function Trig_Ring_Initialization_Actions )
endfunction

to

function InitTrig_Ring_Initialization takes nothing returns nothing
    set udg_i[6] = ( udg_i[6] + 1 )
    set udg_Ring_IType[udg_i[6]] = 'I00D'
    set udg_Ring_Str_Bonus[udg_i[6]] = 10
    set udg_Ring_Agi_Bonus[udg_i[6]] = 3
    set udg_Ring_Int_Bonus[udg_i[6]] = 5
    set udg_Ring_Ability_1[udg_i[6]] = 'A002'
    set udg_Ring_Ability_2[udg_i[6]] = 'A002'
    set udg_Ring_Ability_3[udg_i[6]] = 'A002'
    set udg_Ring_Ability_4[udg_i[6]] = 'A002'
    // ----------------------------------------
    set udg_TotalRingItems = udg_i[6]
endfunction

The lag is once per item that is correct, due to the abilities. Please preload all the abilities by creating a dummy unit upon map init, add all abilities to him, and then remove the unit from the game.

• -------- Place the unequiped item back in inventory --------
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Item_Normal1[(Player number of (Owner of (Triggering unit)))] Equal to (Item-type of No item)
  • Then - Actions
    • Set UnequipDebug = True
    • Set Item_Normal1[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item being manipulated))
  • Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • Item_Normal2[(Player number of (Owner of (Triggering unit)))] Equal to (Item-type of No item)
        • UnequipDebug Equal to False
  • Then - Actions
    • Set UnequipDebug = True
    • Set Item_Normal2[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item being manipulated))
  • Else - Actions
• //and so on.

It seems rather pointless to check if is "no item" several times. Just place everything under an if condition checking that and then add the other evaluations inside.

Overall, I would actually recommend this system for a Gui user. But please merge as much as possible, and make it as efficient GUI as possible.

Give me a reply/PM/VM when you've done so.

thx for watching and helping me with the system, I've updated this system now, optimized the JASS stuffs and removed the ingame lag once equiped an item.

 

[Eccho]

You will need to fix the green icons as well when the game pauses/entering a menu:

Also, if you do not do something about your long GUI triggers, this system will only get a lacking rating. It could be useful if you fix the inefficiency. But you need to fix the green icons for approval first.

 

[lolreported]

You will need to fix the green icons as well when the game pauses/entering a menu:

Also, if you do not do something about your long GUI triggers, this system will only get a lacking rating. It could be useful if you fix the inefficiency. But you need to fix the green icons for approval first.

The green icons is just DISBTN icons that can't be showed as DISBTN once more. Someone that use the system may change the empty item icons to different icons that won't be green. I don't know if I can optimize my long GUI triggers, I'll try optimize them, but I may not be able too.

 

[Dark_Dragon]

check this out i was impressed!

Item and Camera System

and about that green icon why don't you then simple make that same icon be DISBTN and BTN same you dont have to change the icon just make it be not green in fact what i want to say leave icon as is when game paused just let it stay and not become green

 

[N.O]

Just wondering, are you sure you didn't take it from XGM? They got the same exact system on there before it was submitted here... anyways goodjob and plus I can't get no proof because links from xgm don't work in hive.

 

[Eccho]

I would not trust xgm since they stole alot of resources from thw.

 

[lolreported]

Just wondering, are you sure you didn't take it from XGM? They got the same exact system on there before it was submitted here... anyways goodjob and plus I can't get no proof because links from xgm don't work in hive.

I don't even know what XGM are. So, no, I haven't stole anything. I've created this system all of my own.

 

[kyleunderwood]

dude this is tight if you have any other ideas plz reply iv always wanted to try this ty for this so if im right when you pick up these items helment shiled waepon amulet and ring it will show it when picked up

 

[Hivoyer]

Simpler way:

You can just make the items head = permanent,weapon = artifact etc. and just check if the hero has an item of the class.Its a lot faster and simpler+itll be easier to make loads of items this way

 

[Killd0zer]

mistake

 

[Killd0zer]

Honestly, its not the greatest system ever. On the other hand, its perfect for my map (VJass doesn't work for some reason).

Question, can I mod the names a little to fit my map

Another Question: Will the system let me add more ability slots (ab1, ab2, ab3? I know how to change it just wondering if youll let me and if it's possible)

 

[lolreported]

You can just make the items head = permanent,weapon = artifact etc. and just check if the hero has an item of the class.Its a lot faster and simpler+itll be easier to make loads of items this way

Have you even watch the code? That's the way I've done it.

Honestly, its not the greatest system ever. On the other hand, its perfect for my map (VJass doesn't work for some reason).

Question, can I mod the names a little to fit my map

Another Question: Will the system let me add more ability slots (ab1, ab2, ab3? I know how to change it just wondering if youll let me and if it's possible)

Yes, I know it isn't the greatest system, but I think this is one of the best GUI equipment system, but that's my view.

I don't really understand your first question, what do you mean with "mod the names"?

Yes, the system will allow you to add more abilityslots, the amulets and the rings uses 4 at the moment and the other uses 2. I don't really know a maximum limit of how many abilities you can add, but yes, add as many abilityslots you want to and if you meet any problems by adding more abilityslots, tell me, but it shouldn't be any problem. Just check the code.

 

[lolreported]

Updated this system to version 2.0. I had a request, a person wanted this system to support twohanded weapons and now it does!

 

[ACdestinydream]

and u screwed it up. now u cant return to inventory when u go into equipment slots.

 

[lolreported]

and u screwed it up. now u cant return to inventory when u go into equipment slots.

Huh? What are you talking about? I can return to my inventory when I go into my equipment inventory, I can do it unlimited times without getting any problems... Tell me how your problem appeared.

 

[Wareditor]

Big bug with slots

Ok this is my equipment menu View attachment 72012
In Pause View attachment 72013
When i equip a helm and a armor View attachment 72014
I try to equip a armor View attachment 72010
But i can't find my armor View attachment 72011

What is this bug

Your system is but have this "littel" bug

Help me

 

[lolreported]

Ok this is my equipment menu View attachment 72012
In Pause View attachment 72013
When i equip a helm and a armor View attachment 72014
I try to equip a armor View attachment 72010
But i can't find my armor View attachment 72011

What is this bug

Your system is but have this "littel" bug

Help me

About the green icons... It's not a problem with my system, it's warcraft 3. Everyone should use a BTN icon or a PAS, etc, as normal icon. When the game is paused or something else, all icons will change them selfes to DIS icons.
BTN > DISBTN
PAS > DISPAS
get it?

The problem is now that you have DISBTN icons as BTN or PAS icons, whatever, and when you pause your game your DIS icons have nothing to change to. That's why they are green. It's kinda hard to explain.

About your other problem it's hard for me to know... Because you have different equiped items all the time. make sure you have unequiped your current armor to equip another one, future versions may support instant equip. And make sure you got the latest version. Anyway, I'll take a look and see if I find any problems. +rep


EDIT: I think I saw something now... I saw that you've changed the position of the equipment slots. I can see that you have an armor slot at the shield slot and the shield slot at the armor slot. This may confuse things for us and not the system. The system is ordered to check what kind of item-type that is equiped nor being unequiped. So I think that you'll have to change a few things. Make sure that you change the

> [Permanent] Items types MUST be Head equiped items.
> [Charged] Items types MUST be Shield equiped items.
> [Power Up] Items types MUST be Weapon equiped items.
> [Artifact] Items types MUST be Armor equiped items.
> [Purchasable] Items types MUST be Amulet equiped items.
> [Campaign] Items types MUST be Ring equiped items.

to suit your needs so the system knows what to do. In your case, change CHARGED items (Shield) to ARTIFACT items (Armor) and ARTIFACT (Armor) to CHARGED (Shield) and on all your other changes. This should do it, if you still having problems, please tell me =)

 

[Wareditor]

I just change this

• Open Eq Menu
  • Evénements
    • Unité - A unit Utilise un objet
  • Conditions
    • (Item-type of (Item being manipulated)) Egal Ã* Equipment Menu
  • Actions
    • Set InEqMenu[(Player number of (Owner of (Triggering unit)))] = TRUE
    • Set Item_Normal1[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 1))
    • Set Item_Normal2[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 2))
    • Set Item_Normal3[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 3))
    • Set Item_Normal4[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 4))
    • Set Item_Normal5[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 5))
    • Set Item_Normal6[(Player number of (Owner of (Triggering unit)))] = (Item-type of (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot 6))
    • For each (Integer B) from 1 to 6, do (Actions)
      • Boucle - Actions
        • Objet - Remove (Item carried by Hero[(Player number of (Owner of (Triggering unit)))] in slot (Integer B))
    • Héros - Create Item_Weapon[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Héros - Create Item_Shield[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Héros - Create Item_Head[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Héros - Create Item_Armor[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Héros - Create Item_Ring[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Héros - Create Item_Amulet[(Player number of (Owner of (Triggering unit)))] and give it to Hero[(Player number of (Owner of (Triggering unit)))]
    • Objet - Make (Last created item) Inlâchable
    • Set playergroup = (Player group((Owner of (Triggering unit))))
    • Partie - Display to playergroup for 5.00 seconds the text: |cffffcc00Exit the ...
    • Custom script: call DestroyForce(udg_playergroup)

 

[lolreported]

Updated this system to version: 2.1a
[Read the changelog about the updates.]


Updated this system to version 2.2a
[Read the changelog about the updates.]

Changelog

UPDATE (Version 1.0 > 1.1)

> I've fixed the JASS thing that Eccho told me.
> I've removed the once per item-type lag stuff, by creating some actions in the "EquipmentSystemInitialization" trigger.

UPDATE (Version 1.1 > 1.2)

> Optimized all GUI code.
> Removed unused code.
> Found some unused variables.
> Removed the greeny icons, by importing a new icon!
> ...and other small things.

UPDATE (Version 1.2 > 1.3)

> Fixed an issue with unequiping items.

UPDATE (Version 1.3 > 2.0)

> You are now able to use twohanded weapons with this system!

    set udg_Weapon_TwoHanded[udg_i[3]] = true

or

    set udg_Weapon_TwoHanded[udg_i[3]] = false

> Small stuffs fixed and edited.

UPDATE (Version 2.0 > 2.1a)

> The system now saves the current charges left to items in the inventory.
> Reworked Equipment triggers, made them a little shorter.

UPDATE (Version 2.1a > 2.2a)

> When initializing items you'll no longer be needed to use 'A002' as an ability that does nothing, just type: 0 or 'null'.
> The system now supports more abilities to add to each item-class. Head, Armor, Weapon and Shield items now supports 4 abilities instead of 2. Rings and Amulets now supports 6 instead or 4 abilities.

 

[Mallaboro]

holy shit. Cut down on the variables, friend. Besides that your lil' system runs lovely as far as I can tell (without stress testing). It'd be nice if the inventory button were an ability button and it'd be nice if items were organised into artefacts, powerups and so forth, but whatever floats your boat.

 

[lolreported]

holy shit. Cut down on the variables, friend. Besides that your lil' system runs lovely as far as I can tell (without stress testing). It'd be nice if the inventory button were an ability button and it'd be nice if items were organised into artefacts, powerups and so forth, but whatever floats your boat.

I know there's alot of variables But I don't know if I can shut them down abit... And you can easily change the inventory button into an ability thanks +rep

 

[mxx7x]

This system is too hard!

 

[lolreported]

This system is too hard!

Well, could you tell me why it's hard? Otherwise, you're not helpful and your post is pointless...

 

[Destiny_Runner]

hey, I am getting a little problem here!
when the game starts, my hero does not start with the equipment thing on his inventory, all the 6 slots are empty, and the last one, supposed to have the equipments, is not there!
what should I do?

 

[lolreported]

Add it manually or add the Equipment Menu Item with triggers

 

[crueltyinc]

I tried switching the open and close triggers so that they activate when the unit casts a spell but it doesn't seem to work. All I did was switch the Event and Conditions to the following:

• Open Eq Menu
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • InEqMenu[(Player number of (Owner of (Triggering unit)))] Equal to False
    • (Ability being cast) Equal to Equipment
  • Actions

• Close Eq Menu
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • InEqMenu[(Player number of (Owner of (Triggering unit)))] Equal to True
    • (Ability being cast) Equal to Equipment
  • Actions

where Equipment is the ability being cast (it's a clone of your Inventory Spell ability set to be a Unit ability).

The result of this is that, even though the item version still works when given the new ability, the unit version shows the default game message at the end (press esc to go back) but does not actually switch the inventories. Any ideas on how I can make this work?

 

[lolreported]

I tried switching the open and close triggers so that they activate when the unit casts a spell but it doesn't seem to work. All I did was switch the Event and Conditions to the following:

• Open Eq Menu
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • InEqMenu[(Player number of (Owner of (Triggering unit)))] Equal to False
    • (Ability being cast) Equal to Equipment
  • Actions

• Close Eq Menu
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • InEqMenu[(Player number of (Owner of (Triggering unit)))] Equal to True
    • (Ability being cast) Equal to Equipment
  • Actions

where Equipment is the ability being cast (it's a clone of your Inventory Spell ability set to be a Unit ability).

The result of this is that, even though the item version still works when given the new ability, the unit version shows the default game message at the end (press esc to go back) but does not actually switch the inventories. Any ideas on how I can make this work?

Sorry for the late answer, I hope you found a solution. I've been away with my friends over 2½ week. Well, to your question. Try changing the event to:

• Events
  • Unit - A unit Starts the effect of an ability

that should make it work, if I understand your problem.

 

[crueltyinc]

Sorry for the late answer, I hope you found a solution. I've been away with my friends over 2½ week. Well, to your question. Try changing the event to:

• Events
  • Unit - A unit Starts the effect of an ability

that should make it work, if I understand your problem.

yeah that did it. had a friend figure it out a little after i asked here
thanks though

 

[lolreported]

Haha okey ^^ Glad you fixed it!

 

[AgnonWolf]

My game keep on crashing while i in the original map presses the "Equipment Menu" button. Any ideas?

 

[lolreported]

Well, please post your "Open Equipment" trigger in here between [""TRIGGER] [""/TRIGGER] tags, without the quotes, so I may see the error.

 

[j210_like]

dude WOW this is SO CLOSE to what im looking for...im creating an rpg hopefully good enough to blow wc3 away, message me if you can help customize this a little better for me to fit the game, im more of a GUI System/spell guy, so this 50% makes since and 50% leaves me brain dead when i glance at triggers. I just need a few things changed so hopefully it wouldn't be much...

 

[lolreported]

And what do you want me to change?

 

[Wareditor]

Can you say how to make a save/load system to it ?

 

[lolreported]

I've got no idea. It depends on what save and load system you're using and how they allow you to save/store specific values.

 

[Iamspartacus]

Major Problems.

OKAY, I absolutely am relying on this trigger as the inventory system on my PRIVATE map. It will not work, I have assigned the trigger to a hero for player 1, and ALL of the items and abilities needed by the trigger have the EXACT same item ids, but the trigger still will not work. What the crud. Help please? I think I'm attaching the right file (exported triggers) I have narrowed it down, I'm 70% sure it's a problem with how I modified the triggers...

Oh, the exact problem is that the equipment inventory item (that opens the equipped inventory slots) never appears.



Thanks, if anyone can help...

 

[lolreported]

I'm sorry. I can't help you. I've left warcraft 3 and do not trigger anything anymore. The system is really outdated, I've got an updated version of the system somewhere, but I was to lazy to update it here. So, you should try use another equipment system if this doesn't work. I may help you if you post the trigger you think cause the problem here within ['TRIGGER] tags and I may take a look. Good luck!

 

[MooNek]

It is just awsome!
I love it

 

[owenfitz]

anyone have any ideas on how to get it to work with a game cache. When i use the game cache it only saves the inventory and not the equipment menu and i tried giving all the equipment o another unit, going to new map and giving it back but no luck.

 

[Tal'Rarity]

My map fatals when I try to put this in it.
Any idea's?