Enhanced Critical Strike v.61

[Moderator]

old review

20:51, 8th Jun 2009
hvo-busterkomo: A decent JASS spell, although quite basic. Here's my improvements:

1. Remove the unnecessary BJs. The texttag ones are fine and can be ignored, but you should remove things like UnitAddAbilityBJ.

2. Your if statement is needlessly complicated. Just do something like

if GetWidgetLife(t) <= 0 then

3. Use a local trigger.

4. The spell ID should be configurable as a constant/constant function.

old review(2)

14:07, 8th Jun 2010
The_Reborn_Devil:
You're still using some BJ's, but it's better now.

x1 CreateTextTagUnitBJ
x3 ShowTextTagForceBJ
x1 SetTextTagVelocityBJ
x2 GetForceOfPlayer

Other than that I guess the spell is ok.

12:06, 9th May 2011
The_Reborn_Devil:
The triggering looks ok, but you can use null instead of WEAPON_TYPE_WHOKNOWS ^^


Status: Approved
Rating: Useful

 

[aaron]

cool thats really nice for a hero arena type map.

 

[-Berz-]

Now, this is a nice spell =)

I like it because it's simple, and really useful.

I'm just wondering if just those 3 conditions prevents passive spell to be abused?

Also i wonder why did you put that wait 1 second... UnitApplyTimedLife should work ^^

Get rid of that wait and 5/5 =)

 

[Kingz]

Well after looking at it i must say that this is one of the rare GUI spells that uses only 1 editor variable^^
Nice work on the local variables, though i would make a global block in a separate trigger, let's call it setup:

• Setup
  • Events
    • Time - Elapsed game time is 0.01 seconds
  • Conditions
  • Actions
    • -------- To view ID's press CTRL + D in the object editor --------
    • -------- Settings for the spell --------
    • Custom script: globals
    • Custom script: constant integer Spellid = 'A001'
    • -------- True spell ID --------
    • -------- --- --------
    • Custom script: constant integer Dspellid = 'A000'
    • -------- Dummy spell ID --------
    • -------- --- --------
    • Custom script: constant integer Dummyid = 'h002'
    • -------- Dummy Unit ID --------
    • Custom script: endglobals
    • -------- --- --------
    • Custom script: call DestroyTrigger(GetTriggeringTrigger())

And then you could simply use those globals in the triggering later.
Also i don't know what effect does wait have on local variables, i think it is MUI but not sure.

 

[-Berz-]

Also i don't know what effect does wait have on local variables, i think it is MUI but not sure.

It doesn't have any effect, but why use wait since its evil? ^^

 

[Kingz]

Local variables and normal ones aren't same, i think wait doesn't have any influence on local variables and therefore when using only local variables you can use wait.

 

[Ranger21]

Make it with vJass please and don't use locations

If you make that, will be best passive critical strike

 

[1)ark_NiTe]

Well after looking at it i must say that this is one of the rare GUI spells that uses only 1 editor variable^^

Actually the editor variable isn't even there and isn't meant to be used. I'm uploading v.03 that contains no waits and that has removed that extra variable.

Thanks for catching it. And thank you everyone else for the feedback. I'll continue to work on this one to make it more efficient, and possibly make in complete JASS soon as I learn a little more about creating JASS functions.

Updates:

v.03
-Removed extra global variable that wasn't used.
-Removed wait
-Replaced texttag BJ's with natives.

 

[Ranger21]

If there's any way to remove event's when unit die?

 

[1)ark_NiTe]

If there's any way to remove event's when unit die?

Yeah I could easily. It shows the critical strike text so you know that it was the critical blow that killed them. However I creating the dummy unit is somewhat inefficient... yes. I'll look into working with that later today.

edit: Unfortunately the only way I can find through GUI without using a global variable to check if the unit has died is by using (Triggering Unit). Is this really inefficient or does it matter much?

 

[Kingz]

I would leave it GUI, why?
Because if you want to make it in JASS you have to destroy things like Boolexpresions and stuff, in GUI you can just leave those things.
In GUI it can get only a little more efficent, while in JASS you would need to do a bunch of stuff more and it would still be not that efficent for a JASS version.

 

[Deuterium]

I consider Local Variables to be very important indeed.

Using them is the only way I know how to make a spell MUI I'm still troubling with Indexing
It should have been the other way round true?

And for as much as I know, it doesn't ruin MUI if Waits are used

EDIT:

Btw, Dark Night I'm just curious to know:
Why did you use something like v.032 instead of something more simple v3.2 or whatever?

 

[-Berz-]

Why did you use something like v.032 instead of something more simple v3.2 or whatever?

Because that's uber pro h4x0r style

Hehe

 

[Malcous]

Very useful

 

[1)ark_NiTe]

Why did you use something like v.032 instead of something more simple v3.2 or whatever?

Because that's uber pro h4x0r style

Exactly.

Haha no it's actually because I consider this still to be in beta so it's in the .00's not 1.00's.

 

[Deuterium]

Dark Nite, why didn't you do it JASS at once?
there's only like 3 actions which are GUI, along side with conditions and events

 

[1)ark_NiTe]

why didn't you do it JASS at once?

Now I have

 

[RaedoN]

Nice ability. Good for arena-type maps

 

[1)ark_NiTe]

Just wondering why it's not approved yet

 

[-Berz-]

Because there are only 3 moderators, and all are busy in RL... ;<

 

[1)ark_NiTe]

What! There's no such thing as RL

 

[GLB]

What! There's no such thing as RL

-lol

Your spell's description sounds quite good.

 

[D4RK_G4ND4LF]

if u already made it jass so why not make it completely leakless?
it's still leaking the events every time a unit enters the map
you could counter that by destroying the trigger every time a unit dies but it would be laggy
maybe destroy it every 20 seconds or something like that
however i don't know a lot about jass but even i managed to make a leakless floating text damage show thing system
you shouldnt have any problems with that

 

[thereallywhitekid]

If you made it in jass then why is it categorized in GUI Triggers?
I also was inspired by this resource so I decided to make my own:

It basically is a critical that deals an additional 40/50/60 damage but
it will deal an extra 400 damage if the attacked unit has a life of 600/500/400.
I finished it but I don't know how to upload screen shots so I'll just upload it
in epicwar.com tomorrow. Made in GUI! (I hate jass, no offense jass users)

 

[f0rsAk3n]

Hey man nice spell.

MUI and leakless and clearly orignal.

5/5

 

[Caedrus]

This spell simply doesn't work, and I'm surprised it got past approval. It's MUI, sure, but it doesn't accomplish its basic function! Upon testing, I found that the Demon Hunter would critical strike not just on attacks, but with absolutely any kind of damage from any source, such as if he used Immolation, or an item. Since I'm sure this isn't intended (from the creator's own descriptions, not to mention the fact that this doesn't work anything like critical strike), I just can't give this a favorable rating since it doesn't work. Attached map file easily demonstrates the glitch: Just run around with Immolation on (no triggers or anything are changed, I just added Immolation to the demo hero).

If this issue is fixed, I will of course change my rating.

 

[ChaosKnight]

BJs. As moderator.

call CreateTextTagUnitBJ

>
local texttag t
set t = CreateTextTag()
call SetTextTagPos( t , GetUnitX(yourUnit) , GetUnitY(yourUnit) , 40)

 

[Pharaoh_]

I am suprised no one noticed this:

• Unit Group - Pick every unit in (Units in (Playable map area) matching ((Owner of (Picked unit)) Not equal to Neutral Passive)) and do (Actions)
  • Loop - Actions
    • Trigger - Add to Enhanced Critical Strike <gen> the event (Unit - (Picked unit) Takes damage)

It should be "Owner of (Matching unit)" Not Equal to Neutral Passive, not "Owner of (Picked unit)".

 

[1)ark_NiTe]

Yeah you're definitely right Pharaoh. That is the most important fix and the one I'll do right now. I'll work on the rest another time.

 

[1)ark_NiTe]

This spell simply doesn't work, and I'm surprised it got past approval.

Yeah this is a problem. What I've used in Against the Darkness is a system where you add any casting unit to a group for .15 seconds and then in your damage detection triggers you make sure to check if the unit is in that group or not. If it is then the spell wont execute. If the unit is not then the spell will execute. However that wont work with Immolation (I don't use Immolation in my map at all ). Is there a better way than this?

*EDIT* sorry for the double post, I didn't even think about it.

 

[Pharaoh_]

Yeah this is a problem. What I've used in Against the Darkness is a system where you add any casting unit to a group for .15 seconds and then in your damage detection triggers you make sure to check if the unit is in that group or not. If it is then the spell wont execute. If the unit is not then the spell will execute. Is there a better way than this?

*EDIT* sorry for the double post, I didn't even think about it.

I believe this is the best way to accomplish it
Other ways are buff status of 0.01 second duration, but Purge might just... purge the effects wanted!

 

[1)ark_NiTe]

Okay sweet. If you just downloaded the map, redownload it. I had to fix something quickly.

It should work fine now except for the fact that it will trigger with Immolation damage which I don't know how to fix!

 

[Pharaoh_]

Okay sweet. If you just downloaded the map, redownload it. I had to fix something quickly.

It should work fine now except for the fact that it will trigger with Immolation damage which I don't know how to fix!

Come again? What do you mean by that? It didn't trigger any immolation damage for me. When does it happen? How do you understand it?

 

[1)ark_NiTe]

Come again? What do you mean by that? It didn't trigger any immolation damage for me. When does it happen? How do you understand it?

Read Caedrus' post. He said that this spell would trigger from Immolation damage. I fixed the spell from executing on any other type of negative spell damage but I don't know how to keep it from triggering from Immolation damage.

 

[Pharaoh_]

Well, you simply need to detect if the damage is made by an attack. Obviously "takes damage" event applies for any type of damage dealt by the specified damage source. For the immolation part, you can of course make a buff check (if the unit has a buff, don't apply the effect), but generally, you need a physical damage detection system.

 

[Marcos DAB]

Very simple, maybe useful if improved.

 

[Adiktuz]

have you written the DDS yourself?

btw, the hidden tag is wrong, it says vampiric strike...

@Marcos_DAB: you always say that, but you never explained what needs to be improved...

 

[1)ark_NiTe]

I'm sorry I'm not familiar with the DDS acronym, what does it stand for? Thanks for the tip on the hidden text tag, I CnP'd from my other spell! Changed it now

 

[Adiktuz]

damage detection system... ^_^

 

[1)ark_NiTe]

No, it is Rising_Dusk's ArmorUtils system. I've put that in the "Read Me" in the map as well as mentioned it in the v.60 patch notes. It is a great system and I use it in my map Against the Darkness as well.

 

[Adiktuz]

how about the original DDS? since your spell already has a DDS right from the start (sorry, cannot open the map right now...)

 

[1)ark_NiTe]

The original DDS is mine. Yes sir.

 

[Adiktuz]

maybe I'll look at the map when I get time... ^_^

 

[1)ark_NiTe]

This spell or my map Against the Darkness?

 

[Adiktuz]

the spell... ^_^