Energy Shield [GUI - MUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Use a unit indexer to avoid having unneeded damage detection events.
Use a way to detect whether the unit already has the effect, so you won't create/store it again. Boolean - Hastable value exists.
Use starts the effect of an ability event.

 

[cboy123]

I think I would recommend to use the GDD Damage Detection

 

[Jazztastic]

1) Don't use imports in this spell. They aren't necessary from what I gather (Blizz provided spell shield model, it could work for this)

2) Improve the description. I gathered the general idea of the spell from looking at the triiggers (This spell shield absorbs 100/200/300 damage before evaporating), but you should add a description.

3) Use GetHandleID for your hashtables.

4) Units that take enough damage to kill them instantly wont have the damage negated via spell shield, because it checks AFTER the damage is received. For example, if I had a 50HP unit with energy shield take 75 damage, the spell wouldn't work.

5) In the /Then/ block of the EnergyShield Damage trigger, you could merge those two variable settings and the saving.

6)

• Trigger - Add to EnergyShield Damaged <gen> the event (Unit - (Target unit of ability being cast) Takes damage)

This seems like it would overwrite itself upon multiple casts. I havent tested, so I wouldn't know.

7) You should make the damage configurable and increase by level.

Overall, nice spell. I haven't tested, I'm not on my main computer right now, I'll do it tomorrow. This has inspired me to create a new passive

 

[cboy123]

1) Don't use imports in this spell. They aren't necessary from what I gather (Blizz provided spell shield model, it could work for this)

2) Improve the description. I gathered the general idea of the spell from looking at the triiggers (This spell shield absorbs 100/200/300 damage before evaporating), but you should add a description.

3) Use GetHandleID for your hashtables.

4) Units that take enough damage to kill them instantly wont have the damage negated via spell shield, because it checks AFTER the damage is received. For example, if I had a 50HP unit with energy shield take 75 damage, the spell wouldn't work.

5) In the /Then/ block of the EnergyShield Damage trigger, you could merge those two variable settings and the saving.

6)

• Trigger - Add to EnergyShield Damaged <gen> the event (Unit - (Target unit of ability being cast) Takes damage)

This seems like it would overwrite itself upon multiple casts. I havent tested, so I wouldn't know.

7) You should make the damage configurable and increase by level.

Overall, nice spell. I haven't tested, I'm not on my main computer right now, I'll do it tomorrow. This has inspired me to create a new passive

6) That's why I recommended GDD Detection for that code line.

 

[Bribe]

I recommend DamageEvent for the whole thing, that way you get Unit
Indexer with the package and it will solve the indexing needs for this
as well.

http://www.hiveworkshop.com/forums/spells-569/unit-indexer-spell-template-202003/
http://www.hiveworkshop.com/forums/spells-569/damage-event-1-0-0-0-a-201016/

 

[xorkatoss]

thnx for feedback all!!
this is my first MUI spell and as you can see i don't have that much experience

1) Don't use imports in this spell. They aren't necessary from what I gather (Blizz provided spell shield model, it could work for this)

well blizz shield models are not that good and i also needed the shield and explosion models to match each other

4) Units that take enough damage to kill them instantly wont have the damage negated via spell shield, because it checks AFTER the damage is received. For example, if I had a 50HP unit with energy shield take 75 damage, the spell wouldn't work.

yeah i noticed that too, i was rushing to finish the spell asap because im making lots of simple MUI spells for my map...
im gonna fix it when im done with the others spells...

 

[Axarion]

well blizz shield models are not that good and i also needed the shield and explosion models to match each other

You could link to the ressource then and say it fits to this spell

yeah i noticed that too, i was rushing to finish the spell asap because im making lots of simple MUI spells for my map...
im gonna fix it when im done with the others spells...

Releasing stuff in a rush is rarely a good idea.

 

[Adiktuz]

And maybe use Starts the effect rather than Begins casting...

Releasing stuff in a rush is rarely a good idea.

yeah...

 

[Deuterium]

maybe there isnt a shield nice enough... but still use what's given by blizzard in order to avoid using imports here.

imo, the only import that should be allowed in a test map should by Vex's dummy :/

 

[Pharaoh_]

Use Bribe's system or Weep's for the damage detection. You are flooding a trigger with many events, which you are not able to destroy.

 

[Maximum_Evil]

Maybe a spell discription :S

 

[Tal'Rarity]

Use Bribe's system or Weep's for the damage detection. You are flooding a trigger with many events, which you are not able to destroy.

You can avoid those two by making many dummy triggers with a count integer just to add to a new trigger to avoid event leaks.

 

[gorillabull]

You can avoid those two by making many dummy triggers with a count integer just to add to a new trigger to avoid event leaks.

damage engine does not require more than one event for this system

btw very nice spell just add damage engine and unit indexer

 

[Wrda]

You are leaking a player group.

• Game - Display to (Player group((Owner of (Triggering unit)))) the text: (Shield Left: + (String(EnergyShield_DamagedAbsorbed[2])))

Anyway it's a great spell and useful.