Electric Charge - Version 1.1a

[Moderator]

15:28, 6th Feb 2010
The_Reborn_Devil:
The triggering looks ok, and there are no leaks.

Status: Approved
Rating: Useful

 

[HaniBon]

Rating: 9/10

Spell seems to be MUI and Leakfree and I like it
No errors found or anything, spell works smoothly.

Good job, voting for approval.

 

[lolreported]

Rating: 9/10

Spell seems to be MUI and Leakfree and I like it
No errors found or anything, spell works smoothly.

Good job, voting for approval.

Thanks! +rep

This spell has been updated to version 1.0b. Read the changelog if you want to know about the updates.

 

[Kingz]

• ((Picked unit) is A structure) Equal to False
• ((Picked unit) is Magic Immune) Equal to False
• ((Picked unit) is alive) Equal to True
• (Picked unit) Not equal to EC_TargetUnit[EC_Index[3]]
• EC_MaxLightningTargetsCounter[EC_Index[3]] Less than EC_MaxLightningTargets[EC_Index[3]]

No,no and no. Use group filters, not if/then/else.

Also you have 2 temp variables (EC_Point[] and EC_UnitGroup[]) no need for them to be arrays, remove the arrays and use them like that.

 

[Itachi009]

• ((Picked unit) is A structure) Equal to False
• ((Picked unit) is Magic Immune) Equal to False
• ((Picked unit) is alive) Equal to True
• (Picked unit) Not equal to EC_TargetUnit[EC_Index[3]]
• EC_MaxLightningTargetsCounter[EC_Index[3]] Less than EC_MaxLightningTargets[EC_Index[3]]

No,no and no. Use group filters, not if/then/else.

Also you have 2 temp variables (EC_Point[] and EC_UnitGroup[]) no need for them to be arrays, remove the arrays and use them like that.

Kingz is right as always... i like the spell and its leakless
if you fix this glibberish thing in your triggering 10/10, right now 8.5/10 but
I vote for approval in each case

 

[DarkAngelAzazel]

Hey I know this spell

It's used in EotA (eve of the apocalypse)

Still I think you did a good job in coding it so I give you 9/10 (if you fix those mentioned bugs)

 

[lolreported]

• ((Picked unit) is A structure) Equal to False
• ((Picked unit) is Magic Immune) Equal to False
• ((Picked unit) is alive) Equal to True
• (Picked unit) Not equal to EC_TargetUnit[EC_Index[3]]
• EC_MaxLightningTargetsCounter[EC_Index[3]] Less than EC_MaxLightningTargets[EC_Index[3]]

No,no and no. Use group filters, not if/then/else.

Also you have 2 temp variables (EC_Point[] and EC_UnitGroup[]) no need for them to be arrays, remove the arrays and use them like that.

I've fixed this now, thanks for the help, +rep!

@Itachi009, thanks

@DarkAngelAzazel, I've no idea of what this "EotA" is ^^ So I don't really know... Thanks

This spell has been updated to version 1.1a. Read the changelog if you want to know about the updates.