Draconis Spell Pack

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

02:33, 22nd Jul 2012
Magtheridon96:

Comments

• Check out Hanky's dynamic index method
• Check out Bribe's Damage Engine.
  You shouldn't use the "Attack" event to detect damage, that's totally abusable. I can attack a unit and press stop rapidly, and still fire the trigger.
• You don't need to null globals. This means that you don't need to reset everything when you destroy a spell instance.
• Your spells need to have configuration triggers where the user can easily modify spells. (Duration, AoE, damage, special effects, etc...)
• Dividing by 1 is useless
• The spells in the testmap should have 0 cooldowns and manacosts.
• Trigger

  • Unit - Create 1 Cataclysm Dummy for (Owner of CatacylsmCaster[CataclysmLoop]) at (Position of CatacylsmCaster[CataclysmLoop]) facing Default building facing degrees

  You obviously leaked the location by accident ;D
  Just replace that (Position...) call with CatacylsmCasterLoc

Anyways, good job here ^_^
You don't need the imported models by the way.

I really love your style of coding.

 

[eubz]

Nice spell pack.

 

[Adiktuz]

post triggs?

also, on the description, tell us the name of the abilities and not just 1st skill blahblah...

and oh, one of my friends already tried sending a hero suggestion with a custom model, and they told him that they cannot afford to import hero models as they are nearing the file size limit so they are reserving the little space left for more important things...

 

[Tank-Commander]

You really don't need custom imports for this spellpack - as the rules say you should only have them if they are essential to the fundamentals of the spell or spells.

You need a configuration at the start which contains the configurables for /every/ spell, rather than have the configurables splayed out everywhere, which proper labels and comments to know which is which, and also there are some things which are not configured in the actual spells themselves, and that should be changed as well and they should be made configurable (such as mana gain)

Also "Warriors power" is abusable - you have to use a damage detection system for that

The strength modifier I'm not sure wether it's abusable or not - I will check it briefly in a minute or two, also you don't need to use /ANY/ object data to deal damage - it's generally poor practice and not even needed under any cercumstances, This applies to two of your spells

Pausing units is generally bad practice - it'd be better if you could avoid it

 

[eubz]

Yeah, I also noticed that you do not have configurable values that should be set at map initialization.

 

[Tank-Commander]

oh Also you only need one dummy for the spell pack, right the stat gain is no abusable, however I did find out that the spell will continue even if the hero is dead, you should put a check on that and stop it when/if the hero dies mid-casting, also your description for your "Warriors power" is wrong

EDIT: Also for peak efficiency, this entire spellpack could be compressed into two triggers (plus one additional for configuration) but I wouldn't know how good of an idea that would be, but in eithercase it's pretty bad to have so many loops running at the same time, also your spells aren't exactly balanced as they stand - killing knights in one cast of some of them really isn't good

 

[WyrmSlayer]

You really don't need custom imports for this spellpack - as the rules say you should only have them if they are essential to the fundamentals of the spell or spells.

You need a configuration at the start which contains the configurables for /every/ spell, rather than have the configurables splayed out everywhere, which proper labels and comments to know which is which, and also there are some things which are not configured in the actual spells themselves, and that should be changed as well and they should be made configurable (such as mana gain)

Also "Warriors power" is abusable - you have to use a damage detection system for that

The strength modifier I'm not sure wether it's abusable or not - I will check it briefly in a minute or two, also you don't need to use /ANY/ object data to deal damage - it's generally poor practice and not even needed under any cercumstances, This applies to two of your spells

Pausing units is generally bad practice - it'd be better if you could avoid it

aw i forgot to those configuration informations but they are there as integers. the strength modifier is not abusuable i tried. i dont know how to detect damage by attacks in the warrior's power so i just tried the normal old way of doing it just like rikimaru on dota who can abuse the effects. i dunt really mind if someone abuses the effects of the warrior's power because he would basically give up the damage on his attack just to intake 20 mana.

 

[Adiktuz]

I wonder how many mana I could gain with the third skill with super fast fingers?

If someone is fast enough I think he could like activate that 5 times per second... that's not much of a waste... and I believe spells uploaded shouldn't be abusable...

and warrior's power has no multilevel support

and the tag for hiding is hidden not hide

 

[Tank-Commander]

i dunt really mind if someone abuses the effects of the warrior's power because he would basically give up the damage on his attack just to intake 20 mana.

It's not about what you'd mind, it's about what the mods will mind

 

[WyrmSlayer]

It's not about what you'd mind, it's about what the mods will mind

NVM im reading about attack damage detection ill update this later, also can you tell me how to hide those triggers =D i made something wrong there.

 

[Tank-Commander]

Well it cannot be done in GUI, hence why we have a large amount of Damage Detection systems on the hive - you would have to use one of them

 

[eubz]

the tags should be

[hidden]your triggers[/hidden]

not [hide][/hide].

 

[Adiktuz]

ur not reading my posts eh? if you did, you will not ask how to hide posts... XD

 

[WyrmSlayer]

Well it cannot be done in GUI, hence why we have a large amount of Damage Detection systems on the hive - you would have to use one of them

Ive seen many Damage detections like GUI-Friendly Damage Detection v1.2.1 but how do i use it? it says copy and paste. but then how do i apply the trigger of Warrior's Power to it?
Please help, once i see it i can learn it =D

 

[Tank-Commander]

I'm pretty sure there's instructions if you look at the actual JASS code there, if not elsewhere

 

[eubz]

do this

[hidden=triggers]<your triggers>[/hidden]

you forgot the =<name of hidden whatever> code.