- Joined
- Jul 26, 2008
- Messages
- 1,009
I feel I understand vaguely what a doublefree is. However, I'm not always able to detect them.
This system was created for me by ... Bribe or Berb. I wish I could remember. However it's creating Double Frees in the map (Probably harmless, but better safe than sorry.)
It isn't long, and it's well put together. The DoubleFrees come a little while after the spells are used.
Help with it is highly appreciated, thanks
Also a little extra help, but what is the best way to decrease a Hero's EXP by 1 every second (Set or Add with a negative value?).
This system was created for me by ... Bribe or Berb. I wish I could remember. However it's creating Double Frees in the map (Probably harmless, but better safe than sorry.)
It isn't long, and it's well put together. The DoubleFrees come a little while after the spells are used.
Help with it is highly appreciated, thanks
Also a little extra help, but what is the best way to decrease a Hero's EXP by 1 every second (Set or Add with a negative value?).
JASS:
library UnitAbility requires AutoIndex, TimerUtils
globals
public constant integer STORED_ABILITIES = 3
endglobals
struct abilitydata
readonly unit caster = null
readonly unit target = null
readonly real castx
readonly real casty
readonly real targetx
readonly real targety
readonly real castAngle
readonly real castRange
readonly integer abilityid
readonly string orderstring
method copy takes nothing returns thistype
local thistype copy = allocate()
set copy.caster = caster
set copy.castx = castx
set copy.casty = casty
set copy.target = target
set copy.targetx = targetx
set copy.targety = targety
set copy.abilityid = abilityid
set copy.orderstring= orderstring
set copy.castAngle = castAngle
set copy.castRange = castRange
return copy
endmethod
static method create takes nothing returns thistype
local thistype abil=allocate()
set abil.caster=GetTriggerUnit()
set abil.castx=GetUnitX(abil.caster)
set abil.casty=GetUnitY(abil.caster)
set abil.target=GetSpellTargetUnit()
set abil.targetx=GetSpellTargetX()
set abil.targety=GetSpellTargetY()
set abil.abilityid=GetSpellAbilityId()
set abil.orderstring=OrderId2String(GetUnitCurrentOrder(abil.caster))
//misc spell-data
set abil.castAngle=Atan2(abil.targety-abil.casty, abil.targetx-abil.castx) //in radians
set abil.castRange=SquareRoot((abil.targetx-abil.castx)*(abil.targetx-abil.castx) + (abil.targety-abil.casty)*(abil.targety-abil.casty))
return abil
endmethod
endstruct
struct unitabilities
readonly abilitydata array entry [STORED_ABILITIES]
readonly integer stored = 0
method onDestroy takes nothing returns nothing
local integer i=0
loop
exitwhen(i==stored)
if(entry[i]!=0) then
call entry[i].destroy()
endif
set i=i+1
endloop
endmethod
method addAbility takes abilitydata dat returns boolean
local integer i=0
loop
exitwhen(i==stored)
if(entry[i]==dat) then
return false
endif
set i=i+1
endloop
if(stored==STORED_ABILITIES) then
call entry[0].destroy()
set entry[0]=entry[1]
set entry[1]=entry[2]
set entry[2]=dat
else
set entry[stored]=dat
set stored=stored+1
endif
return true
endmethod
endstruct
private struct savedata
public unit source = null
public unit target = null
public abilitydata abilData
static method create takes unit source, unit target, abilitydata data1 returns thistype
local thistype data = allocate()
set data.source = source
set data.target = target
set data.abilData = data1
return data
endmethod
endstruct
struct unitabilityhistory //requires AutoIndex, TimerUtils
public unitabilities out
public unitabilities in
private trigger abilevent = CreateTrigger()
private timer threadDelay = null
private boolean skipFlag = false
method freeze takes boolean flag returns nothing
if flag then
call EnableTrigger(abilevent)
else
call DisableTrigger(abilevent)
endif
endmethod
method skip takes nothing returns nothing
set skipFlag = true
endmethod
method onDestroy takes nothing returns nothing
call out.destroy()
call in.destroy()
call DestroyTrigger(abilevent)
if threadDelay != null then
call ReleaseTimer(threadDelay)
endif
endmethod
static method onAbilEventThreadDelay takes nothing returns nothing
local savedata data = GetTimerData(GetExpiredTimer())
call thistype[data.source].out.addAbility(data.abilData.copy())
call thistype[data.target].in.addAbility(data.abilData.copy())
call data.abilData.destroy()
call ReleaseTimer(GetExpiredTimer())
endmethod
static method onAbilEvent takes nothing returns boolean
local thistype data = thistype[GetTriggerUnit()]
if not data.skipFlag then
set data.threadDelay = NewTimer()
call SetTimerData(data.threadDelay, savedata.create(GetTriggerUnit(), GetSpellTargetUnit(), abilitydata.create()))
call TimerStart(data.threadDelay, 0, false, function thistype.onAbilEventThreadDelay)
endif
set data.skipFlag = false
return false
endmethod
method onCreate takes nothing returns nothing
set out = unitabilities.create()
set in = unitabilities.create()
call TriggerRegisterUnitEvent(abilevent, me, EVENT_UNIT_SPELL_EFFECT)
call TriggerAddCondition(abilevent, Filter(function thistype.onAbilEvent))
endmethod
implement AutoCreate
implement AutoDestroy
endstruct
endlibrary
