DotA: Captain Mode v1.1

[Moderator]

07:49, 13th Jun 2014
BPower:
Not configurable, requires a lot of code improvement, integrated AI script, ... rejected

 

[Kazeon]

• Wait 5.00 seconds

that line is enough to make this unacceptable

anyway, dont try to upload map-specific system here, I mean please upload system that is useable by maps in general..

EDIT:
and the title doesn't fit the system, I see it is a pack of systems. not Captain Mode only..

 

[deathismyfriend]

This is not vJass at all.
You have broken trigger tags.
Never use waits.
Never use Integer A / B. Create your own variable and use a custom integer loop for speed and efficiency.
Use a loop trigger to see if player is playing.

Anything used twice or more should be stored into a variable and the variable should be used.

All of these systems are hard coded to much. Look at other systems to see how they allow for configuration.
This makes no sense at all to have.

• <Empty String> +

It is in many of your strings.

You leak locations.

You should look at the tutorial Things that leak on triggers and scripts page.
Also you should look at my tutorial Things You Should Know When Using Triggers / GUI

 

[GreeN!X]

Cmon guys, it's a system. from DOTA open source. and she claimed it as her own. and even made the users give her credits.

That's already enough reason not to accept this.

 

[deathismyfriend]

Cmon guys, it's a system. from DOTA open source. and she claimed it as her own. and even made the users give her credits.

That's already enough reason not to accept this.

I didn't even notice the name. Thanks though. Might as well report this system then.

 

[hdm]

Damn, the criticism of the HW's guys hurt. I have to be very cautious when I make my first spell.

 

[deathismyfriend]

Damn, the criticism of the HW's guys hurt. I have to be very cautious when I make my first spell.

It is just meant to help people code better to get good resources submitted and approved.

 

[Anggi Oktaviani P]

ok all. So, i must changed categories, title, remove location/ add var then removelocation that, remove waits, changed foorloop A/B to integer, changed preview map, put ss map and etc.

Im very sry for all.

 

[PurgeandFire]

@GreeN!X: Do you have a link to that map? It isn't from DotA or the open source DotA on XGM since both of those are written in JASS. Unless there is a different one that I haven't seen yet.

 

[GreeN!X]

Nope and I've never actually opened DotA open source. The title, the preview and the triggers made me assume that it was from the Open source. My bad.

 

[deathismyfriend]

ok all. So, i must changed categories, title, remove location/ add var then removelocation that, remove waits, changed foorloop A/B to integer, changed preview map, put ss map and etc.

Im very sry for all.

Yes and it isn't that big of a deal nothing to be sorry for. You should take a look at the things that leak tutorial on triggers and scripts forum.
Also take a look at my tutorial things you should know when using triggers / gui. Link is in my sig.

 

[gorillabull]

ooooh look at that! its open source

 

[Daffa]

Green!X : if it's open source (like one from TheHelper, it's GUI), it shouldn't have leaks nor uses Integer A/B (I assume, since AceHeart is a well known triggerer).

Purge : I recall there's another one at The Helper Net....

Oh wait, here's the document : http://world-editor-tutorials.thehelper.net/maps.php?view=137

 

[GreeN!X]

But, I didn't say anything about leaks or integer A/B. :/

 

[deathismyfriend]

You need to combine your ITEs.
Example: This

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
  • Then - Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Player(Game_Integer)) controller) Equal to (==) User
      • Then - Actions
        • Set Game_Leader = Playername[Game_Integer]
      • Else - Actions

Into this.

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
    • ((Player(Game_Integer)) controller) Equal to (==) User
  • Then - Actions
    • Set Game_Leader = Playername[Game_Integer]
  • Else - Actions

Also use a look and loop through all players checking for these conditions rather than a big mess of ITEs.

Anything used twice or more should be stored into a variable and the variable should be used. Example: store (Last created multiboard) into a mutliboard variable and use the variable.
This is for speed and efficiency.

Never use Entering unit. Use Triggering unit.
Never use Casting unit. Use Triggering unit.

This is just very inefficient and way to hard coded.
Look at some of the other systems here to see how they are easily manipulated to the users liking.

Also about this comment in your spell description.
The Script Take From Battle of Heroes v1.3 by IceFrog Indonesian
Any scripts taken and tried to be passed off as your own will get it removed and you possibly banned.
If this is not your own resource you should delete it.

 

[Daffa]

But, I didn't say anything about leaks or integer A/B. :/

I know, I hope you did read the other posts though

EDIT :
DIMF : perhaps the map was open source and the author has permit him, you can ask if he/she has gain permission from Legend of BOH owner

EDIT :
The map was set to NEEDS FIX as of 03-26-2014, 07:01 PM.

 

[yanchespenda]

She get the permission from IFI... to shared some System..

 

[Anggi Oktaviani P]

You need to combine your ITEs.
Example: This

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
  • Then - Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Player(Game_Integer)) controller) Equal to (==) User
      • Then - Actions
        • Set Game_Leader = Playername[Game_Integer]
      • Else - Actions

Into this.

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
    • ((Player(Game_Integer)) controller) Equal to (==) User
  • Then - Actions
    • Set Game_Leader = Playername[Game_Integer]
  • Else - Actions

Also use a look and loop through all players checking for these conditions rather than a big mess of ITEs.

Anything used twice or more should be stored into a variable and the variable should be used. Example: store (Last created multiboard) into a mutliboard variable and use the variable.
This is for speed and efficiency.

Never use Entering unit. Use Triggering unit.
Never use Casting unit. Use Triggering unit.

This is just very inefficient and way to hard coded.
Look at some of the other systems here to see how they are easily manipulated to the users liking.

Also about this comment in your spell description.
The Script Take From Battle of Heroes v1.3 by IceFrog Indonesian
Any scripts taken and tried to be passed off as your own will get it removed and you possibly banned.
If this is not your own resource you should delete it.

If this The System have two functions
1. To Start the You are Team Leader, Chosen a Mode. [Only User]
2. To Picks or Bans in Captain Mode [Only both Computers or User]

 

[deathismyfriend]

You need to combine your ITEs.
Example: This

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
  • Then - Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Player(Game_Integer)) controller) Equal to (==) User
      • Then - Actions
        • Set Game_Leader = Playername[Game_Integer]
      • Else - Actions

Into this.

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Player(Game_Integer)) slot status) Equal to (==) Is playing
    • ((Player(Game_Integer)) controller) Equal to (==) User
  • Then - Actions
    • Set Game_Leader = Playername[Game_Integer]
  • Else - Actions

Also use a look and loop through all players checking for these conditions rather than a big mess of ITEs.

Anything used twice or more should be stored into a variable and the variable should be used. Example: store (Last created multiboard) into a mutliboard variable and use the variable.
This is for speed and efficiency.

Never use Entering unit. Use Triggering unit.
Never use Casting unit. Use Triggering unit.

This is just very inefficient and way to hard coded.
Look at some of the other systems here to see how they are easily manipulated to the users liking.

Also about this comment in your spell description.
The Script Take From Battle of Heroes v1.3 by IceFrog Indonesian
Any scripts taken and tried to be passed off as your own will get it removed and you possibly banned.
If this is not your own resource you should delete it.

If this The System have two functions
1. To Start the You are Team Leader, Chosen a Mode. [Only User]
2. To Picks or Bans in Captain Mode [Only both Computers or User]

I have no idea what those are referring to as I have mentioned fixes / optimizations to the code you have provided.

 

[yanchespenda]

I Think in number 1 is the system in BoH. In number 2 is her resource. So, Number 1 is additional in this resource.

 

[Razer!X]

If this The System have two functions
1. To Start the You are Team Leader, Chosen a Mode. [Only User]
2. To Picks or Bans in Captain Mode [Only both Computers or User]

deathismyfriend is trying to say that you need to fix this part of the system.

 

[yanchespenda]

I have no idea what those are referring to as I have mentioned fixes / optimizations to the code you have provided.

She Create this in hard code right ?

 

[deathismyfriend]

She Create this in hard code right ?

This system is hard coded yes. And unless it is changed it will not be approved as it does not offer flexibility when hard coded.
My statement was that I was explaining how to code more efficiently.

 

[BPower]

Anything used more than once should be stored into a variable, for instance Owner of (Casting Unit).

The AI is also integrated into the script? Who does need this?

I don't think this will be approveable at any point, because it is too map specific, not configurable and coded inefficiently. In my eyes this is more material for the "request section", once someone has such a request.

 

[deathismyfriend]

I don't think this will be approveable at any point, because it is too map specific, not configurable and coded inefficiently. In my eyes this is more material for the "request section", once someone has such a request.

This shouldn't belong in the request section.