Does this function has an destructible version?

[streetpunk]

Can this function have an destructible version of it, using destructible instead of units? I'm not very good with JASS so I don't know

• Custom script: call GroupEnumUnitsInRangeOfSegmentLoc( udg_TempGroup, udg_Loc1, udg_Loc2, 10.0, null )

 

[Tasyen]

This is a really good website, you can find the api of jass and all other things about it.
http://jass.sourceforge.net/doc/api/index.shtml

 

[IcemanBo]

Yes there is a native to enum destructables inside a rect, though it does not create a "group" of them which you must care of.
It only enums them and you can refer them with "Picked Destructable".

There is even an GUI equivalent for it, so you can use this.

 

[streetpunk]

Can you please tell me, IcemanBo ?

 

[IcemanBo]

There exists this native functions:

native EnumDestructablesInRect takes rect r, boolexpr filter, code actionFunc returns nothing

But you can use it also with GUI as said. If you want achieve something in jass/custom script from GUI you can search the respective action in GUI and convert it to custom text. So you will see the output.

 

[streetpunk]

GUI is also a good option since the most portion of my map is GUI. however how can this be adapted to fit the rect of Loc1 and Loc2, and how can I put the trees in an group? Sorry Iceman I'm not an JASS scripter, I sometimes can work with them, but can't create them myself

 

[IcemanBo]

Read my previous posts. You can not create a "group" of destructables. At least not the way you are thinking of it.

I didn't read the first custom script close enough, and you forgot it to mention. You use a library which provides this custom function "GroupEnumUnitsInRangeOfSegmentLoc" for you.
So you can not use it directly in GUI, but instead need to rewrite it.

Provide the library you use.

 

[streetpunk]

function GroupEnumUnitsInRangeOfSegment takes group whichgroup, real Ax, real Ay, real Bx, real By, real distance, boolexpr filter returns nothing
    local real dx = Bx-Ax
    local real dy = By-Ay
    local real L = ((dx)*(dx) + (dy)*(dy)) // Get quasi length
    local real r = SquareRoot(dx*dx+dy*dy)/2+distance + 400.0 // replace 400.0 with the max collision size in your map
    local unit u
    call GroupClear(whichgroup)
    call GroupEnumUnitsInRange(udg_LineTempGroup, Ax+(dx/2), Ay+(dy/2), r, filter)
    loop
        set u = FirstOfGroup(udg_LineTempGroup)
        exitwhen u == null
        if L == 0 and IsUnitInRangeXY(u, Ax, Ay, distance) then // seg is actually a point so lets return the point
            call GroupAddUnit(whichgroup, u)
        else
            set r = ((GetUnitX(u)-Ax)*(dx) + (GetUnitY(u)-Ay)*(dy))/(L) // get the ratio
            if r > 1 then // split if/thens so that it exists properly
                if IsUnitInRangeXY(u, Bx, By, distance) then // closests point is past seg, so return end point B
                    call GroupAddUnit(whichgroup, u)
                endif
            elseif r < 0 then
                if IsUnitInRangeXY(u, Ax, Ay, distance) then // same as B, but at A instead
                    call GroupAddUnit(whichgroup, u)
                endif
            elseif IsUnitInRangeXY(u, Ax+r*(dx), Ay+r*(dy), distance) then // In the middle of A and B so use the ratio to find the point
                call GroupAddUnit(whichgroup, u)
            endif
        endif
        call GroupRemoveUnit(udg_LineTempGroup, u)
    endloop
    set u = null    
endfunction
function GroupEnumUnitsInRangeOfSegmentLoc takes group whichgroup, location A, location B, real distance, boolexpr filter returns nothing
    call GroupEnumUnitsInRangeOfSegment(whichgroup, GetLocationX(A), GetLocationY(A), GetLocationX(B), GetLocationY(B), distance, filter)
endfunction

 

[IcemanBo]

Try the attached demo.

 

[streetpunk]

I opened it and walked arround with the footmans but nothing happanned
PS: Will it work with normal world editor or only with JassNewgen? If so I'll ask purgeandfire to make a normal JASS version of it to work with normal world editor

 

[IcemanBo]

Yes it requires JNGP at the moment. If you want use other's code JNGP is very recommended.
I don't have time to fix it now if it doesn't work. Someone else can, or I look at it on an other day.

 

[streetpunk]

What do I have to do in the map? just walk arround the trees ? I'm opening on jassnewgen and nothing happens too

 

[IcemanBo]

Try it again.

What do I have to do in the map?

Look at demo trigger. 2 units are created in game, and you can randomly walk around in map. All trees between them will be killed.

 

[streetpunk]

Thanks a lot, IcemanBo it's working, the trees are getting destroyed! I'll send the code to purgeandfire for vJass -> JASS translation. If you could translate it that would be great but I'm requiring too much from you, you already helped me a lot, thanks again!

 

[IcemanBo]

Will do it. Hold on.

 

[IcemanBo]

http://www.hiveworkshop.com/threads/untitled.286552/

 

[streetpunk]

It's working fine, IcemanBo thanks a lot! I'll try implementing it on my map and if I cross with any trouble I'll be back here to ask for help, again thanks a lot for helping me out!

EDIT: The editor is returning an error when I try to initiate the my map after I just copied the category containing the triggers, I just copied it with the preferences for variables enabled and it can't start.

 

[IcemanBo]

When you disable the trigger(s) it is working? It works for me. Could you attach your not working map?

Edit: I think it was because I copied Anitarf's function, and you already use it inside your header. Try it now again.

 

[streetpunk]

The map is starting without errors now, thanks! I'll try implementing it now

 

[IcemanBo]

Awesome.

 

[streetpunk]

I've run into a problem, sometimes the tree is killed, but sometimes it doesn't
The part of the trigger I've implemented on mine:

• LSE How to Use Copy
  • Events
  • Conditions
  • Actions
    • Set LSE_Loc_1 = Loc1
    • Set LSE_Loc_2 = Loc2
    • Set LSE_Width = 10.00
    • Trigger - Run LSE_Trigger_GetDestructables (ignoring conditions)
    • For each (Integer A) from 1 to LSE_Counter, do (Actions)
      • Loop - Actions
        • Destructible - Kill LSE_Destructable[(Integer A)]
    • Custom script: call RemoveLocation(udg_LSE_Loc_1)
    • Custom script: call RemoveLocation(udg_LSE_Loc_2)

 

[IcemanBo]

What is the event? The width is very low. For normal trees/units something like 60-90 is probably good.

What is Loc1/Loc2 are they created before you run trigger?

 

[streetpunk]

The event is "A unit dies" I've tested the Width with higher values such as 100 and had the same effect.
Loc1 and Loc2 are set in the same trigger before those actions, Loc1 menas the position of an unit (player hero) and Loc2 the position of another unit (dying or triggering unit)

 

[IcemanBo]

Can't say something without seeing the code then. People, you must learn that we have no magics power to see problems in code we don't see.

 

[streetpunk]

Iceman, does this line works with verry small lines? I was using an line of about 100-120 long and it wasn't always working, I changed to a longer line (100 to the back of one unit, 100 to the front of the another. Loc1 and Loc2) and most of the trees were now sucesfully chopped down.

 

[IcemanBo]

That's too speculative to answer properly. If you create a sample which seems to bring wrong result in the demo, then someone can look at the triggers.

 

[streetpunk]

I may have found what's causing the issue, but I don't know how to fix it. Here's what I've found so far:
The triggers system I'm using for this is based on creating an unit at distance from the player hero, then add expiration timer to it, when it dies a trigger will be fired. I firstly was using an invisible dummy, but once I made the unit visible I could see the unit could not be created correctly because of the destructible in the path of the hero, instead it is created somewhere else near. The positions I'm using are: Loc1 = Position of hero. Loc2 = Position of the dummy unit. I think that that I need to bypass that issue of creating the unit on the wrong place, but how ?

PS: If I set the second location to very far in front of the hero, the system works, because the destructible don't cause interference.

 

[IcemanBo]

After creation you may use SetUnitX/Y natives to move a unit to new coordianetes without checking for collision. This may help tp get your dummy to any location.
Use GetLocationX/Y to get the wanted coordiantes.

 

[streetpunk]

I've never used this function before, what do I do to detect where to move the unit ?

 

[IcemanBo]

Use:

call SetUnitX( <yourunitVariable>, <newX>)
call SetUnitY( <yourunitVariable>, <newY>)

GUI variables in JASS/Custom script need usg_ prefix ; so "Unit" will becomes "udg_Unit".

For new x/y you can use:

GetLocationX(<yourLocationVariable>)
GetLocationY(<yourLocationVariable>)

... ^ these functions get the x/y coodinate of a location/point. So take these in combination to move a unit to a location.

So finaly you will need two lines of custom script using the SetUnitX/Y natives, and within them to define which x/y you use the GetLocationX/Y natives.

 

[streetpunk]

I understood a little about what you said, but I've come to a conclusion that it's not the unit's position that's causing the problem. I've set Loc1 to position of hero, and Loc2 to position of hero with polar offset (120 towards facing of hero) and it keeps the same way, sometimes some trees are destroyed and some aren't. here's an clear test map:


EDIT: I may have found what was causing the error:

• For each (Integer A) from 1 to LSE_Counter, do (Actions)
  • Loop - Actions
    • Destructible - Kill LSE_Destructable[(Integer A)]

I replaced this function with:

• Destructible - Pick every destructible within 120.00 of Loc1 and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (LSE_Rect contains (Position of (Picked destructible))) Equal to True
      • Then - Actions
        • Destructible - Kill (Picked destructible)
      • Else - Actions

So the trigger was like that:

• Test
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to YourUnitType
  • Actions
    • Set Loc1 = (Position of Hero)
    • Set Loc2 = (Position of (Triggering unit))
    • Set LSE_Loc_1 = Loc1
    • Set LSE_Loc_2 = Loc2
    • Set LSE_Width = 10.00
    • Trigger - Run LSE_Trigger_GetDestructables (ignoring conditions)
    • Destructible - Pick every destructible within 120.00 of Loc1 and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (LSE_Rect contains (Position of (Picked destructible))) Equal to True
          • Then - Actions
            • Destructible - Kill (Picked destructible)
          • Else - Actions
    • Custom script: call RemoveLocation(udg_LSE_Loc_1)
    • Custom script: call RemoveLocation(udg_LSE_Loc_2)

And now the destructibles are getting picked correctly without a single error!

 

[IcemanBo]

Man, you almost got me... But it works correctly. You used wrong location in your demo. You created a new location and used it. So switch Loc_1 to the Loc_1 of the LSE system.

 

[streetpunk]

Yeah I forgot about changing it properly when I paste it to the demo map. I've set it to a correct location but it ended up the same way as before, I think the problem was really the "For each.." function, because I've changed for the new function and it works like magic! Thanks a lot for your coding, IcemanBo!

PS: It's an system that detects the animation of the swing of the sword, that's why the so low Width, to pick everything by intervals of 10 to 10 distance and when it crashes to a tree, the attack stops. It's like an coded normal attack, but using an ability instead.

 

[IcemanBo]

Your posted code is not similar to the system's code, as you make a circular search. If that is what you need then the system is not needed anways.
But the loop is not bugged and all worked properly when I tested it. So the problem might be in wrong usage.

 

[streetpunk]

The code I posted is the one with my solution, not the original. I think it is needed because I need to check if the destructible is in the LSE_Rect.

 

[IcemanBo]

But do you realize that using the default enumeration has not too much to do with this thread? If you can use it then you don't need a new system.

 

[streetpunk]

I do need the system, specificaly I need this:

• Trigger - Run LSE_Trigger_GetDestructables (ignoring conditions)

to set the rect, on which I'll be cheching if the destructible is in it later.