[Trigger] Do Item-Types leak?

[Black-apples]

I've been trying to construct a simple backpacking system that will store items in one bank, for all players. So any player can put in, and player can take out.

It works by indexing the items, BP_Times + 1, Save item type as Item_Type[BP_Times]. Then unpacking is setting P[0] to position of casting unit, for loop BP, from 1 to BP_Times. Create one Item_Type[BP] at P[0]. Then destroying the point. For some reason unloading causes unit lag (The unit will not play another action until it finishes whatever it was doing).

Here are the triggers

Pack

Pack

• Pack
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Pack
  • Actions
    • Set BP_Times = (BP_Times + 1)
    • Set BP_Save[BP_Times] = (Item-type of (Target item of ability being cast))
    • Item - Remove (Target item of ability being cast)

Unpack

Unpack

• Unpack
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Unpack
  • Actions
    • Set P[0] = (Position of (Casting unit))
    • For each (Integer BP) from 1 to BP_Times, do (Actions)
      • Loop - Actions
        • Item - Create BP_Save[BP] at P[0]
    • Set BP_Times = 0
    • Custom script: call RemoveLocation(udg_P[0])

As you can see, VERY simple triggers. They work out fine, just cause lag. I really don't want to do hash tables unless I have to.


Thanks in advance.

 

[Mr_Bean]

I'm not sure why it lags. Item types do not leak.

EDIT: Is "P[0]" a location array?

 

[Black-apples]

Yes it is, I use P as universal array so I don't have a clutter of variables.

And no, I don't use it for any kind of loops, so it doesn't glitch.

 

[Mr_Bean]

Does it lag every time you unpack or just the first time?

 

[Black-apples]

It doesn't pause lag, I don't care too much for that. The problem is when you use it, it causes unit lag. Have you ever played a map where you have TONS of units? And it takes forever for the units to respond? It's just like that.

 

[Mr_Bean]

Yup, I know that feeling. Sorry, I can't help :O

EDIT: Thanks for 3rd gem!

 

[Bannar]

Post map?

 

[baassee]

Try to create the item at first at a random spot at map ini and re-try.

 

[Luorax]

type itemtype extends handle

AFAIK handles DO leak.

EDIT: oh, it's GUI, my bad, I should have checked the triggers too.
Nvm then.

 

[Pharaoh_]

Are the abilities Pack/Unpack based off abilities with missiles, e.g. Shockwave?

 

[WaterKnight]

Removing stuff related to the cast while casting like the target here is not that nice. Maybe take the endcast event and store the item on spelleffect to be able to retrieve the item. For example, when trying to cast the Channel ability and pausing the caster on spelleffect, it will restart the order when being unpaused again.

 

[Black-apples]

reply

It's based off of Finger of Death (Pack, targets items only), and avatar (unpack). None of them have any kind of effects or anything.

EDIT: Here's the map, no criticizing, I am no where near finished. It's a mini-map contest me and my friends are having , only 5 imports only. So no criticizing :O

http://www.hiveworkshop.com/forums/pastebin.php?id=3n734o

 

[Bannar]

I've tested the trigger, and thats not pack/unpack. You can even give your 'Visctom' both abilities and create few items just right next to him. Now spam both abilities, no lag occurs. Probably it's because of leaks - I don't know when ou get both abilities, in case I had to add them to 'Victim' unit type.

 

[Black-apples]

I've tested everything, and the last thing I checked was "Unpack", which caused the lag. I don't mean lag, like high ping lag, I mean lag as in he waits to finish what he's doing before he'll do the next thing.

You get all the abilities in the beginning, they're in the tactics section.

I can't find any leaks in it.



Something running in the unpack trigger is leaking or something, I don't know. As soon as you get to select your character, press unpack before anything else, you get lag. So it can't be the item types because it isn't generating any items. The point is leak proof. The only thing I could say is the loop.

 

[Mr_Bean]

Try this: base the unpack ability off channel. That way there will be 0 cast time.

 

[Bannar]

Thats right Mr_Beam - although you have to set it manually filling 'Folow through time' field to 0. Reducing uni's cast animation points can help too, but remember that it affects all the spells.

 

[Mr_Bean]

What he said!

 

[Black-apples]

Alright I fixed it, just had to make it thunderclap instead of avatar . I didn't want to change it to a channel effect.

Thanks guys

 

[Mr_Bean]

Cool, don't know why you used Avatar as the base ability though...

 

[Luorax]

What's wrong with channel? That's propably the most flexible ability out there, and it's kinda easy to use it. Once you base like 1-2 abils on it you can easily CnP them and use them once again. + You can use it as many times because you can change its base order.

 

[Black-apples]

I never really liked using channel, just an OCD thing. I've usually never encountered problems without using it until now.

I used avatar because it was a no target ability I could use, just remove all the stats from it. Never gave me lag before .