Death Star V1.2 [MUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

13:41, 11th Feb 2014
BPower:

• You have 179 locations leaks per cast.
• Stuff like lightning model, offset, effects, duration, etc should be configurable in a seperated trigger
• Why is DamageEngine imported into the demo map? It shouldn't be there
• Numbers of created effetcs could be configurable. That would require a little math to determine the correct space between the each sfx.
• Effects could be much smoother, for instance the lightinig could fade out...

 

[BPower]

- Used effects, aoe, lightning model, duration ... should be configurable
- Don't use for integer A, use a custom integer variable.
- The looping trigger is started on every cast, even if it is already enabled.
- While the effects look interesting the rest is quite boring (Sounds, ...)
- Base your spell on Channel not on Warstomp.
- Facing of unit could be saved into a variable.
- Use only one dummy to apply cripple per gamel or at least only one per cast.
- The spell requires an UnitIndexer, you might want to add that info into the description here.

Don't be discouraged those changes can be done quickly.

 

[Destination9747]

Thank you I will update it! and thank you for your tips!

 

[IcemanBo]

Custom script: call DestroyGroup(udg_DS_UnitGroup_Slow)

^Seems to be useless for me. Maybe you forgot to remove it after some changes?

Usage of loop for the lightning stuff would look bit more neat maybe, but it's just my opinion. You can do how you want.

You leak locations. Free memory only at bottom of trigger is not enough. You have to ensure you remove the location before you give a new value to the variable.

So if you set "Point = Value" and after some lines you need a new value for "Point", you must free the memory before. Doing so once at the end of trigger is not enough here.

In your loop, if you would set "DS_Caster2 = null" you could simply check if "DS_Caster2 = null" to turn off the trigger instead of counting units in unitgroup. (is faster I think)

Unit Group - Pick every unit in DS_UnitGroup and do (Actions) Schleifen - Aktionen Set DS_Caster2 = (Picked unit) If (All Conditions are True) then do (Then Actions) else do (Else Actions) 'IF'-Bedingungen DS_Caster2 == No Unit Then - Actions Trigger - Turn off (This trigger) Else - Actions Set DS_ID2 = (Custom value of DS_Caster2) If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions DS_Time[DS_ID2] >= 0.00 Then - Actions Set DS_Time[DS_ID2] = (DS_Time[DS_ID2] - 0.03) Else - Actions Lightning - Destroy DS_Lightning1[DS_ID2] Lightning - Destroy DS_Lightning2[DS_ID2] Lightning - Destroy DS_Lightning3[DS_ID2] Lightning - Destroy DS_Lightning4[DS_ID2] Lightning - Destroy DS_Lightning5[DS_ID2] Lightning - Destroy DS_Lightning6[DS_ID2] Unit Group - Remove DS_Caster2 from DS_UnitGroup Set DS_Caster2 = No unit

 

[Tank-Commander]

The star ought to be made through a loop - it'd cut down the lines of code and generally be a lot neater

I also feel that there is a lack of real effect to the spell - an object data based damage/slow/whatever is really rather simplistic and I think more could be done with the concept. Especially given how common "Star" shaped spells are.

I would suggest removing the dummy unit after it dies and prehaps recycling - You leave a lot of data floating around after the spell has ended

 

[Destination9747]

Excuse me guys, I have a problem in the spell. The first time you use it, it wont show any special effects, but next times it will. I donno what to do with it, can someone show me a way?
thank you

 

[IcemanBo]

• Set DS_Time[DS_ID] = 0.50
• Set DS_LightningModel = Drain Life
• Set DS_SpecialEffect = Abilities\Weapons\BansheeMissile\BansheeMissile.mdl

^Could be in Init trigger.

Following is maybe not needed:

• Lightning - Destroy DS_Lightning6[DS_ID2]

No need to use a unit variable here:

• Unit Group - Pick every unit in DS_UnitGroup_Damage and do (Actions)
  • Loop - Actions
    • Set DS_DamageTarget = (Picked unit)
    • Unit - Cause DS_Caster to damage DS_DamageTarget, dealing DS_Damage damage of attack type Spells and damage type Magic

"DS_Time[DS_ID2] Greater than OR equal to 0.00" -- > "DS_Time[DS_ID2] < 0" --> Change Then/Else actions

No need of 2 comparrisons if one could be enough.