DBZ:Goku Spellpack

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Moderator: Pharaoh_ Date: 20:23, 5th Jul 2012 Don't sell your resources, unless they have quality. Either upload this in its early form, which is GUI, or fix the Jass code. One spell can be executed within one trigger.

 

[defskull]

Spells should be MUI, Systems should be either MUI or MPI.
But spells, as I repeat myself, should be MUI at all time if you want to put your spell in the Spells Sections, otherwise I think that this would be either rejected or Needs Fix.

 

[zv27]

So...
This all needs to be replaced

PolarProjectionBJ
GetConvertedPlayerId
PlaySoundAtPointBJ
IsUnitAliveBJ
SetUnitFacingToFaceLocTimed
CameraSetEQNoiseForPlayer
GetHeroStatBJ
UnitDamageTargetBJ
GetUnitsInRangeOfLocAll
GetPlayersAll

with NATIVE functions

 

[defskull]

Do you think what I think ?
He's just use the "Convert To Custom Text" option in Trigger Editor ?

 

[zv27]

Do you think what I think ?
He's just use the "Convert To Custom Text" option in Trigger Editor ?

I agree with you.
Each spell has a loop trigger
This automatically confirms your theory that this is a gui converted to jass

 

[Luorax]

From what I know GUI does not use local variables - yea, I agree, once they all were GUI spells, but it's not a simple "Convert to Custom Text" button click.

Though I agree, they should be MUI, or at least MPI, shouldn't contain BadJob function calls and could be made to be way more efficient.

 

[defskull]

or at least MPI

I believed the spell is MPI (he stated it).

 

[Luorax]

Dunno if they're or not, just quickly looked at the codes and noticed the locals. I've seen a reply saying "it should be MUI or MPI" and thought they were none of them.

 

[zv27]

MUI or not but there are too many BJ functions

...whole list of them

 

[defskull]

I've seen a reply saying "it should be MUI or MPI"

I think you need to see that user's word again.

 

[Luorax]

Okay, they're MPI - are we done here?

 

[Tank-Commander]

Here's a tip: Gui lets you get away with worse codes, but even by those standards, everything has to be MUI, please read the rules before you upload these spells, otherwise you're giving moderators uneccessary work to review since it's automatically going to be rejected for breaking the rules.

 

[.VTZ.]

i saw this spell pack before
isn't that valkemiere spells?

 

[Ryro]

sorry for all my english very low
.VTZ no this my spellpack i write

 

[.VTZ.]

sorry for all my english very low
.VTZ no this my spellpack i write

but this is his models
so u should give credits to him at last

 

[maddeem]

Another badly scripted anime spell to get rejected.
This is converted gui..
Hell you can see the

//==========================

Sure he added locals, but this isn't MUI, worst of all, it uses blizzard functions. Blizzard functions are the most redundant pieces of crap known to man. Also, you have imported unit models. I could understand dummy projectile models or something, or effects. But not unit models.
Simply put...
1/5

Your effort is commendable, but I have huge bias towards anime spells. They have no place in warcraft 3.

 

[mckill2009]

pls do not insult jass standards by converting GUI-jass (Blizzard sucks on this part), if it's
in GUI so let it be, never do the convertion without knowing how it works coz it hurts many
eyes...

EDIT:
Rated: -1/5 and Vote for rejection!

 

[sonofjay]

Being bias to something is not a good thing, you just don't know but there is a site full of anime spells. I'm not a fan of anime spells on warcraft, but at least I respect it.

EDIT:

And I'm also disappointed to hear it from you maddeem.

 

[Magtheridon96]

You should be nulling the locals.
Currently, this leaks. A lot.

Also, the indentation is terrible.
If you don't feel like indenting the scripts, it's no problem, just use this: http://www.hiveworkshop.com/forums/tools.php?id=qfh1mb

In JASS, /all/ spells have one and only one trigger.
/All/ spells.

There is no need to have more than one.

 

[maddeem]

Being bias to something is not a good thing, you just don't know but there is a site full of anime spells. I'm not a fan of anime spells on warcraft, but at least I respect it.

EDIT:

And I'm also disappointed to hear it from you maddeem.

Only because every single anime spell I've seen was coded horribly.
No lie, try to find an anime spell that isn't coded badly

 

[Magtheridon96]

Even The_Reborn_Devil's Kamehameha and Baconslash spells are coded horribly.
And he's a spell moderator >_>

 

[sonofjay]

http://chaosrealm.info/topic/7722186/1/

 

[Magtheridon96]

Those GUI triggers are good, but there are some redundancies here and there (Like where he sets the group to a variable, enumerates and then destroys instead of just using the group while setting bj_wantDestroyGroup to true.
Also, he isn't caching the triggering unit in the cast trigger, which is bad.

 

[maddeem]

http://chaosrealm.info/topic/7722186/1/

Pausing units is bad coding xD

 

[defskull]

Even The_Reborn_Devil's Kamehameha...

I thought that he's making some sort of bad joke at that time releasing that spell ?
April Fool ?

 

[sonofjay]

Cause you guys are perfect that it is. If you guys are already good, why don't accept others that just starting. If you guys started as a hell of a coder good for you.

 

[defskull]

Cause you guys are perfect that it is. If you guys are already good, why don't accept others that just starting. If you guys started as a hell of a coder good for you.

Did we use any word that is related to 'insult' to the spell maker ?
We asked him to improvise by giving tips and all, we are after all trying to help him.
Instead of some people just come in here and give their piece of their mind (without actually helping the spell maker to improve)

 

[sonofjay]

Another badly scripted anime spell to get rejected.

Not really appreciated. Well yeah, protecting him and the things he loves(anime spells) will never really help him, sorry for me being a protective person,

 

[Magtheridon96]

Well, I'm trying to be helpful unlike the majority of the people in this thread. (Post #19)
Really, most people who start should be welcomed to the site and given feedback.

You shouldn't give users who just started ratings like 1/5, because they can improve their spell, and you probably won't remember to reset the rating in the future to a more approapriate one.

I wouldn't recommend rating anything with a low rating unless you are able to change the rating in the future.

If people would go against this, you might begin to find full working resources that do an excellent job at whatever they were meant to do, with 1/5 user ratings.
It would be all messed up.

 

[maddeem]

You can make all the anime spells you want in your map, but you see thats not the point. This is a public resource, and it therefore reflects the hive's reputation. If spells that leak, and aren't MUI were accepted then no one would dare download from the spell section.

Not that anime spells are bad, its just the people who create them do so in poor execution. All I did was give an honest review and give a little insight of why I don't like this particular style of coding.
Already, this spell which is coded horrendously is in the top 20. People are adding terrible leaking codes into their map...
It's tragic.

 

[Magtheridon96]

Yes, it is tragic.

It's the Hive's fault.
The current rating system is flawed.

The Top 20 should not be based on Downloads, it should be based on how much positive feedback has been given.
Users should be able to 'Thumbs up' or 'Thumbs down' a resource.
Users with higher posts and rep should be able to 'recommend' a resource.

The formula would be:

popularityIndex = (thumbsUpCount * 5) - (thumbsDownCount * 7) * recommendedCount / timeInWeeks

 

[defskull]

popularityIndex = (thumbsUpCount * 5) - (thumbsDownCount * 7) * recommendedCount / timeInWeeks

I love the constants

 

[Magtheridon96]

Me too c:
A thumbs down on a resource is something that should outweigh one thumbs up, hence the 5 and the 7 ^.^

 

[defskull]

But don't you think with that system implemented, people could just trolling/abusing it ?
Just like YouTube, when a video is nice to others, they thumbs up but even the video is godlike-ly good, there will be thumbs down (trolling or simply love doing bad things), thus could ruin the system and pretty much flawed.

 

[Magtheridon96]

Well, the current system has that flaw as well
The solution was to only allow people who comment to give a rating.

 

[Malko74]

Wow ! Really nice !!! Good job !

PS: Where can i find the rawcode of his "BFTL"
call UnitApplyTimedLife(charm,'BFTL',1)

i know for the rest but i don't find it. can you help me please ?

 

[Malko74]

uuuup