• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

Damage Engine 5.A.0.0

This bundle is marked as director's cut. It exceeds all expectations and excels in every regard.
Damage Engine

Three GUI Damage systems for the community of The Hive,
Seven vJass Damage systems for the JASS-heads on their pedestals high,
Nine competing Damage systems, doomed to die,
One for Bribe on his dark throne
In the Land of the Hive where the Workshop lies.
One Damage Engine to rule them all, One Damage Engine to find them,
One Damage Engine to bring them all and in cross-compatibility unite them.


Whether you're looking for a simple DDS (Damage Detection System), need to modify damage or even if you want a complex network of damage pre-and post-processing, this resource is for you. Damage Engine is the most adapted DDS in existence to take full advantage of the new damage detection natives, and is constantly evaluated and scrutinized by both the community and myself for performance improvements, bug fixes and new features alike.

What started with humble beginnings to bring a Unit Indexer-based version of DDS to GUI users to improve on the previous standard (at the time it was Weep's GDDS) would eventually evolve to incorporate other aspects of damage systems out there. @looking_for_help had identified an extremely useful technique with negative spell resistance being used to detect spell damage, and for a time his Physical Damage Detection system became the new standard. It wouldn't be until much later when Damage Engine would resurface and use the same technique in order to be more useful for the community.

Fast forward to 2020, and you'll find not only that cross-compatibility with Weep's and LFH's systems are incorporated, but the most popular DDS systems in existence - even vJass ones - are fully supported via stripped-down API wrappers. All of the functionality of prior DDS systems has been infused into Damage Engine 5.7, and as such the transition to a "one size fits all" DDS is complete. I hope you find this to be useful, and I also hope that it will help you in developing your map to be more dynamic what than you had previously thought possible.

Features

Legacy Code & Requirements

How it works

How to install/upgrade

Video Guides

FAQs

Thanks


  • Damage Type, Attack Type, Weapon Type, Armor Type and Defense Type detection and modification to alter/understand the fundamentals of WarCraft 3's damage processing;
  • Access to the view and change the damage amount before and/or after reduction by armor, armor type and shields.
  • Fully cross-compatible with every major DDS - vJass and GUI alike.
  • Correctly distribute/negate Spirit Link damage.
  • Differentiate between Ranged, Melee, Spell or other types of attack.
  • Does not require any Object Editor data nor Unit Indexer.
  • As of 5.4, it is now completely recursion-proof.
  • Other features:
    • Damage Blocking, reducing, amplifying and/or conversion to healing
    • Does not require you to know nor use Jass NewGen Pack nor any custom script
    • Custom DamageType association available to be set before and/or during damage event
    • Detect when multiple targets were hit simultaneously via DamageEventAOE > 1.
    • Detect when the same unit was hit simultaneously by the same source via DamageEventLevel > 1.
  • Detect damage: use the event "OnDamageEventEqual to <any value>". You have access to the following variables for reference:
    • DamageEventSource - the unit dealing the damage
    • DamageEventTarget - the unit receiving the damage
    • DamageEventAmount - the amount of damage the unit will receive
    • DamageEventPrevAmt - the amount of damage prior to being modified by the game engine.
    • DamageEventAttackT - the attack type (Chaos, Spells, Pierce, etc.)
    • DamageEventDamageT - the damage type - for comprehensive info, click here.
    • DamageEventWeaponT - the weapon type determines if an attack plays some kind of sound on attack (ie. Metal Heavy Bash). It is always NONE for spells and almost always NONE for ranged attacks.
    • DamageEventArmorT - the armor type (Flesh, Stone, Ethereal, etc.)
    • DamageEventDefenseT - the defense type (Hero, Fortified, Unarmored, etc.)
    • DamageEventArmorPierced - if DAMAGE_TYPE_NORMAL, how much armor was set to be ignored by the user.
    • IsDamageSpell, IsDamageRanged, IsDamageMelee - determine the source category of damage dealt.
    • IsDamageCode - Determine if the damage was dealt natively or by the user. This can give incorrect readings if the user has not identified to Damage Engine that it is code damage. Therefore I recommend setting NextDamageType prior to dealing damage.
    • DamageEventType - An integer identifier that can be referenced by you for whatever extra differentiation you need. You can also create your own special damage types and add them to the definitions in the Damage Event Config trigger. If you the unit should explode on death by that damage, use a damage type integer less than 0. If you want the damage to ignore all modifications, use DamageTypePure.
  • To change damage before it's processed by the WarCraft 3 engine: use the event "PreDamageEvent Becomes Equal to <any value>". Whether you just want to use one monolithic trigger for all damage modification like I do in the demo map, or use the different modifier events here, is up to you.
  • To interact with damage after it's been factored for armor and resistances, use "ArmorDamageEvent Becomes Equal to <any value>". This is typically useful for custom shields. If you fully block or absorb DamageEventAmount (setting it to 0 or less), this event doesn't run.
  • To set the DamageEventType before dealing triggered Damage, use:
    - Set NextDamageType = DamageTypeWhatever
    - Unit - Cause...
  • You can modify the following variables from a "PreDamageEvent" trigger:
    • DamageEventAmount
    • DamageEventAttackT/DamageT/WeaponT/ArmorT/DefenseT
    • DamageEventArmorPierced
    • DamageEventType
    • DamageEventOverride - You can set this if you want to remind yourself not to modify the damage further. If you use the UNKOWN damage type from a Unit - Damage Target native or set "NextDamageType = DamageTypePure" before that function, damage modification is skipped.
  • To catch a unit the moment before it would die from damage, use LethalDamageEvent Becomes Equal to 1.00. Instead of modifying the DamageEventAmount here, modify LethalDamageHP to let the system know how much life to keep the unit alive with. Or you can just reference that LethalDamageHP value in order to know how much "overkill" damage was dealt.
  • To catch a unit as soon as the damage is applied against its Hit Points, use AfterDamageEvent Equal to 1.00.
  • Usage of the "<Event> becomes EQUAL to <value>" can be extrapolated as per the below:
    • EQUAL works as it always has - will run for any damage.
    • NOT EQUAL only runs for code damage.
    • LESS THAN only runs for damage from attacks but not coded attacks.
    • LESS THAN OR EQUAL only runs for melee attacks but not coded attacks.
    • GREATER THAN OR EQUAL only runs for ranged attacks but not coded attacks.
    • GREATER THAN only runs for Spell damage but not coded spell damage.

  • Damage Engine 5 and higher requires the latest Warcraft 3 patch (currently 1.32).
  • For people who did not update their game to Reforged / have not updated to Reforged yet. Alternatively, adding the below JASS script to the top of the DamageEngine library SHOULD enable it to work too:

    JASS:
    function BlzGetEventIsAttack takes nothing returns boolean
         return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
    endfunction
  • I have created a Pastebin for all information pertaining to Damage Engine 3.8, including the link to download it, via: Damage Engine 3.8.0.0 | HIVE.
  • As of 20 June 2020, JNGP users who are still on WarCraft 3 1.26 can benefit from Damage Engine 3A, which integrates many of the design choices added in various stages of Damage Engine 5. This is a special update which only requires the JASS script be replaced (no new GUI variables added). Can be found here: Damage Engine 3A.0.0.0 and 3.8.0.0 | HIVE

1
Unit attacks or casts a spell. The pure damage is assessed at this point - damage dice, evasion, critical strike. There is currently no event to affect or modify these at source.
→ →
2
The projectile or weapon hits the target unit
→ →
3
EVENT_UNIT_DAMAGING is fired before any modifications to the damage are made.
→ ↓
↓ ←
6
User changes to DamageEventAmount and/or to DamageEventDamageT/AttackT/WeaponT are saved into the WC3 engine.
← ←
5
If any recursive damage is detected from any of those events, it is postponed and the current damage will continue first.
← ←
4
Damage Engine deploys the PreDamageEvent
7
WarCraft 3 processes the user damage.
→ →
8
WarCraft 3 then distributes the user damage into Spirit Link (before armor)
→ →
9
WarCraft 3 runs any interrupting events, such as spirit link or defensive damage like Thorns Aura
→ ↓
↓ ←
12
The EVENT_UNIT_DAMAGED event runs. This is the original event we have always had access to. Damage Engine will either keep using the original variables from the DAMAGING event, or if there was Spirit Link/defensive damage it will freshly retrieve the event values from WC3 and only retain DamageEventPrevAmt.
← ←
11
Once any potential recursive WarCraft 3 damage is processed, the armor/mana shield modifications to the damage are performed.
← ←
10
If such events such as Spirit Link were detected, they fire their own EVENT_UNIT_DAMAGING & EVENT_UNIT_DAMAGED, and DamageEngine processes it along the way for the user.
13
If the damage is above zero, ArmorDamageEvent will run. If any recursive damage is detected, it is postponed.
→ →
14
The user can make modification to the damage here with the after-damage amount.
→ →
15
The user can access DamageEventPrevAmount if they want to know the damage amount before user changes/WarCraft 3 changes.
→ ↓
↓ ←
18
The user can specify whether or not to change LethalDamageHP in order to stop the unit from dying.
← ←
17
If the damage is still above zero, check if the damage is lethal. If so, run LethalDamageEvent 1.00. If any recursive damage is detected, it is postponed.
← ←
16
If the user wants the value that DamageEngine used to have with DamageEventPrevAmt (after WarCraft 3 processing but before user changes) they multiply DamageEventPrevAmt x DamageScalingWC3.
19
Once all modification is done, run OnDamageEvent. If any recursive damage is detected, it is postponed.
→ →
20
After a new damage instance is detected, or the 0.00 timer expires, run AfterDamageEvent. If any recursive damage is detected, it is postponed.
→ →
21
Run all potential recursive Unit - Damage Target function calls in chronological order (first in, first out).

How to install Damage Engine:
  1. Use WarCraft 3 Version 1.32
  2. If you're upgrading from 3.8 or prior, please delete the entire "Damage Engine" category from your map.
  3. Copy & Paste the Damage Engine category from the attached map to your own map.
How do I upgrade to the latest Damage Engine?
- Depending on the complexity, you'll either need to re-copy the Damage Engine category or just the Damage Engine script. Generally, you can use this as a guide:

  • Damage Engine _._._.x - only requires copying of the JASS script
  • Damage Engine _._.x._ - generally only needs copying of the JASS script, but read the patch notes in case there are changes you may want to make to your own code in order to utilize the changes.
  • Damage Engine _.x._._ - delete your current Damage Engine category or manually add the missing variables to your Variable Editor, and update your JASS script.
  • Damage Engine x._._._ - this occurs very infrequently. Typically requires changes to the way Damage Engine needs to be installed and used.

Notes about upgrading from Damage Engine 4.0 or prior:
  • Revert any custom Object Editor changes made (such as Life Drain reversal, Spell Damage Reduction inversion, etc).
  • You can safely delete the custom spells "Spell Damage Detection" and "Cheat Death Ability"
  • You can delete the Unit Indexer trigger if you do not use it or would prefer to use a different indexer.
  • You should delete any "Mana Shield fix" or "Finger of Death fix" you may have imported, as well as revert any Object Editor data that was required to make it work, as these are no longer needed.
  • !!!DEPRECATED FEATURE!!! As of 5.4, do not bother to take any recursive damage mitigation - Damage Engine will now handle all of that for you!
  • !!!DEPRECATED FEATURE!!! Do not use "ClearDamageEvent" - it does nothing. Just delete it.
  • !!!DEPRECATED FEATURE!!! Do not use "NextDamageOverride" - set NextDamageType = DamageTypePure instead.
  • !!!CHANGED FEATURE!!! If the system detects code damage and the user did not specify it as any particular DamageEvenType, the system will assign it DamageTypeCode automatically.
  • !!!CHANGED FEATURE!!! DamageModifierEvent 1.00-3.00 now run prior to armor reduction. This enables the user to modify the damage before armor and resistance changes are applied - also before Mana Shield and Anti-Magic shell kick in, so no more need for special triggers.


  • Q: Why am I getting a bunch of 'trigger was disabled' errors when I save my map?
  • A: This issue is not unique to Damage Engine, but to all vJass resources. Blizzard has taken the very confusing decision to make JassHelper 'disabled' by default, meaning that every new map that uses a vJass resource has to manually enable JassHelper. Please see this thread if you want to know where to find the Enable JassHelper option.
    .
  • Q: How can I detect when a unit gets damaged?
  • A: Create a trigger with the event: "Game - Value of Real Variable <DamageEvent> becomes Equal to 1.00".
    • Use the following custom variables to reference the event responses:
      • DamageEventSource - the unit dealing the damage
      • DamageEventTarget - the unit getting damaged
      • DamageEventAmount - how much damage is being dealt
      • DamageEventAttackT - which attack type was used by DamageEventSource to damage DamageEventTarget
      • DamageEventDamageT - which damage type was used to damage the target (ie. UNIVERSAL for ultimate damage, or NORMAL for damage that gets reduced by armor).
      • DamageEventDefenseT - which defense type does the target unit have (ie. Hero, Fortified, Unarmored).
      • DamageEventArmorT - which armor type does the target unit have (ie. Flesh, Ethereal, Stone).
      • DamageEventPrevAmt - what the value of the damage was before being modified by armor, ethereal/item bonuses or user changes.
        .
  • Q: How do I modify the damage that is dealt to a unit?
  • A: Create a trigger with the event: "Game - Value of Real Variable <PreDamageEvent> becomes Equal to <any value>".
    • You can change the following variables to affect the damage that will be dealt:
      • DamageEventAmount - how much damage will be dealt (before armor reductions)
      • DamageEventAttackT - which attack type will be used by DamageEventSource to damage DamageEventTarget
      • DamageEventDamageT - which damage type will be used to damage the target.
      • DamageEventDefenseT - which defense type should the target unit have during this attack.
      • DamageEventArmorT - which armor type should the target unit have during this attack.
      • DamageEventArmorPierced - how much armor value to ignore when dealing this damage (applies to DAMAGE_TYPE_NORMAL only, otherwise all armor is ignored).
        .

  • Q: How do I deal Pure damage to a unit (bypassing armor/skipping user modification)?
  • A: Use the following actions:
    • Set NextDamageType = DamageTypePure
    • Unit - Cause Source to damage Target for Amount using attack type Spells and damage type Universal
      .

  • Q: How do I protect against recursive damage?
  • A: Damage Engine 5.4 and above is completely recursion-proof, using vJass hooks to detect registered Damage Event triggers.
    .

  • Q: I've been using <insert Damage system here>. Can I use those with Damage Engine?
  • A: Better - Damage Engine has integrated cross-compatibility with all other approved Damage systems and even the major ones from outside of Hiveworkhop.
    .

  • Q: Can I cause an attack to 'Miss' its target?
  • A: Kind of. Ranged attacks will still explode on the target, and on-hit effects will still apply, but you can do the following:
    • Use the event "PreDamageEvent becomes Equal to 1.00"
    • Use the following actions:
      • Set DamageEventAmount = 0.00
      • Set DamageEventArmorT = ARMOR_TYPE_NONE
      • Set DamageEventWeaponT = WEAPON_TYPE_NONE
    • Setting the weapon type and armor type to none like the above will stop any on-hit sounds from playing. When the Peasant attacks in the demo map, this is the trick I'm using. Instead of saying "MISSED!" I have the Floating Text saying "FAIL!" because - again - it's not exactly a "miss".

Thank you to Blizzard for continuing to work on this amazing game to give us awesome new natives that have the best possible control over incoming damage. Damage Engine brings that power to GUI. Also, a very special thank you to @KILLCIDE for getting me motivated to start up the 5.0 project in the first place.

Thank you to the users of this system who have helped me mold this project into the stable, powerful form it is in today!

For versions 3.8 and prior:

Thank you @looking_for_help for finding the spell damage detection method used in Damage Engine 3 - it was the greatest find since the undefend bug.

Thanks to Jesus4Lyf and @Nestharus for building the inspiration that originally led me to create DamageEngine.

Thank you Wietlol and looking_for_help for challenging me on this project to integrate solutions to problems I had not been made aware of, such as the importance of an After-Damage Event.

Thanks to @Spellbound for several crucial bug reports.


Damage Engine Config

Damage Engine vJass

Damage Engine Lua

Changelog


  • Damage Engine Config
    • Events
      • Map initialization
      • Game - DamageModifierEvent becomes Greater than 0.00
      • Game - LethalDamageEvent becomes Less than or equal to 0.00
      • Game - DamageEvent becomes Not equal to 0.00
      • Game - AfterDamageEvent becomes Less than 0.00
      • Game - AOEDamageEvent becomes Greater than or equal to 0.00
      • Game - SourceDamageEvent becomes Equal to 0.00
      • Game - PreDamageEvent becomes Equal to 0.00
      • Game - ArmorDamageEvent becomes Equal to 0.00
      • Game - ZeroDamageEvent becomes Equal to 0.00
    • Conditions
    • Actions
      • -------- You can add extra classifications here if you want to differentiate between your triggered damage --------
      • -------- Use DamageTypeExplosive (or any negative value damage type) if you want a unit killed by that damage to explode --------
      • -------- - --------
      • -------- The pre-defined type Code might be set by Damage Engine if Unit - Damage Target is detected and the user didn't define a type of their own. --------
      • -------- "Pure" is especially important because it overrides both the Damage Engine as well as WarCraft 3 damage modification. --------
      • -------- I therefore gave the user "Explosive Pure" in case one wants to combine the functionality of the two. --------
      • -------- - --------
      • Set VariableSet DamageTypePureExplosive = -2
      • Set VariableSet DamageTypeExplosive = -1
      • Set VariableSet DamageTypeCode = 1
      • Set VariableSet DamageTypePure = 2
      • -------- - --------
      • Set VariableSet DamageTypeHeal = 3
      • Set VariableSet DamageTypeBlocked = 4
      • Set VariableSet DamageTypeReduced = 5
      • -------- - --------
      • Set VariableSet DamageTypeCriticalStrike = 6
      • -------- - --------
      • Custom script: call DamageEngine_DebugStr()

BribeFromTheHive/DamageEngine

Lua 1.0.2.3 - Fixed to match adjustment made in vJass version 5.4.2.3.
Lua 1.0.2.2 - Fixed to match adjustment made in vJass version 5.4.2.2.
Lua 1.0.2.1 - Fixed to match adjustment made in vJass version 5.4.2.1.
Lua 1.0.2.0 - Added support for Lua Fast Triggers ([Lua] Ridiculously Fast Triggers). Fixed an issue where the AfterDamageEvent wasn't always timed the correct way like it was in the JASS verion.
Lua 1.0.1.0 - Fixed encapsulation issue and recursion issue with DamageEngine_inception. Now hooks UnitDamageTarget.
Lua 1.0.0.0 - Release based on Damage Engine 5.4.2.0

5.9.0.0 - Added the following clearer event names to make things less confusing for new users:
  • PreDamageEvent - can be used in place of DamageModifierEvent pre-armor modification
  • ArmorDamageEvent - can be used in place of DamageModifierEvent post-armor modification
  • OnDamageEvent - can be used instead of a non-zero DamageEvent
  • ZeroDamageEvent - can be used instead of a zero damage DamageEvent
  • SourceDamageEvent - runs at the same time as AOEDamageEvent, but doesn't need to hit multiple units.
Added "DamageFilterRunChance" - odds for the trigger to BE run (works inversely to DamageFilterFailChance).
Shortened the Configuration trigger so that it focuses primarily on what the user can modify.
Organized all variables into categories to help users better understand what does what.
Installation or updating from a previous version will require re-copying the entire Damage Engine folder.
Updated the demo map's text tag production to include a new custom update for ArcingTextTag, thanks to @Ugabunda and @Kusanagi Kuro.
Side note - the Demo Map's triggers have been heavily cleaned up and will now no longer cause crashes when being imported into a new map.
5.8.0.0 -
  • Added a new functionality to the AOEDamageEvent, which allows it to fire even when only one unit is hit, if the AOEDamageEvent is registered as "Not Equal" instead of "Equal to". This is useful in a very specific scenario where an AfterDamageEvent may not be able to be relied upon to properly deallocate data from a running instance that needs to be able to function when multiple units are hit, but also needs to not fail when only one unit is hit.
  • Added additional filters for GUI users to avoid using trigger conditions in even more scenarios:
    • DamageFilterSource/TargetI (has item)
    • DamageFilterSource/TargetA (has ability)
    • DamageFilterSource/TargetC (has a certain classification, like hero or Tauren)
    • DamageFilterFailChance - odds for the trigger to not be run (ideal for critical strike or evasion)
  • Provided a way for GUI to un-register a Damage Event by setting "RemoveDamageEvent" to true from within their trigger's actions.
  • Moved the CreateTimer/CreateTrigger/CreateGroup calls that had been included in the globals block down to the onInit block as per request of @Ricola3D
  • Minor performance improvements thanks to @BLOKKADE
5.7.1.2 - Fixed an issue with armor penetration sometimes bugging out.
5.7.1.1 - Fixed an issue with the eventFilter not retaining its value during an AOE event. Fixed an issue with eventFilter when USE_MELEE_RANGE was set to false. Both issues reported by @lolreported
5.7.1.0 -
I have fixed several potential points of failure reported by multiple users that stopped Damage Engine from working for the rest of the game. In any case there should no longer be ANY SITUATION where Damage Engine just "stops working", even in ways I can't predict. The most likely issue was with DamageScalingWC3/User having possible 0-division errors.​
Fixed the "configured" issue reported by @lolreported where manual configuration didn't work unless the damage and attack type checks were initialized tto -1.​
In addition to these fixed bugs, I have added several more static ifs so that advanced users have more control over getting rid of features they might not care about.​

5.7.0.3 - Fixed the issue reported by @KitsuneTailsPrower wherein the DamageInterface extension wasn't working. This needed to be fixed both in the Damage Engine source as well as the DamageInterface plugin itself.
5.7.0.2 - Fixed the issue reported by @Wazzz where the armor reduction wasn't taken into consideration. Actually there was a much bigger flaw that I had overlooked that was prompting this.
5.7.0.1 - Improved the logic of the 0 damage event.
5.7.0.0:

  • Usage of the "DamageEvent becomes EQUAL to 1.00" now can be extrapolated further than ever before:
    • EQUAL works as it always has.
    • NOT EQUAL only runs for code damage.
    • LESS THAN only runs for damage from attacks.
    • LESS THAN OR EQUAL only runs for melee attacks.
    • GREATER THAN OR EQUAL only runs for ranged attacks.
    • GREATER THAN only runs for Spell damage.
  • Fully adapted Damage Engine to work with every other major DDS
  • Rewrote the internal script to use vJass structs: Damage and DamageTrigger.
  • Changed some of the vJass API. You can find the API listed in the Damage Engine trigger. Notably:
    • I removed UnitDamageTargetEx. You can replace this with Damage.apply.
      • The reason for this change is because of cross-compatibility. Rising Dusk's IDDS uses a different set of parameters for this function, so I removed it from my library to allow this to work seamlessly.
    • TriggerRegisterDamageEvent -> TriggerRegisterDamageEngine
    • RegisterDamageEvent -> RegisterDamageEngine
      • The reason for the above two changes is, like for UnitDamageTargetEx, because Rising Dusk's IDDS uses them. I don't want to make the same mistake I did with Table's API and preferred to walk back my API choices before things got out of hand again.
  • Various performance tweaks, bug fixes and re-commenting of variables.
  • Recursive damage is now processed more intelligently and possibly be more performance-friendly.
  • Adapted the cross-compatibility libraries for Weep and LFH's systems to use textmacros to insert themselves into Damage Engine (this might have been in the 5.6 update, but these two updates were both tailored to achieve similar goals).
5.6.2.0 - Fixed a bug with Damage modification and laid groundwork for a bunch of optional vJass compatibility addons.
5.6.1.0 - Patchwork on Melee/Ranged detection, recursion tracking. Also added the ability to modify damage from a DamageEvent to make it easier on beginners.
5.6.0.1 - Fixed an issue where the DamageEventType for recursive damage that used NextDamageType would always default to DamageTypeCode.
5.6.0.0
Rewrote a significant amount of the internal code so that struct and GUI syntax both work - and are synchronized with each other. vJass-exclusive users can disable the GUI synchronization if they don't use any GUI damage events in their maps.​
Four new variables must be added to your variable editor:​
  • boolean NextDamageIsAttack
  • boolean NextDamageIsMelee
  • boolean NextDamageIsRanged
  • integer NextDamageWeaponT
Struct syntax should not need too much introduction - Damage.index is the triggering event ID, and the syntax is Damage.index.amount/source/target/etc. To initialize a JASS damage event, use:​
JASS:
function RegisterDamageEvent takes code c, string eventName, real value returns nothing
The string is simplified: "Modifier", "" (for simple DamageEvent), "After", "Lethal", "AOE"​
Finally, a neat QOL improvement is that I have assigned weight to each of the events. When registering an event, you can include numbers different than 1, 2, 3 or 4 (for modification) or just the plain "1" for the others. Now you can set your own sequencing and use 1.5, 3.14 or even -1 to give an even more extreme priority to something. Lower numbers run first, higher ones last.​
5.5.0.0 - Added support for the new native BlzGetEventIsAttack via "IsDamageAttack". Also updated the Config trigger to make importing a bit easier
5.4.2.3 - Fixed a mis-flag of the IsDamageSpell value when not being actual spell damage.
5.4.2.2 - Actually fixed the Cold Arrows issue (division by 0.00001 or something ...somehow... either way, it is fixed).
5.4.2.1 - A fix which should hopefully quell the recent reports of damage events failing in complex situations involving Cold Arrows.
5.4.2.0 - A ton of fixes to repair the issues plaguing Sunken City and anyone else who might be pushing this engine well beyond what I imagined it would be used for. Also added a couple of variables intended to be used to ricochet damage: CONVERTED_ATTACK_TYPE and CONVERTED_DAMAGE_TYPE. Check the demo map for how they can be used in a Unit - Damage Target action.
5.4.1.0 - The "Inception" update. Advanced users can interact with Damage Engine via custom script to set DamageEvent_inception = true to allow their damage to potentially go recursive (to a fixed extent).
5.4.0.1 - Hotfixed that modifiers 2 and 3 weren't running.
5.4.0.0 - By using an innovative approach of hooking TriggerRegisterVariableEvent, I've permanently eliminated all risks of recursion in the engine.
5.3.0.1 - Fixed unexpected behavior with DamageTypePure when it is affected by Anti-Magic Shell or Mana Shield. DamageTypePure now no longer ignores DamageScalingWC3.
5.3.0.0 - Fixed an issue with AfterDamageEvent sometimes being delayed. Added DamageScalingUser to track the ratio of user modified damage, as well as DamageEventArmorPierced which allows the user to define how much armor to ignore when working with DAMAGE_TYPE_NORMAL.
5.2.0.1 - Fixed an issue where with the final unit in a Spirit Link chain or the retaliating damage of Thorns/Carapace would not deploy an AfterDamageEvent. Also fixed an issue where AfterDamageEvent would still fire from DAMAGE_TYPE_UNKNOWN if it was greater than 0. Simply copy over the JASS from this post in order to update your own implementation.
5.2.0.0

  • Now features DamageEventArmorT and DamageEventDefenseT, which pull from the target unit's Object Editor data in order to allow you more complete access to detect and even MODIFY those defenses. Changes must be made in a DamageModifierEvent, and they are reverted as soon as armor is calculated.
  • Re-introduced AfterDamageEvent, which is the moment after the unit's life is changed, but before any recursive damage has run.

5.1.3.1 - Bug fixes and performance improvements. No, really. Fixed an issue with the DAMAGED event running even though it was turned off (who would've guessed that?)
5.1.3.0 - Engine re-tooling to improve accuracy and get Spirit Link/Defensive damage out of hardcoded mode - it will now work even in circumstances I haven't tested for (in case those weren't the only issues). Also fixed the Is Unit Moving resource.
5.1.2.1 - Fixed an issue with Spiked Carapace and Thorns Aura where the melee attacker would not get recorded correctly. This required the same fix as I needed to apply for the initial target in a spirit link chain.
5.1.2.0 - Tweaked recursion and fixed a few bugs. Re-introduced the zero damage event now that patch 1.31.1 brought it back.
5.1.1.1 - Minor tweak to Spirit Link in rare situation.
5.1.1.0 - Fixed issues related to Spirit Link. Now works intuitively as expected.
5.1.0.0 - Crazy improvements - check out the details in "How to upgrade from Damage Engine 4.0 or earlier" and "How to use Damage Engine 5.1"
5.0.0.0 - Oh man. Where do I even start?
  • You can now set/compare DamageEventDamageT, DamageEventAttackT or DamageEventWeaponT
  • No longer needs Unit Indexer nor any custom Object Editor data nor modifications.
  • Requires WarCraft 3 1.31 or higher.
  • Changed vanilla JASS code to vJass to clean up a lot of things such as making certain variables private.
  • Look for more details in "How to upgrade from Damage Engine 4.0 or earlier"

4.0.0.0 - Never officially released, but was the first iteration which used SetEventDamage.
For 3.8.0.0 and prior, see: Damage Engine 3.8.0.0 | HIVE


Cross-Compatibility:

BribeFromTheHive/DamageEngine

Keywords:unit indexer, damage detection, damage event, weep, nestharus, looking_for_help, EVENT_PLAYER_UNIT_DAMAGED, damage engine, spell, physical, EVENT_PLAYER_UNIT_DAMAGED, attacktype, damagetype, weapontype, armortype, defensetype, BlzSetEventDamage
Previews
Contents

Damage Engine Demo Map (Map)

Lua Damage Engine 2.0.0.0 (Map)

Reviews
23:20, 11th Jan 2015, BPower Criticism: On the one hand Damage Engine offers extremely high utility to every spell, system and map maker independent of the coding style ( GUI, JASS, vJass, .... ) on the other hand it's very easy to import and...
Level 23
Joined
Jun 26, 2020
Messages
1,838
Bribe can you help me? This situation seems irrational for me.

I gave a tinker a standarb blizzard ability to turn him into tank. So when the damage is dealt (in the event udg_damagemodifierevent equal 1.00) he gets 40% less magic damage

the condition is
JASS:
if udg_IsDamageSpell == true then
local integer targettype = GetUnitTypeId(udg_DamageEventTarget)
  if targetype == 'Nrob' then
   call echo("work blcok")
 set udg_DamageEventAmount = udg_DamageEventAmount * 0.6
 endif
endif
but the debug message do not respond, and so is the damage dont get reduced.
I used to think that his id somehow remain as normal one, but no, in other triggers checking for unit type id works fine.
Wait, is your actual code? Because in Jass you can only define local variables in the top of the function body.
 
Level 2
Joined
Dec 30, 2021
Messages
6
Delete Unit Indexer. Unit Event replaces Unit Indexer.
Dear Bribe, thanks your for reply me.
I did as you said.
I use lua version, in Lua Damage Engine 2.0.w3x, I'm only delede Unit Indexer Forder and copy all Trigger Forder ( 6 Folder) in Lua Unit Event.w3x (Debugging Utils, Required Libraries, Unit Event, Variables, Other Libraries, Example Tests). After I'm press Ctrl F9, warcraft run normal, no crash to destop, but in game, it always show like: I was check all udg: udg_DamageEventSource,udg_DamageEventTarget .... it not deleted or missing. Can you fix it for me? Thanks.
(Edit) I know that bug, It is GlobalRemap, Lua Damage Engine 2.0.w3x use Global Variable Remapper v1.0.1.1, Lua Unit Event.w3x use Global Variable Remapper v1.3, when I disable v1.0.1.1 Lua Damage Engine 2.0.w3x run but Lua Unit Event.w3x not run, when I disable Global Variable Remapper v1.3. Lua Damage Engine 2.0.w3x not run but Lua Unit Event.w3x run, how fix?
(Edit2 ) nevermind, I change Damage Engine (if Hook and Timed then--> if Timed then, hook.addsimilar --> AddHook) and change Variable Remapper v1.3(print("Trying to read undeclared global: "..tostring(index)) --> --print("Trying to read undeclared global: "..tostring(index))), and change 'A000','A001' in Lua Unit Event.w3x --> 'A001','A002'. It work!
(Edit3 ) Lua Unit Event.w3x when save and load this save, function can't display the unit name of unit event
 

Attachments

  • Untitled-1.jpg
    Untitled-1.jpg
    475.8 KB · Views: 14
  • Lua Damage Engine 2.0 Lua Unit Event.w3x
    171.3 KB · Views: 1
Last edited:
Level 4
Joined
Jul 13, 2012
Messages
86
Does anyone have past versions of Damage Engine, specifically 5.5.0.0. My map is currently on 5.4.2.3 but I need the IsDamageAttack functionality and I don't like using the latest version as it makes my map lag cuz older versions are more lightweight than current one (from 600 lines to 1800 lines).
 
Level 2
Joined
Feb 12, 2024
Messages
13
I'm using the 3.8 version because I have old WC3. I have a problem.

Damage detection does not work on every units that already in the map at the map start.

It works fine with units that spawn into the map later.

How to fix this?
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
I'm using the 3.8 version because I have old WC3. I have a problem.

Damage detection does not work on every units that already in the map at the map start.

It works fine with units that spawn into the map later.

How to fix this?
That is weird. Sounds like a configuration problem with Unit Indexer. Do you have other unit indexers in your map?
 
Level 2
Joined
Feb 12, 2024
Messages
13
1707887674167.png


this is not my map btw. The creator share unprotected version of it. I like adding my own hero to the map and play it alone.

red circle is your damage engine. blue circle is the system that is installed to the map already. It is vJass. Sadly I don't have any knowledge about vJass so I can not edit it or even understand it 😢

I have tire to remove the Intuitive Damage System but it make me can not save my map and show multiple error messages.

I attached the map file here If you would do me a favor to edit the vJass code.



I have another question. In the Latest version of DMG Engine. It have IsDamageSpell, IsDamageRanged, IsDamageMelee. but in the 3.8 version which I use. there only have IsDamageSpell . Are there anyway to specifically detect melee and ranged for this version?
 

Attachments

  • EotA_Exodus_GagInw_Edited.w3x
    6.1 MB · Views: 1

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
Level 2
Joined
Feb 12, 2024
Messages
13
I can't find the 3A version file only 3.8 version. I tried delete the text in 3.8 version and replace it with this:
1708005754257.png


after save the map. it show error like these:

1708005656666.png

1708005681315.png
 

Attachments

  • 1708005511171.png
    1708005511171.png
    67.1 KB · Views: 5

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
You have to edit the custom script of Omnislash and replace the occurrences of the keyword "Damage" with a different namw, even just changing it to lowercase will fix that problem.

You will probably want to learn a little bit about code if you intend to make any further modifications besides just copy+pasted systems.
 
Level 2
Joined
Feb 12, 2024
Messages
13
You have to edit the custom script of Omnislash and replace the occurrences of the keyword "Damage" with a different namw, even just changing it to lowercase will fix that problem.

You will probably want to learn a little bit about code if you intend to make any further modifications besides just copy+pasted systems.

I replaced all the "Damage" with "damage" and it work fine. and then I replace the IntuitiveDamage with your Rising_Dusk's IDDS.j code. and it show error like this.
1708061041799.png


I will properly learn about code after I can fully install your engine to the map like you said if I want to create my own advance spell :hohum:
 
Level 2
Joined
Feb 12, 2024
Messages
13
I replaced all the "Damage" with "damage" and it work fine. and then I replace the IntuitiveDamage with your Rising_Dusk's IDDS.j code. and it show error like this.
View attachment 461970

I will properly learn about code after I can fully install your engine to the map like you said if I want to create my own advance spell :hohum:
I tried so many thing and I find this error happens because it is for 5.A version which can detect Normal Attack but I don't sure. So I tried delete these lines:
1708164310929.png


but it cause more multiple errors. So I will buy a reforge version and update my wc3 to latest version. Install the 5.A version and see that Error will be persist or not. IF the errors gone. I will finally make my dream spell.
 

Uncle

Warcraft Moderator
Level 63
Joined
Aug 10, 2018
Messages
6,457
I tried so many thing and I find this error happens because it is for 5.A version which can detect Normal Attack but I don't sure. So I tried delete these lines:
View attachment 462031

but it cause more multiple errors. So I will buy a reforge version and update my wc3 to latest version. Install the 5.A version and see that Error will be persist or not. IF the errors gone. I will finally make my dream spell.
You do NOT need to buy Reforged to play on the latest version. Simply install the game on the BNET app using your old cd key and you'll be able to play with everyone else, you just can't use the HD graphics.
 
Level 5
Joined
Nov 3, 2018
Messages
74
is it possible to identify Which spell is the damage source? (i have a hero with 3 spells and i want only one of those spells to work with a damage modifier not all of em)
in GUI
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
is it possible to identify Which spell is the damage source? (i have a hero with 3 spells and i want only one of those spells to work with a damage modifier not all of em)
in GUI
In Damage Engine 5, you have access to the DamageEventDamageT, and the following guide can be useful if there are no overlapping damage types with your hero's spells:

 
Level 5
Joined
Nov 3, 2018
Messages
74
I Upgraded to damage engine 5 but... i get thousands of errors (syntax errorts) , got last warcraft version and eys i did follow the instructions plus have the paste unknown variables on
1708651490091.png

1708651434743.png


i even tried making an empty map and copying the damage engine folder then configuring it and i'm getting the exact same error
 

Uncle

Warcraft Moderator
Level 63
Joined
Aug 10, 2018
Messages
6,457
I... didn't even knew that was a thing i just upgraded to reforged and i never noticed that :peasant-neutral: , i was struggling for like 2 hours googling for a solution yet it was so simple

thank you so much man you have no idea how much i appreciate it so much man! :cry:
No problem, it used to be enabled by default but Reforged is... You know.
 
Level 2
Joined
Feb 12, 2024
Messages
13
Is there anyway to access IntuitiveDamageSystem created by Rising_Dusk ? the wc3.net link is dead. I just want to see its demo Jass code.
because I'm editing other's abandon map which have the system in it but have no demo Jass code. I'm learning Jass but still a beginner so I want some example to edit it myself.

(I want to make a buff that make unit take more damage from all source and all Damage Type)
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
Is there anyway to access IntuitiveDamageSystem created by Rising_Dusk ? the wc3.net link is dead. I just want to see its demo Jass code.
because I'm editing other's abandon map which have the system in it but have no demo Jass code. I'm learning Jass but still a beginner so I want some example to edit it myself.

(I want to make a buff that make unit take more damage from all source and all Damage Type)
Best case there is to just use Damage Engine natively, rather than using a special modification of Rising Dusk's system. But you can always check archive.org.
 
Level 5
Joined
Nov 3, 2018
Messages
74
is there a limit on how many damage events we can track for a single unit?
like about 10 different triggers each tracking when the unit takes damage and doing something
 

Uncle

Warcraft Moderator
Level 63
Joined
Aug 10, 2018
Messages
6,457
is there a limit on how many damage events we can track for a single unit?
like about 10 different triggers each tracking when the unit takes damage and doing something
No, but there's a few things to think about:

Damage recursion: This concept is about dealing damage in response to a Damage Event. The problem is that this could create an infinite loop and crash the game. I believe Damage Engine tries to prevent this from happening but it has a limit. You probably want to stay on top of this yourself.

Order of calculations: The final amount of damage taken can differ based on the order of calculations. For example, applying flat damage reduction before percentage damage reduction will be less effective than doing it in the reverse order. Let's say your unit takes 10 damage and has 50% damage reduction and 5 flat damage reduction. See below how the outcome changes based on what gets applied first:

Flat > Percentage:
10 - 5 = 5
5 * 0.50 = 2.5 damage taken

Percentage > Flat:
10 * 0.50 = 5
5 - 5 = 0 damage taken

So you probably want to manage this order and control the outcome of your damage calculations.

Efficiency: Less triggers/events is generally going to be more efficient and perform better. But I wouldn't worry about this too much, especially if you struggle with it, it's not like it'll cause something to break. This comes with the territory of ordering your damage calculations, as you may end up with one central trigger setup to handle all of your different damage events.
 
Last edited:
Level 5
Joined
Nov 3, 2018
Messages
74
Apprently this mod is crashing with New Bonus [vJASS][LUA] the only way for making them work together seems to either
1 remove damage interface taking away quite a bunch of functions from newbonus
or
2 changing names (i just did that for about 30 minutes and got nothing sadly) it is odd that these two popular systems are not compatible with eachother
or is there a workaround that i'm not aware of?
(this capture is from using the example map and importing the newbonus system)

1709027789352.png
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
You have to delete damage interface and replace it with the aforementioned API that makes it use Damage Engine instead.

Damage Engine does everything the other damage systems do, so if you delete it and use whatever wrapper for them (they are all on my GitHub) then you should expect compatibility with those implementations alone.
 
Level 5
Joined
Nov 3, 2018
Messages
74
You have to delete damage interface and replace it with the aforementioned API that makes it use Damage Engine instead.

Damage Engine does everything the other damage systems do, so if you delete it and use whatever wrapper for them (they are all on my GitHub) then you should expect compatibility with those implementations alone.
Hey there bribe , thanks a lot for replying so fast! so i went and checked the github crosscompatibility section and there's these two
1709053226499.png

after replacing the damage engine interface and the evasion .j the error appears in the other utilities , taking a wild guess... the github was updated (4 years ago and new bonus update being 1 year ago)
i assume these are new and thefore that crosscompatibility section may be outdated?
1709053475453.png
 
The way I see it in this version:
New Event
Old Event Equivalent
PreDamageEvent 1.00DamageModifierEvent 1.00
ArmorDamageEvent 1.00DamageModifierEvent 4.00
OnDamageEvent 1.00DamageEvent 1.00
  • The remaining events such as ZeroDamage, LethalDamage, AfterDamage are self-explanatory.
  • In the new events, comparison signs (<>= etc.) work the same way as in older 5.9 version to denote detection of Attack/Spell/Code damage.
  • In the new events, only real value of 1.00 is needed for a correct syntax of damage detection event.
Please correct me if I'm wrong in any parts above.

Btw, if I used "DamageModifierEvent 1.00" - "DamageModifierEvent 2.00" - "DamageModifierEvent 4.00" for sequential handling of a damage event in the old engine (1 -> 2 -> 4), will "PreDamageEvent 1.00" - "DamageModifierEvent 2.00" - "ArmorDamageEvent 1.00" maintain the same sequence?
 
Level 2
Joined
Feb 12, 2024
Messages
13
I tried remove the Intuitive Damage System folder entirely. and Tried install the 3.8 version and the problem still persists. units that already in the map will not work with the damage system. So I remove the 3.8 version and install the 3.A version but Again, the problem still persists.

I disable all the trigger that require Damage Intuitive System so when I save the map with 3.8 or 3.A Damage engine. There is no any error message.
 
Level 9
Joined
May 24, 2016
Messages
297
Is there a way to fix it in in 3A.0.0.0 version? I encountered a bag. If you use mass damage group recycle once the target is damaged (in my case - that happens under certain conditions), and THEN damage the SAME units second time, the damage is ignored completely for all units in group.

Maybe I just did it messy, that's why something is wrong. The other function except for mass damage work fine though

JASS:
if IsUnitInGroup(udg_DamageEventSource,Zeal_Casters) then // ZEAL STUN + DAMAGE

call GroupRemoveUnit(Zeal_Casters,udg_DamageEventSource)
//call UnitRemoveAbility(udg_DamageEventSource,'A00J')

if GetInventoryIndexOfItemTypeJ(udg_DamageEventSource, 'I003') > 0
//set B = Condition(function MaelstormPal_Expr)
set g = CreateGroup()
//call GroupClear(P)
call GroupEnumUnitsInRange(g,targetx,targety,250,B)
          loop
          set d = FirstOfGroup(g)
          exitwhen d ==null
          if UnitTypeNotDummy(d) and not IsUnitDead(d) and IsUnitEnemy(d,Player(0)) then
          call UnitDamageTarget(udg_DamageEventSource, d, 145, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC, null)
          if not IsUnitType(d,UNIT_TYPE_STRUCTURE) then
         call DestroyEffect(AddSpecialEffectTarget("Abilities\\Spells\\Orc\\LightningBolt\\LightningBoltMissile.mdl",d,"chest"))
          endif
          endif
          call GroupRemoveUnit(g,d)
          endloop
//call DestroyBoolExpr(B)
call DestroyGroup(g)

call AddEffectTimeToPoint("Lightning Shock.mdx",targetx,targety,0.7)
endif


set I2 = LoadInteger(Hash,GetHandleId(udg_DamageEventSource),StringHash("Zeal_lvl"))
if I2 == 1 then
set R = 30
set I = 3

elseif I2 == 2 then
set I = 5
set R = 50

elseif I2 == 3 then
set I = 7
set R = 70

endif

call DestroyEffect(LoadEffectHandle(Hash,GetHandleId(udg_DamageEventSource),StringHash("Zeal_e")))
call RemoveSavedHandle(Hash,GetHandleId(udg_DamageEventSource),StringHash("Zeal_e"))
call RemoveSavedReal(Hash,GetHandleId(udg_DamageEventSource),StringHash("Zeal_time"))
call RemoveSavedInteger(Hash, GetHandleId(udg_DamageEventSource), StringHash("Zeal_lvl"))

set d = CreateUnit(sourceplayer,dummy,targetx,targety,0)
call UnitApplyTimedLife( d,'BTLF' , 0.1 )
call UnitAddAbility(d,'A22Q')
call SetUnitAbilityLevel(d,'A22Q',GetUnitAbilityLevel(udg_DamageEventSource,'A00I'))
call IssueTargetOrder(d,"creepthunderbolt",udg_DamageEventTarget)
call KillUnit(CreateUnit(sourceplayer,'e00J',targetx,targety,0))
call DestroyEffect(AddSpecialEffect("Divine Edict.mdx",targetx,targety))

call PlaySoundOnUnit( gg_snd_Incinerate1, 100, udg_DamageEventTarget,127 )
call SetSoundDistanceCutoff( bj_lastPlayedSound, 950.00 )
if GetUnitAbilityLevel(udg_DamageEventSource,'A00I') == 1 then
set R = 20
elseif GetUnitAbilityLevel(udg_DamageEventSource,'A00I') == 2 then
set R = 60
else
set R = 110
endif
call UnitDamageTarget(udg_DamageEventSource, udg_DamageEventTarget, 30 + R, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC, null)
endif
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
Based on your description, it sounds to me like you are encountering an issue of recursion. Your code is incomplete, however, and the formatting also poorly conveys the context of each line of code, but from what you're showing me I cannot gather the full scope of the problem.

Changing from Damage Engine 3.8 to 3A means that there is automatic recursion protection built-in.
 
Based on your description, it sounds to me like you are encountering an issue of recursion. Your code is incomplete, however, and the formatting also poorly conveys the context of each line of code, but from what you're showing me I cannot gather the full scope of the problem.

Changing from Damage Engine 3.8 to 3A means that there is automatic recursion protection built-in.
Hi Bribe, can u answer my questions a couple of posts above? Many thanks 😁
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
The way I see it in this version:
New Event
Old Event Equivalent
PreDamageEvent 1.00DamageModifierEvent 1.00
ArmorDamageEvent 1.00DamageModifierEvent 4.00
OnDamageEvent 1.00DamageEvent 1.00
  • The remaining events such as ZeroDamage, LethalDamage, AfterDamage are self-explanatory.
  • In the new events, comparison signs (<>= etc.) work the same way as in older 5.9 version to denote detection of Attack/Spell/Code damage.
  • In the new events, only real value of 1.00 is needed for a correct syntax of damage detection event.
Please correct me if I'm wrong in any parts above.

Btw, if I used "DamageModifierEvent 1.00" - "DamageModifierEvent 2.00" - "DamageModifierEvent 4.00" for sequential handling of a damage event in the old engine (1 -> 2 -> 4), will "PreDamageEvent 1.00" - "DamageModifierEvent 2.00" - "ArmorDamageEvent 1.00" maintain the same sequence?

From lines 533:548 on my GitHub source:
JASS:
private static method getStrIndex takes string var, real lbs returns thistype
        local integer root = R2I(lbs)
        if (var == "udg_DamageModifierEvent" and root < 4) or var == "udg_PreDamageEvent" then
            set root = MOD
        elseif var == "udg_DamageModifierEvent" or var == "udg_ArmorDamageEvent" then
            set root = SHIELD
        elseif (var == "udg_DamageEvent" and root == 2 or root == 0) or var == "udg_ZeroDamageEvent" then
            set root = ZERO
        elseif var == "udg_DamageEvent" or var == "udg_OnDamageEvent" then
            set root = DAMAGE
        elseif var == "udg_AfterDamageEvent" then
            set root = AFTER
        elseif var == "udg_LethalDamageEvent" then
            set root = LETHAL
        elseif var == "udg_AOEDamageEvent" or var == "udg_SourceDamageEvent" then
            set root = AOE
This shows that the new event names and the old event names will always have priorities irrespective of what the old values used to be. PreDamageEvent usage will always take precedence over any DamageModifierEvent >= 4.00 event as long as the PreDamageEvent value is less than 4.
 
Level 9
Joined
May 24, 2016
Messages
297
Based on your description, it sounds to me like you are encountering an issue of recursion. Your code is incomplete, however, and the formatting also poorly conveys the context of each line of code, but from what you're showing me I cannot gather the full scope of the problem.

Changing from Damage Engine 3.8 to 3A means that there is automatic recursion protection built-in.
If I give group damage with a delay from timer with 0.01 real and it will work, I guess I solved the problem?
 

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,456
If I give group damage with a delay from timer with 0.01 real and it will work, I guess I solved the problem?
If you are careful to avoid recursion on your own, that is a good way to do it, and ensures that things like "killing unit" XP and gold are consistent.

If I am not mistaken, the AfterDamageEvent can be your friend here though. I can't recall if recursion is built-in with that one. You can try that instead of a manual timer.
 
From lines 533:548 on my GitHub source:
JASS:
private static method getStrIndex takes string var, real lbs returns thistype
        local integer root = R2I(lbs)
        if (var == "udg_DamageModifierEvent" and root < 4) or var == "udg_PreDamageEvent" then
            set root = MOD
        elseif var == "udg_DamageModifierEvent" or var == "udg_ArmorDamageEvent" then
            set root = SHIELD
        elseif (var == "udg_DamageEvent" and root == 2 or root == 0) or var == "udg_ZeroDamageEvent" then
            set root = ZERO
        elseif var == "udg_DamageEvent" or var == "udg_OnDamageEvent" then
            set root = DAMAGE
        elseif var == "udg_AfterDamageEvent" then
            set root = AFTER
        elseif var == "udg_LethalDamageEvent" then
            set root = LETHAL
        elseif var == "udg_AOEDamageEvent" or var == "udg_SourceDamageEvent" then
            set root = AOE
This shows that the new event names and the old event names will always have priorities irrespective of what the old values used to be. PreDamageEvent usage will always take precedence over any DamageModifierEvent >= 4.00 event as long as the PreDamageEvent value is less than 4.
I got it.
By the way, what about the <>= symbols? Does PreDamageEvent/ArmorDamageEvent/OnDamageEvent < X only run for attack damage, > X only for spell damage, != X only for code damage?
 
Level 5
Joined
Nov 3, 2018
Messages
74
1709659753519.jpeg

For some reason i cant get the system to detect damage types am i doing something wrong? what is the condition that checks damage type if it is not integer?
 
Top