[Trigger] Custom Script : Local problem!

[Razorbrain]

i know how to make variables local, but there seem to be a problem

there seems to be a duration on the localing

here is my trigger:

• Events
  • Unit - A unit Starts the effect of an ability
• Conditions
  • (Ability being cast) equal to Snow Storm
• Actions
  • Custom script: local weathereffect udg_SnowStorm
  • Environment - Change terrain type at (Center of My Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle
  • Set SnowStorm = (Last created weather effect)
  • Wait 20 Seconds
  • Remove SnowStorm

ya, i know its leaky, but after these 20 seconds, the Snow Storm doesnt go away! how do i fix this

 

[Lej]

• Environment - Change terrain type at (Center of My Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle

Uses SetTerrainTypeBJ() which doesn't set bj_lastCreatedWeatherEffect which means you set SnowStorm to null.

To be able to revert the terrain back to the previous I guess you would have to check what type of terrain there is at each tile and store them. Then after the wait use the store data to change it back.

 

[PurplePoot]

local should not have a capitalized l. Your trigger shouldn't even be compiling.

 

[Dr Super Good]

Use propper jass and not just badly enhanced GUI. JASS beats GUI and you can not argue with that.

 

[Razorbrain]

@ Lej
it works without the local, why?
@ Poot
it automaticly makes it a capital here, strangely enough, its not capitalized in the map

 

[Lej]

@ Lej
it works without the local, why?

Can you post the trigger, without local, that works. Because I tried with:

• SnowStorm
  • Events
    • Time - Elapsed game time is 1.00 seconds
  • Conditions
  • Actions
    • Environment - Change terrain type at (Center of (Playable map area)) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle
    • Set SnowStorm = (Last created weather effect)
    • Wait 1.00 seconds
    • Environment - Remove SnowStorm

before looking up what the functions do.

 

[Razorbrain]

oh, now i realise i made some changes before i tried to make the skill MUI, and now i also realise what you mean, sry everybody

+ rep to you Lej

but i got another local problem, that doesnt have to do with a weather effect..... i might post it soon

EDIT : Here is our new problem

this trigger doesnt work

• Set SnowStormCaster = (Casting unit)
• Set Position = Position of (Casting unit)
• Set Region = Region <gen>
• Region - Center Region on Position
• Environment - Change terrain type at (Center of Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle
• Wait 5 seconds(game-time)
• Environment - Change terrain type at (Center of Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle

while this one doesnt

• Custom script: local rect udg_Region
• Set SnowStormCaster = (Casting unit)
• Set Position = Position of (Casting unit)
• Set Region = Region <gen>
• Region - Center Region on Position
• Environment - Change terrain type at (Center of Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle
• Custom script: call RemoveLocation (udg_Position)
• Wait 5 seconds(game-time)
• Environment - Change terrain type at (Center of Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle
• Custom script: call RemoveRect (udg_Region)

what is the problem here?

oh, almost forgot, the problem is, that the Terrain change doesnt occur, and i have manage to solve that problem too, now, my new problem is, that it isnt MUI, even though it got locals :S

 

[Preskooldude]

You can make locals that are globals too?

 

[Razorbrain]

You can make locals that are globals too?

you are intending what?

 

[PurplePoot]

He's wondering what's going on with the GUI local trick.

And pre, it's just a weird glitch with GUI. It's not that handy either way, as trying to enhance GUI is basically pointless, as there are so many unfixable flaws.

 

[Razorbrain]

does it work if i simply convert it into Jass?

 

[Pyritie]

It would make no difference, since GUI basically is JASS, just looks nicer.

 

[Preskooldude]

You're leaking anyway, because (Center of Region) in

• Environment - Change terrain type at (Center of Region) to Lordaeron Winter - Snow using variation -1 in an area of size 10 and shape Circle

Leaks a point.

 

[Razorbrain]

oh, thanks, now i know what to do