[Trigger] create lag

[[K40$]-Spectre]

Does this trigger create a lag?

• Events
• A unit enters region1
• Conditions
• (Unit-type of (Entering Unit)) Equal to Footman
• Actions
• Unit - Order (Entering Uint) to Move to (Center of Region2)

 

[Day-Elven]

It leaks in event, you can't fix it.
And use triggering unit instead of entering unit.

 

[ZlatniLav]

This is your leakless trigger!

• Untitled Trigger 001
  • Events
    • Unit - A unit enters (Your Region)
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Footman
  • Actions
    • Set TempPoint = (Center of (Your Region))
    • Unit - Move (Triggering unit) instantly to TempPoint
    • Custom script: call RemoveLocation (udg_TempPoint)

 

[[K40$]-Spectre]

Thanks Day-Elven and ZlatniLav, is it also possible to make one like that one but than instead of "move instantly" that you use "issue order unit move to region"?

 

[Day-Elven]

Issue a point order to triggering unit to move to the udg_TempPoint.
But won't this trigger still leak in event?

 

[ZlatniLav]

You use ''Issue a point order to triggering unit to move to the udg_TempPoint'' unit wont move instantly. Same when you click Right-Click in game

@Day-Elven Trigger doesent leak in event. Units dont leak.

 

[[K40$]-Spectre]

Thanks both, +rep to you.

I can't +rep you Day-Elven cause I've given you +rep not so long ago.

 

[Anachron]

Memory Leaks

Please read this tutorial to get a rid of leaks.

 

[[K40$]-Spectre]

Yeah I already know that tutorial. Quite good actually, but I've no experience with Jass and I don't feel like it to learn (to lazy).

 

[LordDz]

Why isn't entering unit good?

 

[Need_O2]

http://www.hiveworkshop.com/forums/f269/things-leak-35124/
GUI releated Things That Leak

 

[Eleandor]

It leaks in event, you can't fix it.
And use triggering unit instead of entering unit.

I don't think you really understand leaks...

When a trigger is destroyed, the events are still in memory and thus are a leak.
However, it's not because your trigger has an event, that the event is leaking already. Until you destroy the trigger, you NEED the event to be there. If you'd remove the event, the trigger would simply no longer work. It's only when you no longer use an object and have lost reference to it that it leaks. But in this case, you're still using the event object because you want the trigger to run, right?

Oh, and a "lag" is not a "leak". A lag is an uncomfortable delay on everything you do. Possible causes could be network latency (i.e. you don't have a fast connection to the other end of the world...) or too little memory, forcing you to use your slower virtual memory or simply a messed up memory stack caused by leaks. But then you need to have a lot of leaks before that happens, and it doesn't happen from just one event.

 

[Day-Elven]

Latency can be reduced by VCK. (Tools section).

@Eleandor
Do events leak remove so when I use CallDestroyTrigger(gg_trg_Trigger) or i need to remove events from it before deleting trigger?
And should I call trigger functions in other triggers because of event leak so?

 

[[K40$]-Spectre]

Why doesn't this trigger work?;

• Events:
• Unit - a unit enters region A
• Conditions:
• Unit-type of entering unit equal to fag
• Actions:
• Set TemPoint = (Center of region B)
• Unit - order (triggering unit) to attack-move to TempPoint
• Custom Scipt call RemoveLocation (udg_TempPoint)

I also tried "entering unit", that also didn't worked.

 

[Airandius]

Issue a point order to triggering unit to move to the udg_TempPoint.
But won't this trigger still leak in event?

Events can't leak, in any case if they would, you wont be able to clean them out anyway. (As far as GUI goes.)

-----

Oh yeh, [K40$]-Spectre....
Maybe this is your problem:

• Set TemPoint = (Center of region B)

It's not TempPoint?

Alos in your condition just use triggering unit, it's more effective.

 

[Eleandor]

Events do leak if you remove the trigger, but you can't remove the events anyway. And in general, you never need to destroy a trigger (and in GUI you literally will never destroy it).

The only other case that events would leak is in a damage detection system. In such a system you add a "specific unit takes damage" event to the same trigger for each unit on the map. When that unit dies, the event is no longer used but still registered to the trigger, and thus it leaks.

 

[[K40$]-Spectre]

Oh yeh, [K40$]-Spectre....
Maybe this is your problem:
Set TemPoint = (Center of region B)

I wrote that wrong here, not in WE.

 

[Airandius]

I wrote that wrong here, not in WE.

In that case your trigger is not the problem.

(Btw just right click and copy as text your trigger next time.
You can just paste it in you post between the trigger tags for better viewing.)

I guess there could be 2 problems, either it does not work because the unit is entering a different region thus not activating the event.
Or the unit entering is not equal to a fag (yeh that's what you called it.) so the condition prevents the actions from running.

 

[[K40$]-Spectre]

does not work because the unit is entering a different region thus not activating the event.

, denitely the right region.

Or the unit entering is not equal to a fag (yeh that's what you called it.) so the condition prevents the actions from running.

, actually, he's a fag.

But could it be that the unit must walk into the region? Because I've placed the unit already in the region in the map.

 

[Airandius]

, denitely the right region.

, actually, he's a fag.

But could it be that the unit must walk into the region? Because I've placed the unit already in the region in the map.

Yes he must enter the region, that's your problem.

 

[Anachron]

Warcraft 3 only checkes when a unit comes into the border of the rect, so when your unit actually is in the map before it will not check.

 

[[K40$]-Spectre]

Thanks to both of you, you two are really helpfull.

 

[[K40$]-Spectre]

Do you also know if there's a lag in this trigger?;

• [TRIGGER]Soldiers2
  • Events
    • Time - Every 60.00 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of living |cffff0000Militia|r (Knife+Shield) units owned by Player 6 (Orange)) Less than or equal to 12
      • Then - Actions
        • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>) facing Default building facing degrees
      • Else - Actions
        • Unit Group - Pick every unit in (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield)) and do (Unit - Order (Picked unit) to Attack-Move To (Player 5 (Yellow) start location))

and in this one?;

• Guardsmen
  • Events
    • Unit - A unit owned by Player 6 (Orange) Dies
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • |cffff0000Guardsmen|r (Sword+Torch) 0271 <gen> Equal to (Dying unit)
      • Then - Actions
        • Wait 15.00 seconds
        • Unit - Create 1 |cffff0000Guardsmen|r (Sword+Torch) for Player 6 (Orange) at (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>) facing Default building facing degrees
        • Hero - Set (Last created unit) Hero-level to (4 + (Random integer number between 4 and 12)), Hide level-up graphics
        • Unit - Order (Last created unit) to Attack-Move To (Center of Kathai1 <gen>)
      • Else - Actions

 

[ZlatniLav]

Again point leak

• Set TempPoint = Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>
• Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at Temp Point facing Default building facing degrees
• Custom Script: call RemoveLoaction (udg_TempPoint)

 

[Anachron]

I have posted the leaks below.

If - Conditions
(Number of living |cffff0000Militia|r (Knife+Shield) units owned by Player 6 (Orange)) Less than or equal to 12

Unitgroup leak

Then - Actions
Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)

Point leak

facing Default building facing degrees
Else - Actions
Unit Group - Pick every unit in (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield)) and do (Unit - Order (Picked unit) to Attack-Move To (Player 5 (Yellow) start location))

Unitgroup and point leaks

Guardsmen
Events
Unit - A unit owned by Player 6 (Orange) Dies
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
|cffff0000Guardsmen|r (Sword+Torch) 0271 <gen> Equal to (Dying unit)
Then - Actions
Wait 15.00 seconds
Unit - Create 1 |cffff0000Guardsmen|r (Sword+Torch) for Player 6 (Orange) at (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)

Point Leak

facing Default building facing degrees
Hero - Set (Last created unit) Hero-level to (4 + (Random integer number between 4 and 12)), Hide level-up graphics
Unit - Order (Last created unit) to Attack-Move To (Center of Kathai1 <gen>)

Point leak

Else - Actions

 

[[K40$]-Spectre]

All the point leaks have been solved, exept for the else -actions (how do I solve this one?).

And how do I solve the unitgroup leaks?

Thanks guys, this really improves my project.

 

[ZlatniLav]

UNIT GROUP FIX

• Set TempGroup = (Matching Conditions)
• Custom Script: call DestroyGroup (udg_TempPoint)

ELSE - ACTIONS FIX

• Set TempPoit = (Player 5 (Yellow) start location

 

[Anachron]

All the point leaks have been solved, exept for the else -actions (how do I solve this one?).

And how do I solve the unitgroup leaks?

Thanks guys, this really improves my project.

Have you checked mine also?

To remove a unitgroup-leak:

1st UnitGroup Leak

If - Conditions
(Number of living |cffff0000Militia|r (Knife+Shield) units owned by Player 6 (Orange)) Less than or equal to 12

the first unitgroup (In a condition hidden):

1st: Do a Tmp_Group, just add a new variable type = unitgroup.
2nd: Do a Tmp_Integer variable, just add an integer with the name.
It is used for counting the units.

Then do the following:
CustomScript: set udg_Tmp_Group = CreateGroup()
set Tmp_Group = Units of type |cffff0000Militia|r (Knife+Shield) by Player(6)
set Tmp_Integer = Number Of units in Tmp_Group()

Now the IF THEN ELSE with condition = Tmp_Integer >= .. whatever..
and after ..

CustomScript: call DestroyGroup(udg_Tmp_Group)
CustomScript: set udg_Tmp_Group = null

Second as he said before.

 

[ZlatniLav]

integers don't leak...

 

[Anachron]

integers don't leak...

I haven't said that. But you should store it in an integer since it makes your code more readable.

 

[[K40$]-Spectre]

Then do the following:
CustomScript: set udg_Tmp_Group = CreateGroup()
set Tmp_Group = Units of type |cffff0000Militia|r (Knife+Shield) by Player(6)
set Tmp_Integer = Number Of units in Tmp_Group()

, I'm a bit confused, where do I need to put this?

 

[Anachron]

, I'm a bit confused, where do I need to put this?

Before the if then else construkt.

 

[ZlatniLav]

CustomScript: set udg_Tmp_Group = CreateGroup()

if Tmp_Group is global variable you do not need this

 

[Anachron]

if Tmp_Group is global variable you do not need this

You do, since I destroy the group and null it, don't you?

 

[[K40$]-Spectre]

never mind I get, so this trigger is leakless?;

• Soldiers2
  • Events
    • Time - Every 60.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set udg_Tmp_Group = CreateGroup()
    • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))
    • Set TempInteger = (Number of units in TempGroup)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • TempInteger Less than or equal to 12
      • Then - Actions
        • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>) facing Default building facing degrees
      • Else - Actions
        • Set TempPoint2 = (Player 5 (Yellow) start location)
        • Unit Group - Pick every unit in TempGroup and do (Unit - Order (Picked unit) to Attack-Move To TempPoint2)
        • Custom script: call RemoveLocation (udg_TempPoint2)
        • Custom script: call DestroyGroup(udg_Tmp_Group)
        • Custom script: set udg_Tmp_Group = null

 

[Anachron]

, I don't understand this one, what do I need to do here?

Instead using the

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Number of living |cffff0000Militia|r (Knife+Shield) units owned by Player 6 (Orange)) Less than or equal to 12
• Then - Actions
• Else - Actions

You use

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• Tmp_Integer Less than or equal to 12
• Then - Actions
• Else - Actions

 

[[K40$]-Spectre]

bump

 

[Anachron]

bump

Destroy the group OUT OF THE IF THEN ELSE CONSTRUCT,
because it must be triggered whatever tree of actions will been triggered.

Else then that, it seems good.

(Edit: But fix the THEN tree please, the leaks..)

 

[[K40$]-Spectre]

(Edit: But fix the THEN tree please, the leaks..)

, last question, I need to make here a unit variable for right? But how do the custom scripts will look for it?

 

[Anachron]

, last question, I need to make here a unit variable for right? But how do the custom scripts will look for it?

What? in the THEN tree the point leak must to be fixed, and you know how..

 

[[K40$]-Spectre]

Oh ok, thanks, silly me .

 

[[K40$]-Spectre]

WE gave a script error, this script;

• Custom script: set udg_Tmp_Group = null

in this trigger;

• Soldiers2
  • Events
    • Time - Every 60.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set udg_Tmp_Group = CreateGroup()
    • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))
    • Set TempInteger = (Number of units in TempGroup)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • TempInteger Less than or equal to 12
      • Then - Actions
        • Set TempPoint2 = (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)
        • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at TempPoint2 facing Default building facing degrees
        • Custom script: call RemoveLocation (udg_TempPoint2)
      • Else - Actions
        • Set TempPoint2 = (Player 5 (Yellow) start location)
        • Unit Group - Pick every unit in TempGroup and do (Unit - Order (Picked unit) to Attack-Move To TempPoint2)
        • Custom script: call RemoveLocation (udg_TempPoint2)
    • Custom script: set udg_Tmp_Group = null
    • Custom script: call DestroyGroup(udg_Tmp_Group)

 

[Anachron]

WE gave a script error, this script;

• Custom script: set udg_Tmp_Group = null

in this trigger;

• Soldiers2
  • Events
    • Time - Every 60.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set udg_Tmp_Group = CreateGroup()
    • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))
    • Set TempInteger = (Number of units in TempGroup)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • TempInteger Less than or equal to 12
      • Then - Actions
        • Set TempPoint2 = (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)
        • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at TempPoint2 facing Default building facing degrees
        • Custom script: call RemoveLocation (udg_TempPoint2)
      • Else - Actions
        • Set TempPoint2 = (Player 5 (Yellow) start location)
        • Unit Group - Pick every unit in TempGroup and do (Unit - Order (Picked unit) to Attack-Move To TempPoint2)
        • Custom script: call RemoveLocation (udg_TempPoint2)
    • Custom script: set udg_Tmp_Group = null
    • Custom script: call DestroyGroup(udg_Tmp_Group)

I don't wonder, name the variable Tmp_Group please AND NOT TempGroup.

 

[[K40$]-Spectre]

Thanks, +rep for helping.

 

[Anachron]

Thanks, +rep for helping.

No problem, I like helping.

 

[Eleandor]

You don't need this action:
Custom script: set udg_Tmp_Group = CreateGroup()

In fact, that script introduces a new leak.

You see, the "Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield)" action automatically creates a new group with the correct units in it. And that's the whole problem with leaks in GUI: these actions create groups but those groups are never destroyed. They can be destroyed by calling DestroyGroup() on the group, but then you need to store this group in a variable first (hence why you write: set TempGroup = units owned by ...)

However, if you do:

• Custom script: set udg_Tmp_Group = CreateGroup()
  • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))

you will create a new empty group stored in Tmp_Group
you will then create a new group containing militia units owned by player 6 and store it in Tmp_Group. But you've never destroyed the first group, and you'll never be able to because you've just overwritten Tmp_Group.

The correct trigger is:

• Soldiers2
• Events
  • Time - Every 60.00 seconds of game time
• Conditions
• Actions
  • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Number of units in TempGroup) Less than or equal to 12
    • Then - Actions
      • Set TempPoint = (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)
      • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at TempPoint facing Default building facing degrees
    • Else - Actions
      • Set TempPoint = (Player 5 (Yellow) start location)
      • Unit Group - Pick every unit in TempGroup and do (Unit - Order (Picked unit) to Attack-Move To TempPoint)
  • Custom script: call RemoveLocation (udg_TempPoint2)
  • Custom script: call DestroyGroup(udg_Tmp_Group)

 

[Anachron]

You don't need this action:
Custom script: set udg_Tmp_Group = CreateGroup()

In fact, that script introduces a new leak.

You see, the "Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield)" action automatically creates a new group with the correct units in it. And that's the whole problem with leaks in GUI: these actions create groups but those groups are never destroyed. They can be destroyed by calling DestroyGroup() on the group, but then you need to store this group in a variable first (hence why you write: set TempGroup = units owned by ...)

However, if you do:

• Custom script: set udg_Tmp_Group = CreateGroup()
  • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))

you will create a new empty group stored in Tmp_Group
you will then create a new group containing militia units owned by player 6 and store it in Tmp_Group. But you've never destroyed the first group, and you'll never be able to because you've just overwritten Tmp_Group.

The correct trigger is:

• Soldiers2
• Events
  • Time - Every 60.00 seconds of game time
• Conditions
• Actions
  • Set TempGroup = (Units owned by Player 6 (Orange) of type |cffff0000Militia|r (Knife+Shield))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Number of units in TempGroup) Less than or equal to 12
    • Then - Actions
      • Set TempPoint = (Position of |cffff0000Kathai Spawn Point|r 1 0281 <gen>)
      • Unit - Create 3 |cffff0000Militia|r (Knife+Shield) for Player 6 (Orange) at TempPoint facing Default building facing degrees
    • Else - Actions
      • Set TempPoint = (Player 5 (Yellow) start location)
      • Unit Group - Pick every unit in TempGroup and do (Unit - Order (Picked unit) to Attack-Move To TempPoint)
  • Custom script: call RemoveLocation (udg_TempPoint2)
  • Custom script: call DestroyGroup(udg_Tmp_Group)

Thanks, so now I've learned it correctly and can now remove the leak in my Map CHASER WARS <3 THX