[Trigger] Could any of these triggers cause desyncs?

[coolyoshi1]

So I'm trying to fix one of my old maps which is pretty well known for desyncing. Was wondering if any of these triggers could possibly cause a desync and under what circumstances?

• prevent double uu
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to |cff00fa9aUltimate Upgrade|r
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Custom value of (Triggering unit)) Equal to 666
      • Then - Actions
        • Item - Remove (Item being manipulated)
      • Else - Actions
        • Unit - Set the custom value of (Hero manipulating item) to 666

• Undead Gold Income
  • Events
    • Time - Every 4.60 seconds of game time
  • Conditions
    • AAA_TurnOffEvents Equal to False
  • Actions
    • Player Group - Pick every player in Evil and do (Actions)
      • Loop - Actions
        • If (((Picked player) slot status) Equal to Is playing) then do (Player - Set (Picked player) Current gold to (((Picked player) Current gold) + 1)) else do (Do nothing)

 

[Pyrogasm]

I don't see anything desync-causing there.

 

[MyPad]

Same here. The condition statement in the second trigger is incomplete.

 

[coolyoshi1]

Okay thanks guys. Just curious if anyone would be willing to take a look at my map to see if they can find anything?
I can post my map here if needed

 

[Pyrogasm]

If there are lots of triggers it's a lot to look into. I would suggest putting a vJASS hook to catch GetLocalPlayer() calls, as those are most likely going to be the source of desyncs. Something like:

library DesyncCheck
    globals
        public integer COUNT = 0
    endglobals

    public function onGLP takes nothing returns nothing
        set COUNT = COUNT + 1
        call BJDebugMsg("GLP call number "+I2S(COUNT))
    endfunction

    hook GetLocalPlayer onGLP
endlibrary

Not super helpful on its own since GLP() has no arguments you can learn something from with the hook... but there might be something you can learn that way about the desyncs. You could make other simple libraries for common desync issues to see what those turn up too. Just thoughts.

 

[PurgeandFire]

ya you should post the map here, and give any info you know about when players desync.

 

[coolyoshi1]

K before posting my map I'll do a bit more investigation and come back to the forums when I get a better understanding of when players desync. Although as of right now it seems completely random.

 

[Daffa]

By any chance you use Pan Camera as Necessary anywhere in your triggers?