[Trigger] How can I Improve these Triggers?

[Echo]

Basically what these triggers are for is remembering ammo and clips left (gold is bullets, lumber is clips). Each specific gun has it's own set of bullets and clips, I wanted to know if it is a good Idea using variables with arrays to store them, or should I use hastables? I have no idea how to work with them though.

This trigger below is the ammo memorizer or what ever you want to call it. Right now I only have 2 guns on the map and 2 gun types.

Ammo Storing

• Ammo Storing
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Hero has an item of type AK-47) Equal to False
        • (Hero has an item of type Pistol) Equal to False
      • Then - Actions
        • Player - Set Player 1 (Red) Current gold to 0
        • Player - Set Player 1 (Red) Current lumber to 0
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Hero has Pistol_One) Equal to True
          • Then - Actions
            • Set Pistol_One_Ammo[1] = (Player 1 (Red) Current gold)
            • Set Pistol_One_Ammo[2] = (Player 1 (Red) Current lumber)
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Hero has AK47_One) Equal to True
          • Then - Actions
            • Set AK47_One_Ammo[1] = (Player 1 (Red) Current gold)
            • Set AK47_One_Ammo[2] = (Player 1 (Red) Current lumber)
          • Else - Actions

The triggers below is when the hero first picks up the AK-47 and when he picks it up again.

AK-47 First time picked up

• AK47 First Pick up
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item being manipulated) Equal to AK47_One
  • Actions
    • Player - Set Player 1 (Red) Current gold to 30
    • Player - Set Player 1 (Red) Current lumber to 1
    • Trigger - Turn off (This trigger)
    • Trigger - Turn on AK47 Repick Up <gen>

• AK47 Repick Up
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item being manipulated) Equal to AK47_One
  • Actions
    • Player - Set Player 1 (Red) Current gold to AK47_One_Ammo[1]
    • Player - Set Player 1 (Red) Current lumber to AK47_One_Ammo[2]

Thanks for reading.

 

[nedio95]

The loop doesn't need to run 33 times a second. Maybe betwen 20 and 15 would be ok.

What happens if he has both pistol and ak ? You should make them equipable or something. (maybe you have already done that but it's not shown in those triggers)
Maybe:
unit uses item
item used == ak/pistol
set equipedweapon == some variable which represents each weapon can be integer or string

 

[Echo]

I was just going with something boring like 'You cannot equip another weapon while you have another in your hand'

But that sounds a lot better. The only downside to that is each type of gun has its own buff as well. The starting pistol is -20% attack speed, I'm not sure how I can still only have the buff apply with the specific gun equipped unless I go with a dummy unit casting a spell on the hero.

 

[nedio95]

Give the items only the equip aility and make the buffs unit abilities. When weapon is equiped remove all buffabilities and add the equiped weapon buffabilities to spellbook and hide it.

 

[Echo]

Considering the hero already has a spell book ability should I just put it in that one and hide it? or make a new spell book and hide that. Either one still sounds better than creating a dummy!

Thanks for the help

 

[nedio95]

Mmm I assume you need the first for... stuff... so use other spell book for the buffabilities.