Chinese Dragon 1.51

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

09:14, 2nd May 2014
BPower:
Currently you are using 5 location variables, while just two would be enough.
In "trained" you remove the same location twice.
Anything used more than once (twice) should be stored into a variable to save computation time, for instance TriggeringUnit.
You stated, you understood my suggestion about moving the dragon. I want to see it in the next update.

 

[Kazeon]

leaks are not causing lags

• Set Dragon_UnitGroup = (Units within Dragon_DmgRange of TempPoint001 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Dragon_Trained[Loop_A_Interger])) Equal to True) and (((Matching unit) is alive) Equal to True)))

filter units using If then else!

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• MUI Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)

you check it every 0.03 seconds?

• Unit - A unit Finishes training a unit

what if I want to create a dragon but that's not the event I want?

what will happen if I create 10 dragons? maybe my PC will be blue-screened x.X

your spell[?] need more configurations

 

[Tal'Rarity]

Sadly awesome stuff like this Wc3 can't handle, really epic idea though. It is useable if you only use 1-2.

EDIT: It's the special effect and dummy unit creation lagging it, not your triggers. To me it looks pretty leakless and near-perfect.

 

[Kazeon]

Sadly awesome stuff like this Wc3 can't handle, really epic idea though. It is useable if you only use 1-2.

not really, the code can still be optimized, maybe later you are able to use 5-10 c:

 

[LordDz]

Does this work?
Unit - Add a 1.00 second Generic expiration timer to (Last created unit)

I'm pretty sure that you have to change it to water elemental or something, IF I remember correctly.

 

[Wrda]

I'm 100% sure that the lag is caused by the amount of units you create every 0.03 seconds (dummies - the effect of dragon). Try to increase the periodic time to 0.50 or what ever (not saying that it must be like that)

 

[Hantoo]

I will check it out later
But I think there is a leak
After create 2 dragon
At first there is no lag at all...
But after a long time it started to lag
And if I only create one dragon for a long time..
After my dragon die.. It still lags..
Sounds like leak stacking huh?

(thx for the testing rifleman)

 

[Wrda]

Its the amount of units you create for the trail of the dragon. you create 33 a second, you don't remove them in game, only kill, meaning that it still exists, make a trigger to remove them after they get killed. This doesn't fully clear the leak, but a great part of it.

 

[Hantoo]

But in previous spell that I made.. In have a remove dummy trigger but someone say it is not needed

 

[Wrda]

Who

 

[Hantoo]

nvm your solution reduces lag alot...
i will go and post ot after more tweaks

 

[BandolXD]

DRAAAAAAGON
I love it < 3
+Rep !

 

[Hantoo]

leaks are not causing lags

• Set Dragon_UnitGroup = (Units within Dragon_DmgRange of TempPoint001 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Dragon_Trained[Loop_A_Interger])) Equal to True) and (((Matching unit) is alive) Equal to True)))

filter units using If then else!

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• MUI Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)

you check it every 0.03 seconds?

• Unit - A unit Finishes training a unit

what if I want to create a dragon but that's not the event I want?

what will happen if I create 10 dragons? maybe my PC will be blue-screened x.X

your spell[?] need more configurations

well now you can have 10 dragonss yay..
i had add for new event (spell)
a little bit more configuration

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• MUI Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)

you check it every 0.03 seconds?

• Set Dragon_UnitGroup = (Units within Dragon_DmgRange of TempPoint001 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Dragon_Trained[Loop_A_Interger])) Equal to True) and (((Matching unit) is alive) Equal to True)))

filter units using If then else!


how to fix this?

 

[pOke]

You do not need to do a trigger such as

Unit Dies
Unit-type is x
Remove X from game

You need to just go to the OE and set the dummy to Can't Raise, Does not Decay. That causes it to be removed on its own.

 

[BPower]

Variables generated with the variable editor can quickly cause problems if they share the same name.
That's the reason we want you to choose unique and uniform variables names for your submissions. Please also label variables like "MUI" into Dragon_MUI. Btw a 3 char identifier DRA_ would be enough.
Example:
- Your spell uses the variable name "MUI".
- Another spell uses the variable name "MUI".
- An users imports both spells --> Imported variables get created.
- "MUI" does already exist --> not created a second time.
- "MUI" is used over both resource and will casues malfunction.

Don't remove the dummy from the game. "Can't raise, does not decay" deals with it.
Why do your dummies have the human inventory ability?

You want to get rid of all kind of laggs/spikes (I didn't experience them while testing)
-> Create the tail as a whole and move it along with the head.

 

[Hantoo]

-> Create the tail as a whole and move it along with the head.
what does this mean?

ANYWAY..
BPower, arent you a moderator

extra: and is there any solution other than just let the unit patrolling?

 

[Jimaras5690]

Nice spell I downloaded only the head but I think this is better I made the item throw the head but now how Can I change that abillity to this one you made help

 

[Hantoo]

I will make tweaks for that ...

okay...
no update is needed just add the ability to the item
(ya maybe i should update)
ok im gonna do it now

 

[IcemanBo]

Custom script: call RemoveLocation(udg_DRA_TempPoint00)

^This line is you accidently made two times in your "Trained" trigger. Also in same trigger you could store TriggeringUnit into a variable to prevent more function calls.

In your "Walk" trigger you don't need this "And - All (Conditions)" block.

If dragon gets order to stop or to hold position it moves staight until it gets out of map and game crashes.

If I order the dragon to move to a larger distance, it stops after short distance and begins circeling again.
It's sucky that you need to spam orders to move the dragon to wanted place. :s

Move following into your de-index part:

If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions DRA_MUI Equal to 0 Then - Actions Trigger - Turn off (This Trigger) Else - Actions [/stable] No need to check it each time. You use SetUnitX/Y for dragon. Thats ok, but you should check that it wont get out of map. First it may bug as mentioned before, and secondly it looks strange, you can test it yourself. You should improve the description and icon in object editor. Set DRA_UnitGroup = (Units within DRA_DmgRange of DRA_TempPoint001 matching ((((Matching unit) is A Building) Equals False) and ((((Matching unit) belongs to an enemy of (Owner of DRA_Trained[DRA_Loop_A_Interger])) Equals True) and (((Matching unit) is alive) Equals True)))) I would pick all units in range, set PickedUnit to a variable and then filter it. It's easier to read. Dragon looks very cool in game, I like it much. Would be cool if you could add configuration if dragon can damage buildings or not, and I don't like it very much that you create so much units periodically.

 

[Hantoo]

Variables generated with the variable editor can quickly cause problems if they share the same name.
That's the reason we want you to choose unique and uniform variables names for your submissions. Please also label variables like "MUI" into Dragon_MUI. Btw a 3 char identifier DRA_ would be enough.
Example:
- Your spell uses the variable name "MUI".
- Another spell uses the variable name "MUI".
- An users imports both spells --> Imported variables get created.
- "MUI" does already exist --> not created a second time.
- "MUI" is used over both resource and will casues malfunction.

Don't remove the dummy from the game. "Can't raise, does not decay" deals with it.
Why do your dummies have the human inventory ability?

You want to get rid of all kind of laggs/spikes (I didn't experience them while testing)
-> Create the tail as a whole and move it along with the head.

Custom script: call RemoveLocation(udg_DRA_TempPoint00)

^This line is you accidently made two times in your "Trained" trigger. Also in same trigger you could store TriggeringUnit into a variable to prevent more function calls.

In your "Walk" trigger you don't need this "And - All (Conditions)" block.

If dragon gets order to stop or to hold position it moves staight until it gets out of map and game crashes.

If I order the dragon to move to a larger distance, it stops after short distance and begins circeling again.
It's sucky that you need to spam orders to move the dragon to wanted place. :s

Move following into your de-index part:

If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions DRA_MUI Equal to 0 Then - Actions Trigger - Turn off (This Trigger) Else - Actions [/stable] No need to check it each time. You use SetUnitX/Y for dragon. Thats ok, but you should check that it wont get out of map. First it may bug as mentioned before, and secondly it looks strange, you can test it yourself. You should improve the description and icon in object editor. Set DRA_UnitGroup = (Units within DRA_DmgRange of DRA_TempPoint001 matching ((((Matching unit) is A Building) Equals False) and ((((Matching unit) belongs to an enemy of (Owner of DRA_Trained[DRA_Loop_A_Interger])) Equals True) and (((Matching unit) is alive) Equals True)))) I would pick all units in range, set PickedUnit to a variable and then filter it. It's easier to read. Dragon looks very cool in game, I like it much. Would be cool if you could add configuration if dragon can damage buildings or not, and I don't like it very much that you create so much units periodically.

If I don't create unit periodicly then what else can I do? Moving all the unit seems outside of my triggering level O.O

 

[Tal'Rarity]

Nah I am sure you can do it, you made this which is quite epic. It is quite easy to do the next step and if it works then it might be better for less lag.

Basically you make dummy unit variables to move the tail/body of the dragon instead of constantly making leaks/creating units then killing them.

 

[Hantoo]

now I suddenly understand what bbpower trying to say... Okay I will try fix it..
But it will take time..l I may not online for a couple of days
(and suddenly get attracted in model editing even though I'm bad at it)

 

[Hantoo]

The fix is kinda hard for me... need time... and im busy kinda busy at the moment... (sometimes... i make some spell... and upload here... but i will fix this later (when im free))

 

[Kazeon]

Anything used more than once (twice) should be stored into a variable to save computation time, for instance TriggeringUnit.

Imo, 4 is still okay

 

[Tal'Rarity]

Going to have to be some complex math because I haven't even been able to figure out how to even get a tail to work with that.

BPower it'd be nice if you stepped in showing a tutorial of some sort since it is what you suggested otherwise I don't think this guy will be able to figure it out because I am having quite the difficulty myself.

 

[Hantoo]

thx... and im still not A pro yet...

 

[Darkfang]

If you want it to deal damage just use a damage detection system and use the damage area action with an specific amount (by example 0.10 universal spell damage) then detect it via damage detection and alterate the damage for the amount you want, you can even add ratios for a hero, this could be an awesome hero if it had a kick ass protrait.

BTW it is not a chinese dragon until it makes a zigzag move; therefore you could make it loose height and gain it periodicaly.