[JASS] Checking AI Difficulity problem (+rep to be given)

[HamzahA]

hello. i have this trigger, when i run the map it shows NOTHING.

function PutToArrays takes nothing returns nothing
    local integer i=0
    loop
        exitwhen i>11
               if (GetPlayerController(Player(i))==MAP_CONTROL_COMPUTER ) then
        if GetAIDifficulty(Player(i))==AI_DIFFICULTY_NEWBIE then
            set udg_PlayerIsEasy[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Easy!" ) )
        elseif GetAIDifficulty(Player(i))==AI_DIFFICULTY_NORMAL then
            set udg_PlayerIsNormal[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Normal!" ) )
        elseif GetAIDifficulty(Player(i))==AI_DIFFICULTY_INSANE then
            set udg_PlayerIsInsane[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Insane!" ) )
        endif
        endif
        set i=i+1
    endloop
endfunction


//===========================================================================
function InitTrig_TEMP takes nothing returns nothing
    set gg_trg_TEMP = CreateTrigger(  )
    call TriggerAddAction( gg_trg_TEMP, function PutToArrays )
    call TriggerRegisterTimerEventSingle( gg_trg_TEMP, 2.01 )
endfunction

 

[Flame_Phoenix]

Mmm, First, try correction you identation, it is hard to understand your code.
Second, if nothing happens then it is because you skipped all ifs ... Your conditions are surely wrong... I don't remind seeing computer level "newbie"...
Anyway, try also using BJDebugMsg("text). It will display a text and is actually good for debugging, which is your trouble.

 

[HamzahA]

allright
What i want is to check each AI player (computer player) difficulity (or level), and set them in a global variable.
i tried many ways and it didnt work

for this trigger, nothing displays, when i removed the first condition "if (GetPlayerController(Player(i))==MAP_CONTROL_COMPUTER ) then" it displayed all users are Normal AI Players (even unused slots).

thats enough explaining?

 

[Flame_Phoenix]

function PutToArrays takes nothing returns nothing
    local integer i=0
    loop
        exitwhen i>11
            if (GetPlayerController(Player(i))==MAP_CONTROL_COMPUTER ) then
                call BJDebugMsg("I am computer" + I2S(i))
            endif
        set i=i+1
    endloop
endfunction

Your report seems quite strange. Try running this small test to see if all slots are visited correctly.
If not, then we know where our problem really is.

 

[HamzahA]

still nothing showed.

 

[HamzahA]

i just tried !=MAP_CONTROL_USER as the condition (for your trigger), and only un-used slots showed as bots!

wtf!?!

 

[spiwn]

I have the suspicion that MAP_CONTROL_USER is not what you think it is
I will just check this.
My bad - it is.
I wounder are your "computer" players defined as computer players in the Player settings?

 

[HamzahA]

nope.
they are choosable, to make ai before starting game via slots.

 

[Earth-Fury]

hello. i have this trigger, when i run the map it shows NOTHING.

function PutToArrays takes nothing returns nothing
    local integer i=0
    loop
        exitwhen i>11
               if (GetPlayerController(Player(i))==MAP_CONTROL_COMPUTER ) then
        if GetAIDifficulty(Player(i))==AI_DIFFICULTY_NEWBIE then
            set udg_PlayerIsEasy[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Easy!" ) )
        elseif GetAIDifficulty(Player(i))==AI_DIFFICULTY_NORMAL then
            set udg_PlayerIsNormal[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Normal!" ) )
        elseif GetAIDifficulty(Player(i))==AI_DIFFICULTY_INSANE then
            set udg_PlayerIsInsane[i] = true
            call DisplayTextToForce( GetPlayersAll(), ( GetPlayerName(Player(i)) + " Insane!" ) )
        endif
        endif
        set i=i+1
    endloop
endfunction


//===========================================================================
function InitTrig_TEMP takes nothing returns nothing
    set gg_trg_TEMP = CreateTrigger(  )
    call TriggerAddAction( gg_trg_TEMP, function PutToArrays )
    call TriggerRegisterTimerEventSingle( gg_trg_TEMP, 2.01 )
endfunction

Cleaned up your code:

function PutToArrays takes nothing returns nothing
    local integer i = 0
    loop
        exitwhen i > 11
        if GetPlayerController(Player(i)) == MAP_CONTROL_COMPUTER then
            if GetAIDifficulty(Player(i)) == AI_DIFFICULTY_NEWBIE then
                set udg_PlayerIsEasy[i] = true
                call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, GetPlayerName(Player(i)) + " Easy!")
            elseif GetAIDifficulty(Player(i)) == AI_DIFFICULTY_NORMAL then
                set udg_PlayerIsNormal[i] = true
                call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, GetPlayerName(Player(i)) + " Normal!")
            elseif GetAIDifficulty(Player(i)) == AI_DIFFICULTY_INSANE then
                set udg_PlayerIsInsane[i] = true
                call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, GetPlayerName(Player(i)) + " Insane!")
            endif
        endif
        set i = i + 1
    endloop
endfunction

function InitTrig_TEMP takes nothing returns nothing
    set gg_trg_TEMP = CreateTrigger()
    call TriggerAddAction(gg_trg_TEMP, function PutToArrays)
    call TriggerRegisterTimerEvent(gg_trg_TEMP, 2.01, false)
endfunction

Works fine as far as I can see... displays the proper AI difficulties for all computer-controlled slots.

 

[HamzahA]

i tried that, and still nothing displays!
did u test it?

 

[Flame_Phoenix]

MMm maybe you'll have to change something in the advanced settings of the map =S
There is little we can do, we need more info.

 

[spiwn]

If it is no problem upload the map.

 

[HamzahA]

ok i will upload the map.
but i hope none edits it but when its needed.
and please tell me what u did so i can learn.

ps use jassnewgen pack

 

[spiwn]

Hm that is I said if it is no problem.
Map is at begging - no problem.
Map has stuff in it - problem
To prevent abuse a Personal message to someone trusted is recommended.

 

[HamzahA]

nah i just deleted all scripts and crated a copy then posted it.
it cant be restored.

 

[HamzahA]

i am waiting . . .

 

[Flame_Phoenix]

MMM, your map seems to be fine ... but i'll give a better look to it later :S
You can always reinstall wc3 if it is a weird bug from your computer =P

 

[spiwn]

lol
That is drastic

 

[HamzahA]

did u test it on your pc..?
i mean did the message display or not in YOUR pc?!

 

[HamzahA]

should i wait for a miracle to get answered or what?

 

[Flame_Phoenix]

Are you sure everything is Ok ?
Because when i ran the map in WE nothing happened :S

Found 3 problems when debugging:
1 - The name of your trigger doesn't match the call function. Your trigger is called TEMP copy 2, but the function is calling TEMP - an error should occur here

2 - You have something in the map's header that is conflicting with the trigger, thus making it not be fired: Since map's header is the only trigger working, deleting it will make the TEMP copy 2 trigger be fired.

3 - Finally, your conditions seem to be all wrong, because although the loop is started, it skips all If's. Why ? dunno...

Also you should work on your identation ... it is horrible to understand code like that...

 

[HamzahA]

so should i check all players alone without loops?

 

[spiwn]

Definitely not.

 

[Flame_Phoenix]

Mmmm, try something like this:

if ((GetPlayerController(Player(i))==MAP_CONTROL_COMPUTER) == true) then

It may work ... there is a weird reason for this ..

 

[HamzahA]

OH MY GOD IT WORKED! SUPER UBER KUBER MIRACLE!
here is what i did:
i converted all conditions to booleans
AND TESTED THE MAP ON MULTIPLAYER!
then it just worked )) thanks alot guys.

 

[Flame_Phoenix]

Yeeeee =D
Just a weird unknown bug from Blizzard. I knew this bug existed but never though it could affect this kind of ckeck.
Glad I could help =)