Can't Save Data to Hashtable

[leonguyen112]

After a day woking with hastable, I've got some troubles. So I made this trigger for a little test.

• Events
  • Player - Player 1 (Red) types a chat message containing -key as A substring
• Conditions
  • (Length of (Entered chat string)) Equal to 6
• Actions
  • Set Temp_String = (Substring((Entered chat string), 6, 6))
  • Hashtable - Save (Integer(Temp_String)) as 2 of 2 in ItemData
  • Set Temp_Integer = (Load 2 of 2 from ItemData)
  • Set Temp_String = (String(Temp_Integer))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • Temp_String Equal to Empty String
    • Then - Actions
      • Game - Display to (All players) the text: no text
    • Else - Actions
      • Game - Display to (All players) the text: Temp_String

Whatever I enter in it, it always return "0", even number or not. I changed the integer to string and it returned "no text". Then I realized there's something wrong with my saving. Can't it be saved to hashtable or did I save it in the wrong way?

 

[UndeadImmortal]

I believe it is in the first condition.
the -key has a length of 4 letters.
- = 1
k = 2
e = 3
y = 4

 

[leonguyen112]

Yes, "-key" has 4 letters, but in game, I usually type "-key " + [an integer]
- = 1
k = 2
e = 3
y = 4
[space] = 5
and an integer is the 6th one.

 

[defskull]

A Hashtable is used to save data to a certain object, from the way I see it, you have no reference of an object, it will return as null (0).

Object such as Unit, Ability, Item, etc.

For example:
You want to save an Integer value '5' to a Unit 'Caster' with a childKey of '0' in 'ItemData' hashtable.
Here's how you save/load it;

• Actions
  • -------- SAVING --------
  • Set Object = (Triggering unit)
  • Custom script: set udg_parentKey = GetHandleId(udg_Object)
  • Set childKey = 0
  • Set SavedValue = 5
  • Hashtable - Save SavedValue as childKey of parentKey in ItemData
  • -------- ///////////////////// --------
  • -------- LOADING --------
  • Set Object = (Triggering unit)
  • Custom script: set udg_parentKey = GetHandleId(udg_Object)
  • Set childKey = 0
  • Set SavedValue = (Load childKey of parentKey from ItemData)
  • Game - Display to (All players) the text: (String(SavedValue))

Now tell me, what do you intend to do ?
Perhaps we can re-construct the trigger - I think we don't even have to use Hashtable for this.

Solution:

• String Comparison
  • Events
    • Player - Player 1 (Red) types a chat message containing -key as A substring
  • Conditions
  • Actions
    • Set TempString = (Entered chat string)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Length of TempString) Equal to 6
      • Then - Actions
        • Set TempInt = (Player number of (Triggering player))
        • Set SavedValue[TempInt] = (Integer((Substring(TempString, 6, 6))))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (String(SavedValue[TempInt])) Equal to <Empty String>
          • Then - Actions
            • Game - Display to (All players) the text: null
          • Else - Actions
            • Game - Display to (All players) the text: (String(SavedValue[TempInt]))
      • Else - Actions

TempString - String
TempInt - Integer
SavedValue[array] - Integer

 

[leonguyen112]

I made a similar trigger of your example, mine is:

• Events
  • Player - Player 1 (Red) types a chat message containing -key as A substring
• Conditions
  • (Length of (Entered chat string)) Equal to 6
• Actions
  • -------- SAVE CODE --------
  • Set Temp_String = (Substring((Entered chat string), 6, 6))
  • Set Temp_Integer = (Integer(Temp_String))
  • Set Hashtable_ChildKey = 0
  • Custom script: set udg_Hashtable_ParentKey = GetHandleId( udg_Hero )
  • Hashtable - Save Temp_Integer as Hashtable_ChildKey of Hashtable_ParentKey in ItemData
  • -------- LOAD CODE --------
  • Set Hashtable_ChildKey = 0
  • Custom script: set udg_Hashtable_ParentKey = GetHandleId( udg_Hero )
  • Set Temp_Integer = (Load Hashtable_ChildKey of Hashtable_ParentKey from ItemData)
  • Set Temp_String = (String(Temp_Integer))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • Temp_String Equal to Empty String
    • Then - Actions
      • Game - Display to (All players) the text: no text
    • Else - Actions
      • Game - Display to (All players) the text: Temp_String

and I still got the 0 value. (Hero is a unit variable and is set by another trigger)

What do I tend to do? Well, initially, I thought hashtable is a kind of variable which uses 2 key to save/load value so I tried to make a item data storage. Example:

Save 45 as 1 of ItemID in ItemData
Save 5 as 2 of ItemID in ItemData
Save 500 as 3 of ItemID in ItemData
Save ... as ... of ItemID in ItemData​

• ItemID is an integer id of a specific type of item and is set manually
• 1 is an integer key of "damage"
• 2 is an integer key of "armor"
• 3 is an integer key of "HP"

So I can load damage, armor, HP of an item by loading its value from hashtable ItemData.

But this idea seems to be ruined because I still can't save/load value to hashtable.

 

[Imp Midna]

First of all, you dont actually need the value of an object handle. A Wc3 hashtable is exactly what you said it was. Therefor, you OP should have worked allready.
Which brings us to the weird part: your usage of the hashtable seems totally fine to me. In fact, i actually ended up copying your trigger just to find that it worked perfectly. Which means the error lies somewhere where we can't see at. Like, did you actually save a valid hashtable into that variable? xD

 

[defskull]

Have you set ItemData to a Hashtable yet ?

Here's a test map.

 

[Dr Super Good]

Have you set ItemData to a Hashtable yet ?

To elaborate, the variable defaults to null. For you to use a hashtable you first need to make one. In an initialization trigger you need to set the variable to a hashtable. In GUI this requires you running the action to make the hashtable before you can set a variable to the last created hashtable.

 

[deathismyfriend]

To elaborate, the variable defaults to null. For you to use a hashtable you first need to make one. In an initialization trigger you need to set the variable to a hashtable. In GUI this requires you running the action to make the hashtable before you can set a variable to the last created hashtable.

lol i always forget about that for GUI.

 

[leonguyen112]

Thank to defskull's test map, I finally understood how a hashtable works. I couldn't save value to a hashtable because I didn't have this action

• Custom script: set udg_ItemData = InitHashtable()

Now I have a new question, what is the max size of hashtable's keys? They must have some limit.

 

[defskull]

8191.

 

[Dr Super Good]

8191.

That is an array...

Now I have a new question, what is the max size of hashtable's keys? They must have some limit.

Same range as signed 32 bit integer, the type of integer WC3 uses. Obviously they have no range as they are hashtables.

 

[deathismyfriend]

Same range as signed 32 bit integer, the type of integer WC3 uses. Obviously they have no range as they are hashtables.

they do have a range its just a ridiculously high amount. It is the max 32 bit integer. Here it is 2,147,483,647

 

[Imp Midna]

In fact, both hashtables accept negative keys, therefor allowing the full range of 2^32 to be used.

 

[deathismyfriend]

In fact, both hashtables accept negative keys, therefor allowing the full range of 2^32 to be used.

ooo i didnt know they allowed for negative keys lol

 

[defskull]

But remember !
Hashtable has a limit of 255, so make a full use of one Hashtable (make sure the data doesn't collide, though).

 

[Dr Super Good]

Also hashtables degrade in performance as the amount of data stored in them increases. Consider using separate hashtables for long-term storage (where speed is not too critical) from short-term storage (where speed is critical).