[JASS] Simple Chat System Problem

[Dreadnought[dA]]

scope AddChatMessage

globals
    multiboard array MB [11]
    integer MB_COUNTER = 0
    force ALL_PLAYERS = CreateForce()
    string TEMP_STRING
    boolean TEMP_BOOLEAN
    integer TEMP_INTEGER
    player TEMP_PLAYER
    string array MB_STRINGS [11][9]
    integer array MB_CHATSIZE [11]
endglobals

private function UpdateMultiboard takes nothing returns nothing
    local integer p = GetPlayerId(GetEnumPlayer())
    local integer a = 0
    
    if (IsPlayerAlly(Player(p), TEMP_PLAYER) == true) or (TEMP_BOOLEAN == true) or (Player(p) == TEMP_PLAYER) then
        loop
            call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a + 1])
            set MB_STRINGS[a] = MB_STRINGS[a + 1]
            set a = a + 1
            exitwhen a >= MB_CHATSIZE - 1
        endloop
        
        if Player(p) != TEMP_PLAYER then
            set MB_STRINGS[a] = "[|cffff9200" + GetPlayerName(TEMP_PLAYER) + "|r] " + TEMP_STRING
        elseif TEMP_BOOLEAN == true then
            set MB_STRINGS[a] = "[|cffff0000Allies|r]: " + TEMP_STRING
        else
            set MB_STRINGS[a] = "[|cff6464ffAllies|r]: " + TEMP_STRING
        endif
        
        call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a])
    endif
endfunction

private function Actions takes nothing returns nothing
    local string s = GetEventPlayerChatString()
    
    if SubString(s, 0, 1) == "+" then
        if SubString(s, 1, 2) == "+" then
            set TEMP_BOOLEAN = true
            set TEMP_STRING = SubString(s, 2, StringLength(s))
        else
            set TEMP_BOOLEAN = false
            set TEMP_STRING = SubString(s, 1, StringLength(s))
        endif
        
        set TEMP_PLAYER = GetTriggerPlayer()
        call ForForce(ALL_PLAYERS, function UpdateMultiboard)
    endif
    
    set s = null
endfunction

//===========================================================================
function InitTrig_AddChatMessage takes nothing returns nothing
    set gg_trg_AddChatMessage = CreateTrigger()
    
    call TriggerAddAction(gg_trg_AddChatMessage, function Actions)
endfunction

endscope

The problem is, whenever I type something with "++" in front of it, the next thing I type erases it.

I attached an image that shows the problem.

 

[Dreadnought[dA]]

Not 1 reply?

 

[Dreadnought[dA]]

Still not 1 reply?

 

[Element of Water]

Try changing this

loop
    set MB_STRINGS[a] = MB_STRINGS[a + 1]
    call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a])
    set a = a + 1
    exitwhen a >= MB_CHATSIZE - 1
endloop

To this

loop
    exitwhen a >= MB_CHATSIZE - 1
    set MB_STRINGS[a] = MB_STRINGS[a + 1]
    call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a])
    set a = a + 1
endloop

And don't get so angry when people don't reply. It's a hard question to answer. I had to bump a thread 4 times once before I got a reply (over a course of over a week). I didn't get so angry...

 

[GhostWolf]

I simply don't get the above code.

 

[Dreadnought[dA]]

I don't get why it will help...

Tested and it didn't.

I simply don't get the above code.

My code or his code?

 

[GhostWolf]

My code or his code?

Your code. Giving your variables better names would make this so much readable.

 

[Dreadnought[dA]]

Your code. Giving your variables better names would make this so much readable.

MB = Multiboards... Seems pretty simple and straightforward to me.
MB_STRINGS = Each line of chat on each multiboard. Given it's a 2D array, I think that would be easy to figure out.
MB_CHATSIZE = The maximum size each chatboard is (how many lines of chat it displays).

Does that clear things up?

Hopefully I don't have to explain the rest lol

 

[GhostWolf]

It actually did clear a few things.

In any case, the only problem I could see is that MB_CHATSIZE[i] is never updated.
As in, when someone types a correct line (+...) MB_CHATSIZE[p] should be increased, and if a row goes out of the multiboard, it should be decreased.

 

[Dreadnought[dA]]

MB_CHATSIZE is the maximum size of the chat, not the current number of lines typed.

Also I don't even have a way of altering it yet. That shouldn't be the problem. I've tested this in about 30 different ways and I think it's the wierdest bug *EVER* encountered. (not even the wierdest bug I have encountered, but that anyone has encountered)

try inserting

call BJDebugMsg(MB_STRINGS[a])

Right after

        call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a])

at the end of the

UpdateMultiboard

function

The

        call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRINGS[a])

displays a different value than what it says it is set to. Maybe newgen 2D arrays fail? I think I'll make my own 2D array and test.

 

[Dreadnought[dA]]

library TwoDimensionalArrays

function TwoDim takes integer x, integer y returns integer
    return x * 10 + y
endfunction

endlibrary

My own 2D array function

scope AddChatMessage

globals
    multiboard array MB [11]
    force ALL_PLAYERS = CreateForce()
    string TEMP_STRING
    boolean TEMP_BOOLEAN
    integer TEMP_INTEGER
    player TEMP_PLAYER
    string array MB_STRINGS [11][9]
    string array MB_STRING
    integer array MB_CHATSIZE [11]
endglobals

private function UpdateMultiboard takes nothing returns nothing
    local integer p = GetPlayerId(GetEnumPlayer())
    local integer a = 0
    
    if IsPlayerAlly(Player(p), TEMP_PLAYER) or TEMP_BOOLEAN or Player(p) == TEMP_PLAYER then
        loop
            set MB_STRING[TwoDim(p, a)] = MB_STRING[TwoDim(p, a + 1)]
            call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRING[TwoDim(p, a)])
            set a = a + 1
            exitwhen a >= MB_CHATSIZE - 1
        endloop
        
        if Player(p) != TEMP_PLAYER then
            set MB_STRING[TwoDim(p, a)] = "[" + GetPlayerNameColored(TEMP_PLAYER) + "] " + TEMP_STRING
        elseif TEMP_BOOLEAN then
            set MB_STRING[TwoDim(p, a)] = "[|cffff0000All|r]: " + TEMP_STRING
        else
            set MB_STRING[TwoDim(p, a)] = "[|cff6464ffAllies|r]: " + TEMP_STRING
        endif
        
        call MultiboardSetItemValue(MultiboardGetItem(MB, a, 0), MB_STRING[TwoDim(p, a)])
        call BJDebugMsg(MB_STRING[TwoDim(p, a)])
    endif
endfunction

private function Actions takes nothing returns nothing
    local string s = GetEventPlayerChatString()
    
    if SubString(s, 0, 1) == "+" then
        if SubString(s, 1, 2) == "+" then
            set TEMP_BOOLEAN = true
            set TEMP_STRING = SubString(s, 2, StringLength(s))
        else
            set TEMP_BOOLEAN = false
            set TEMP_STRING = SubString(s, 1, StringLength(s))
        endif
        
        set TEMP_PLAYER = GetTriggerPlayer()
        call ForForce(ALL_PLAYERS, function UpdateMultiboard)
    endif
    
    set s = null
endfunction

//===========================================================================
function InitTrig_AddChatMessage takes nothing returns nothing
    set gg_trg_AddChatMessage = CreateTrigger()
    
    call TriggerAddAction(gg_trg_AddChatMessage, function Actions)
endfunction

endscope

IT WORKS!!! Except the BJDebugMsg is displaying the opposite still. But it's working

 

[GhostWolf]

Lol.