Calling a function

[phuc1570]

Hi guys, I'd like to kno what is more OP. For example
I have 2 functions: 1 is Hinit and the other is afplayer
So if I do (see the bold text)

function main takes nothing returns nothing
.....
call ExecuteFunc("Hinit")
call afplayer()
endfunction

which one is faster, more efficient and optimized. Thanks,

 

[Halo7568]

With a simple setup like this:

function runthis takes nothing returns nothing
    
endfunction

function act1 takes nothing returns nothing
    local integer i = 0
    local integer sw
    set sw = StopWatchCreate()
    loop
        exitwhen (i == 1000)
        
        call ExecuteFunc("runthis")
        
        set i = i + 1
    endloop
    call StopWatchMark(sw)
    call StopWatchDestroy(sw)
endfunction

function act2 takes nothing returns nothing
    local integer i = 0
    local integer sw
    set sw = StopWatchCreate()
    loop
        exitwhen (i == 1000)
        
        call runthis()
        
        set i = i + 1
    endloop
    call StopWatchMark(sw)
    call StopWatchDestroy(sw)
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_006 takes nothing returns nothing
    local trigger t
    set t = CreateTrigger(  )
    call TriggerAddAction( t, function act1 )
    call TriggerRegisterPlayerChatEvent( t, Player(0), "checkspeed1", true )
    set t = CreateTrigger(  )
    call TriggerAddAction( t, function act2 )
    call TriggerRegisterPlayerChatEvent( t, Player(0), "checkspeed2", true )
endfunction

The ExecuteFunc loop takes about .009 seconds whereas the normal runthis() call takes about .0007 seconds. With that sort of time, a normal function call is more than ten times faster.

Keep in mind these numbers are for running a function 1000 times inside of a loop. Which you pick for a function call that occurs once is basically insignificant.

 

[phuc1570]

Thanks, you adds action twice, ChatEvent checkspeed2 only does act2 ? How did you measure it to the exact milisecond? I don't see any DebugMessage or DisplayTextToPlayer..

 

[Halo7568]

checkspeed1 runs act1, and checkspeed2 runs act2.

I was using the StopWatch plugin for a tool of mine http://www.wc3c.net/showthread.php?t=109232
There is a certain amount of overhead that is introduced to function calls with the tool though, so the times might be off by something like .000020 in my case above.

 

[muzzel]

Its not only a difference of performance. With normal function calls you can pass arguments and take returned values, that doesnt work with ExecuteFunc. But ExecuteFunc starts the function in a new thread which helps if you have problems with the op limit (but there are other ways to do that, like nulltimer or ForGroup ...
ExecuteFunc is rarely used, anyway in rare situations calling functions via Strings (the functions name) can be quite useful.

 

[mckill2009]

ExecuteFunc is not so optimizerd and dynamic as it cant contain any arguments than just
calling, the pros of ExecuteFunc is that its doent require the order of calls
whereas the other requires that it must be below the called function...

 

[phuc1570]

I see. Many thanks to your replies.
In castle fight 1.22a, there're quite many ExecuteFunc s which make it not so Op.

 

[Arhowk]

than castle fight uses GUI because u cant call functions in gui only execute..

 

[Dr Super Good]

Calling it directly should be faster acording to logic. Handling those pointers even in compiled languages takes extra cycles.

 

[muzzel]

than castle fight uses GUI because u cant call functions in gui only execute..

Thats wrong, you cannot use ExecuteFunc in GUI. You are mixing this up with TriggerExecute, which is used in GUI as a replacement for function calls, but its two completely different things.

 

[mckill2009]

Thats wrong, you cannot use ExecuteFunc in GUI. You are mixing this up with TriggerExecute, which is used in GUI as a replacement for function calls, but its two completely different things.

• Events
  • Timer - Elapsed Game Time 0
• Conditions
• Actions
  • Custom script: call ExecuteFunc("haha")
  • Custom script: endfunction
  • Custom script: function haha takes nothing returns nothing
  • Game - Display text message "wrong!"

 

[muzzel]

haha ur so funny