Bouncing Ball v1.5

[Moderator]

19:58, 19th Dec 2010
The_Reborn_Devil:

My review.


Status: Approved
Rating: Useful

 

[Dr. Boom]

Bouncing Ball v1.0

Moin moin =)

==== My personal vote: APPROVAL 4/5 ====

First of all, I remember this spell ^^. Wasn't you the one, who posted here in Hive a problem, where the ball doesn't disappear or something?^^ Edit: Ahh I red the description, you was it ok.

Spell review:
- Triggering looks good only one thing, you should add the action in the If-Then-Else Part where you check if "BB_Jumps[BB_Index3] Equal to 0", after you kill the dummy the following line:

• Set BB_Dummy[BB_Index3] = No unit

to clear the unit variable.

- Only to make it very very exactly: You should set the BB_Angle from 0.01 to 360.00, because 0.00 and 360.00 are the same ^^

- Else I can't see anything that miss here, only in your Triggerfolder "Bouncing Ball" you typed "Inforamtion" but I think you mean "Information" ^^

- The idea: Actually it isn't hard to create a random bouncing ball, but I don't see something like that before and I like the spell.

Edit: I saw you use a imported "dummy.mdx". Is this the one from "Vexorian"? ( I think he create one too ). If it is, then type in the description "Thanks to Vexorian for the dummy.mdx" ( just to fit the rules here ... ), if it's not - ignore this^^

Edit 2: And for those who say: "Omg why you use in the loop " BB_Index3 Not equal to 0"?". I said it to him, when he asked for help, because without this if, the spell doesn't work at all. After adding this, it works, so if you say something about this, this belongs to me then.

So all in all, this spell can get approval and I think 4/5 is ok here, -1 because it's actually very easy to create a random bouncing ball =)

Greetings and Peace
Dr. Boom

 

[Nightmare Moon]

Thanks again for the tips, updating...
Edit: updated.

 

[Tank-Commander]

Not much to add, however I'm pretty sure:

• Unit - Create 1 Dummy for (Owner of BB_Caster[BB_Index2]) at (Position of BB_Caster[BB_Index2]) facing Default building facing degrees
• Special Effect - Create a special effect at (Position of BB_Dummy[BB_Index3]) using Objects\Spawnmodels\Undead\UDeathSmall\UDeathSmall.mdl

would cause a leak remember to set a variable to the point of the unit and then use that =P

 

[Maker]

Why is this the first action in the loop? It shouldn't be.

• Custom script: call RemoveLocation(udg_BB_Point[udg_BB_Index3])

This location is not removed:

• Set BB_Point[BB_Index3] = (Position of BB_Dummy[BB_Index3])

Additional leak:

• Set BB_Point2[BB_Index3] = ((Position of BB_Dummy[BB_Index3]) offset by 10.00 towards BB_Angle[BB_Index3] degrees)

This

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • BB_Index Equal to 0
  • Then - Actions
    • Set BB_Index2 = 0
    • Trigger - Turn off (This trigger)
  • Else - Actions

should be right after this:

• Set BB_Index = (BB_Index - 1)

These can be executed even if the unis is set to null:

Trigger

• -------- Moving ball to next point --------
• Set BB_Point2[BB_Index3] = ((Position of BB_Dummy[BB_Index3]) offset by 10.00 towards BB_Angle[BB_Index3] degrees)
• Unit - Move BB_Dummy[BB_Index3] instantly to BB_Point2[BB_Index3]
• -------- Removing leaks --------
• Custom script: call RemoveLocation(udg_BB_Point2[udg_BB_Index3])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • BB_Index Equal to 0
  • Then - Actions
    • Set BB_Index2 = 0
    • Trigger - Turn off (This trigger)
  • Else - Actions

You should save the level to a variable, since the caster can level it up while the ball is bouncing:

• Unit - Set level of Bouncing Ball Dummy for (Last created unit) to (Level of Bouncing Ball [|c0020c000B|r] for BB_Caster[BB_Index3])

I like the spell, but you should make the flight more smooth. Use a parabola equation.

 

[Nightmare Moon]

Updated, made changes that you said guys said, i guess, because i updated spell long time and forgot to add it here on Hive, so now it's fully leakless and MUI.
Suggestions are welcome...

 

[watermelon_1234]

I don't really have anything to add to this except to point out some petty stuff along with location leaks.

• • Set BB_Ability = Bouncing Ball [|c0020c000B|r]
  I would probably do this in a map initialization trigger because you probably don't need to keep doing this whenever the spell is cast.
• • Set BB_Angle[BB_Index2] = (Random real number between 0.01 and 360.00)
  Why 0.01? 0 is fine as you can tell when you do the second trigger.
• • Unit - Create 1 Dummy for (Owner of BB_Caster[BB_Index2]) at (Position of BB_Caster[BB_Index2]) facing Default building facing degrees
  Location leak.
• Hm, I don't think there's any real point with using the BB_Reals when you set the parabola.
• • Special Effect - Create a special effect at (Position of BB_Dummy[BB_Index3]) using Objects\Spawnmodels\Undead\UDeathSmall\UDeathSmall.mdl
  • Set BB_Point2[BB_Index3] = ((Position of BB_Dummy[BB_Index3]) offset by BB_Speed[BB_Index3] towards BB_Angle[BB_Index3] degrees)
  Both these location leaks can be removed if you do
  • Set BB_Point[BB_Index3] = (Position of BB_Dummy[BB_Index3])
  earlier. Note that this should be done outside the if structure otherwise the ball might not move correctly.

 

[The Reborn Devil]

Moderator Review:

first review

You need to give credits to moyack for the parabola equation you're using. Other than that the triggering looks okay. However, in the trigger Bouncing Ball loop, you should put this outside the if-statement:

• Set BB_Point3[BB_Index3] = (Position of BB_Dummy[BB_Index3])

Or else this might not work:

• Set BB_Point2[BB_Index3] = (BB_Point3[BB_Index3] offset by BB_Speed[BB_Index3] towards BB_Angle[BB_Index3] degrees)

You also do not need this:

• Custom script: call RemoveLocation(udg_BB_Point[udg_BB_Index3])

As the location BB_Point is only set one time, and that is in Bouncing Ball Cast, and you are already destroying it there.

Second review:

The triggers look okay now.

 

[mckill2009]

isnt this trigger...

• Unit - Create 1 Dummy for (Owner of BB_Caster[BB_Index2]) at BB_Point[1] facing Default building facing (270.0) degrees

suppose to be...

BB_Point[BB_Index2]

and this one...

• Set BB_Expire[BB_Index3] = (BB_Expire[BB_Index3] - BB_Speed[BB_Index3])

suppose to be...

• Set BB_Expire[BB_Index3] = (BB_Expire[BB_Index3] - 0.03)

 

[Nightmare Moon]

isnt this trigger...

Unit - Create 1 Dummy for (Owner of BB_Caster[BB_Index2]) at BB_Point[1] facing Default building facing (270.0) degrees

suppose to be...

BB_Point[BB_Index2]

yep, didn't see that, thanks.

and this one...

Set BB_Expire[BB_Index3] = (BB_Expire[BB_Index3] - BB_Speed[BB_Index3])

suppose to be...

Set BB_Expire[BB_Index3] = (BB_Expire[BB_Index3] - 0.03)

nope, i need to subtract speed here so it would be right.

 

[mckill2009]

hehe, I really didnt see this...

Random real number between 150.00 and 300.00

 

[Noobsmoke]

what about recycling ?

 

[Maker]

The bounce looks a lot better than when I first tested the spell. Good job.

Still some things to improve. Try to make the tooltip a bit more like standard Blizzard ability. Look how damage is listed in the research tooltip for example. You could list the cooldown too.

These could be set at initialization trigger, somewhere it only runs once. The BBIndex4 check will run every time the spell is cast.

• Set BB_Ability = Bouncing Ball [|c0020c000B|r]
  • Set BB_SpecialEffect = Objects\Spawnmodels\Undead\UDeathSmall\UDeathSmall.mdl

You are not recycling BBIndex4. So the max cast count is 8191. After the no casts can be made.

Why not 0 and 360?

• Set BB_Angle[BB_Index2] = (Random real number between 1.00 and 360.00)

None of the point variables should be arrays, since you are not storing the data to be used at a later loop. Now they being arrays just slow things down, without any benefit.

This is not needed:

• Unit - Remove Crow Form from BB_Dummy[BB_Index3]

You could have these at the very last else:

• Set BB_Point3[BB_Index3] = (Position of BB_Dummy[BB_Index3])
• -------- Moving ball to next point --------
• Set BB_Point2[BB_Index3] = (BB_Point3[BB_Index3] offset by BB_Speed[BB_Index3] towards BB_Angle[BB_Index3] degrees)
• Unit - Move BB_Dummy[BB_Index3] instantly to BB_Point2[BB_Index3]
• -------- Removing leaks --------
• Custom script: call RemoveLocation(udg_BB_Point2[udg_BB_Index3])
• Custom script: call RemoveLocation(udg_BB_Point3[udg_BB_Index3])

Set the food cost of the dummies to 0, and why not point value also.

 

[Nightmare Moon]

Hmmm, i know what you're saying.

These could be set at initialization trigger, somewhere it only runs once. The BBIndex4 check will run every time the spell is cast.
Set BB_Ability = Bouncing Ball [|c0020c000B|r]
Set BB_SpecialEffect = Objects\Spawnmodels\Undead\UDeathSmall\UDeathSmall.mdl

In previous version i typed that those action should be in init trigger, but now i created another index, so yes i need to recycle it, i would better create init trigger with those actions, instead of recycling.

Why not 0 and 360?
Set BB_Angle[BB_Index2] = (Random real number between 1.00 and 360.00)

I don't remember but someone told that there's no point settings it zero because it will be same angle as 360, maybe he was right, but okay, i'll set it to 0.

This is not needed:
Unit - Remove Crow Form from BB_Dummy[BB_Index3]

Yeas, i guess so.

You could have these at the very last else:
Set BB_Point3[BB_Index3] = (Position of BB_Dummy[BB_Index3])
-------- Moving ball to next point --------
Set BB_Point2[BB_Index3] = (BB_Point3[BB_Index3] offset by BB_Speed[BB_Index3] towards BB_Angle[BB_Index3] degrees)
Unit - Move BB_Dummy[BB_Index3] instantly to BB_Point2[BB_Index3]
-------- Removing leaks --------
Custom script: call RemoveLocation(udg_BB_Point2[udg_BB_Index3])
Custom script: call RemoveLocation(udg_BB_Point3[udg_BB_Index3])

It won't make any difference at all anyway.

Set the food cost of the dummies to 0,

Oh i forgot about that.

and why not point value also.

So you say that i should set point-vaue to zero too, but i have a question, what point-value is used for anyway?

Edit: Updating...

 

[Maker]

It won't make any difference at all anyway.

There can be a loop where you don't need the stuff, but set it anyway

 

[Nightmare Moon]

Updated.
Made all changes like you said except for description of spell, because every map has its unique description of spells, i didn't do it, and what's the point of typing cooldown when it's zero.
So my point is that everyone should make their own description, like me (i don't make it in my spells).
Thanks for tips Maker.

 

[Garfield1337]

You should set,in object editor,for Dummy 2 these fields' value...
Art - Animation - Cast Backswing
Art - Animation - Cast Point
...to 0.
That would make the dummy cast the thunder clap instantly making the ball bounce prettier.
The spell is nice overall.