BotL - Coding & Systems

[Malhorne]

Ok I'll remove the line.

 

[T. D. W.]

I think that may be causing the bug.. Instinct, tell me where will the new code be..

 

[Malhorne]

I corrected the last code I posted

 

[T. D. W.]

works now !

 

[Malhorne]

Ah ok

 

[T. D. W.]

actually, no
2 bugs, one in Dot and one in the stats

In Stats
it looks like only ONE stack gets removed after the timeout, and others get permanent
In DoT
lol, now it damages only one time after the first period, and no more damage xD

 

[Malhorne]

Dafuk oO ?

 

[Malhorne]

I can't understand this oO !!!!
Maybe my linked list got wrong :/

 

[T. D. W.]

here have fun, this is the map, test it and when you finish tell me

 

[Malhorne]

 

[T. D. W.]

i know i know, JAWS xD
sorry, but i still don't code vJASS, maybe rewriting the codes from scratch?

 

[Malhorne]

I'll see through ...

 

[T. D. W.]

okay

 

[Malhorne]

Dude the download is fucked I can't download the map >_<

 

[T. D. W.]

here is the pastebin link

 

[Malhorne]

Okay I'm gonna eat first ...

 

[T. D. W.]

xD okay

 

[Malhorne]

Ohmagad my download software just got broken oO

 

[Malhorne]

AT LAST VICTORY MANAGED TO DOWNLOAD IT xD

 

[T. D. W.]

you're kidding me right... doesn't your browser download stuff by itself?

 

[T. D. W.]

oh okay, nvm

 

[Malhorne]

Dude your triggers to initiate globals can be merged and more efficient
I'll do so if you want

 

[T. D. W.]

yes do whatever u want, just tell me the changes so i don't get lost xD

 

[Malhorne]

Okay merging two globals triggers.
You're messing initializations
Use struct initializer to be more efficient

 

[T. D. W.]

i still have no ideas how to use structs dude

 

[Malhorne]

Ok no problem I'll merge some JASS code to be better.
I just merged the globals triggers.

 

[T. D. W.]

native GetHeroId takes nothing returns integer

told u that ^

 

[Malhorne]

What the .... are you saying xD ?

Anyway I'll suggest this when creating spell :

scope SpellName
//CONFIGURATION
    globals
        private constant integer SPELL_ID = 'XXXX'
        //Some more things that needs configuration
    endglobals

    //Some private constant function that could be cool like damage calculation or something
//END CONFIGURATION

    private struct SpellName extends array
        private static method cond takes nothing returns boolean
            //Do the stuff
            return false
        endmethod
        
        private static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            call TriggerRegisterAnyUnitEvent(t, ....)
            call TriggerAddCondition(t, Condition(function thistype.cond))
            set t = null
        endmethod
    endstruct
endscope

 

[T. D. W.]

U... Forgot the initiliazation :/

 

[Malhorne]

No problem it is just for the JESP manifesto and for the initialization thingy

Anyway I'll resend you the map.
I didn't fix anything in DoT and Stats but can you create some example where it leads to bug ? I'll still searching during ...

 

[T. D. W.]

XD wrong paste in that quote, try this native, it is non sense, it always gives 0 since GetHeroId(nothing) xD

 

[Malhorne]

http://www.hiveworkshop.com/forums/pastebin.php?id=2826hl

 

[T. D. W.]

Test the map, use the spells with bow sister, the active spell generate DoT, and the green marksmanship generates the bonus stat

 

[Malhorne]

Ah ok ...
But where are the code where you call the funcs ?

 

[T. D. W.]

I can't use the map if DoT and Sats aren't fixed :/ i need them to continue

 

[T. D. W.]

In the Damage library folder, the 2nd trigger, bow sister scope

 

[Malhorne]

Ok ...

 

[chobibo]

The initial damage won't cause the bug though... I see you really don't trust me, instinct tells you my suggestion causes bugs. I'm rage-quitting this shit.

 

[Malhorne]

He wanted to test without and it makes bugs yes :/

 

[Malhorne]

Dude the active thingy destroy only trees U_u
http://www.hiveworkshop.com/forums/pastebin.php?id=2826hl

 

[chobibo]

He wanted to test without and it makes bugs yes :/

Doesn't matter anymore, I'm quitting this.

 

[T. D. W.]

What?
It destroy trees, damage enemy units, poison them and applies DoT
If not all work, then umust have done something wrong.. Cuz they work for me

 

[Malhorne]

Download the map.... You'll see...

 

[T. D. W.]

the problem is that array globals don't get initialized >>

the poisoned arrow has 0.000 damage factor >> no damage >> no damage detection which leads to >> no DoT >> no Poison >> NOTHING

 

[Malhorne]

Try this for DoT I just tested it and no problem :

library DoT
    globals
        private constant real FPS = 0.0100
    endglobals
    
    struct DoT extends array
        private unit caster
        private unit target
        private real interval   
        private real during
        private real dmg
        private real temp
        private static integer count
        private thistype prev
        private thistype next
        private static timer period
        
        private static method iterate takes nothing returns nothing
            local thistype this = thistype(0)
            loop
                set this = this.next
                exitwhen this == 0
                set this.temp = this.temp + FPS
                if this.temp >= this.interval then
                    call UnitDamageTarget(this.caster, this.target, this.dmg, true, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, null)
                    set this.temp = this.temp-this.interval
                endif
                set this.during = this.during - FPS
                if this.during <= 0 then
                    call this.destroy()
                endif
            endloop
        endmethod
        
        static method add takes unit cast, unit targ, real dur, real inter, real dm returns nothing
            local thistype this
            
            if thistype(0).prev == 0 then
                set count = count + 1
                set this = count
            else
                set this = thistype(0).prev
                set thistype(0).prev = thistype(0).prev.prev
            endif
            
            if thistype(0).next == 0 then
                call TimerStart(period, FPS, true, function thistype.iterate)
            else
                set thistype(0).next.prev = this
            endif
            
            set this.next = thistype(0).next
            set thistype(0).next = this
            set this.prev = thistype(0)
            
            set this.caster = cast
            set this.target = targ
            set this.interval = inter
            set this.during = dur
            set this.dmg = dm
            set this.temp = 0
        endmethod

        private method destroy takes nothing returns nothing
            if this.next != 0 then
                set this.next.prev = this.prev
            endif
            
            set this.prev.next = this.next
            set this.prev = thistype(0).prev
            set thistype(0).prev = this
        
            if thistype(0).next == 0 then
                call PauseTimer(period)
            endif

            set this.caster = null
            set this.target = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set count = 0
            set period = CreateTimer()
        endmethod
    endstruct
endlibrary

 

[Malhorne]

Omg sorry for the map forgot to implement Module >_<
I updated the pastebin.
Now seeing the prob with DoT.

 

[T. D. W.]

you got me confused, what should i do with the DoT and the map now ><

 

[Malhorne]

Map get mine.
DoT dunno.

 

[Malhorne]

Its kinda strange for DoT since debug message appears well

 

[Malhorne]

Updated the bin -> DoT seems to work well.
Now could you explain me the prob with Stats pls ?
http://www.hiveworkshop.com/forums/pastebin.php?id=2826hl