BotL - Coding & Systems

[T. D. W.]

actually, this is the need of the dummy.mdl , attach Fxs on it

anyway Bon8

 

[chobibo]

You guys make me

 

[T. D. W.]

EDITED: Fixed

 

[Malhorne]

What fixed xD ?

 

[T. D. W.]

a variable type was missing in the udg_ globals, and i had no idea how to fix it, so i deleted the variable and re created it xD

 

[Malhorne]

Ahah Weird Editor strikes again
The only udg we'll use are from imported ressources otherwise use globals blocks is better

 

[T. D. W.]

yes, i know, i made globals: Unit and Grp >> most used locals>> and global variables for spell constants"
KB3D is the best thing, really, not that i am the leader of it, but seriously it save like 80% of coding time!

Oh and i created a custom version with more features of the KB3D JUST for BotL xDD

 

[Malhorne]

Nice

 

[chobibo]

globals aren't as fun anymore

 

[T. D. W.]

Why? And why were they?

 

[chobibo]

Because... nvm.

 

[Malhorne]

Because you have to null them xD

 

[T. D. W.]

Malhorne, chobibo, i need 2 systems for the BotL but since i guess it needs Table to make, which i don't know how to use yet, you guys are the ones

so the 2 systems are easy:
DPS (stackable)
TimedStatBonus (gives bonus stat then removes it after time)

the kind of funtion:

DPS:

function ApplyDPS takes unit target, unit source, real amount, real timeout returns nothing
//Damage Type is SPELL, Attack Type is MAGIC

TimedStatBonus:

function AddTimedStatBonus takes unit hero, integer amount, integer statType, real timeout returns nothing

 

[chobibo]

Malhorne can whip that up in minutes.

 

[T. D. W.]

i noticed him, and just a notice:
AddTimedStatBonus << this adds Alacrity as Base points, not bonus ones

 

[Malhorne]

On the road before eating.

 

[Malhorne]

What is DPS XD ?
I'll do the timedstats soon

 

[T. D. W.]

DPS >> just damage the target from source by amount damage every second for timeout seconds

 

[Malhorne]

library DoT
    globals
        private constant real FPS = 0.0312500
    endglobals
    
    struct DoT extends array
        private unit caster
        private unit target
        private real interval
        private real during
        private real dmg
        private real temp
        private static integer instanceCount
        private thistype prev
        private thistype next
        private static timer period
        
        private static method iterate takes nothing returns nothing
            local thistype this = thistype(0)
            local integer i
            loop
                set this = this.next
                exitwhen this == 0
                set this.temp = this.temp + FPS
                if this.temp > this.interval then
                    call UnitDamageTarget(this.caster, this.target, this.dmg, true, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, null)
                    set this.temp = this.temp-this.interval
                endif
                set this.during = this.during - FPS
                if this.during < 0 then
                    call this.destroy()
                endif
            endloop
        endmethod
        
        static method add takes unit cast, unit targ, real dur, real inter, real dm returns nothing
            local thistype this
            
            if thistype(0).prev == 0 then
                set instanceCount = instanceCount + 1
                set this = instanceCount
            else
                set this = thistype(0).prev
                set thistype(0).prev = thistype(0).prev.prev
            endif
            
            if thistype(0).next == 0 then
                call TimerStart(period, FPS, true, function thistype.iterate)
            else
                set thistype(0).next.prev = this
            endif
            
            set this.next = thistype(0).next
            set thistype(0).next = this
            set this.prev = thistype(0)
            
            set this.caster = cast
            set this.target = targ
            set this.interval = inter
            set this.during = dur
            set this.dmg = dm
            set this.temp = 0
        endmethod

        private method destroy takes nothing returns nothing
            if this.next != 0 then
            set this.next.prev = this.prev
        endif
            
        set this.prev.next = this.next
        set this.prev = thistype(0).prev
        set thistype(0).prev = this
        
        if thistype(0).next == 0 then
            call PauseTimer(period)
        endif

        set this.caster = null
        set this.target = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set instanceCount = 0
            set period = CreateTimer()
        endmethod
    endstruct
endlibrary

 

[T. D. W.]

An example of usage plz

 

[Malhorne]

This can be used to :
caster deals dmg to target every interval during during

 

[T. D. W.]

What is da function ??

 

[Malhorne]

DoT.add(cast,targ,during,interval,dmg)

 

[T. D. W.]

Okay, now i'll wait the stat one

 

[Malhorne]

Incoming.
No table needed I think because I don't really consider they are stacking since you can add different type of stats.
And Hashtable are still slow xD

 

[Malhorne]

But you will be able to stack them (YOU CANT USE multiplier value just add )

 

[T. D. W.]

what?
one of the skills that will use this will give 1 alacrity on each successful attack, so it MUST stack
i didn't understand the rest

 

[Malhorne]

library TimedStats

    globals
        private constant real FPS = 0.0312500
    endglobals
    
    //1 : Strength
    //2 : Agility
    //3 : Intelligence
    struct TimedStats extends array
        private unit targ
        private real temp
        private integer amount
        private integer type
        private thistype prev
        private thistype next
        private static timer period
        private static integer count
        private static HandleTable tab
        
        private static method periodic takes nothing returns nothing
            local thistype this = thistype(0)
            loop
                set this = this.next
                exitwhen this == 0 
                set this.temp = this.temp -FPS
                if this.temp < 0 then
                    if this.type==1 then
                        call SetHeroStr(this.targ, GetHeroStr(this.targ, false)-this.amount, false)
                    elseif this.type==2 then
                        call SetHeroAgi(this.targ, GetHeroAgi(this.targ, false)-this.amount, false)
                    elseif this.type==3 then
                        call SetHeroInt(this.targ, GetHeroInt(this.targ, false)-this.amount, false)
                    debug else
                        debug call BJDebugMsg("You entered the wrong number for the stats thingy")
                    endif
                    call this.destroy()
                endif
            endloop
        endmethod
        
        static method AddTimedStatBonus takes unit targ, integer i, integer stats, real time returns nothing
            local thistype this
            if thistype(0).prev == 0 then
                set this = thistype(0).prev
                set thistype(0).prev = thistype(0).prev.prev
            else
                set count = count + 1
                set this = count
            endif
            if thistype(0).next == 0 then
                call TimerStart(period, FPS, true, function thistype.periodic)
            else
                set thistype(0).next.prev = this
            endif
            set this.next = thistype(0).next
            set thistype(0).next = this
            set this.prev = thistype(0)
            set this.targ = targ
            set this.amount = i
            set this.type = stats
            set this.temp = time
            if i==1 then
                call SetHeroStr(targ, GetHeroStr(targ, false)+amount, false)
            elseif i==2 then
                call SetHeroAgi(targ, GetHeroAgi(targ, false)+amount, false)
            elseif i==3 then
                call SetHeroInt(targ, GetHeroInt(targ, false)+amount, false)
            debug else
                debug call BJDebugMsg("You're giving wrong number for the stats thingy")
            endif
        endmethod
        
        private method destroy takes nothing returns nothing
                if this.next != 0 then
                    set this.next.prev = this.prev
                endif
                set this.prev.next = this.next
                set this.prev = thistype(0).prev
                set thistype(0).prev = this
                if thistype(0).next == 0 then
                    call PauseTimer(period)
                endif
                set this.targ = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set count = 0
            set period = CreateTimer()
            set tab = HandleTable.create()
        endmethod
    endstruct
endlibrary

I made no test at all you need to do this


Ah wait ...
You want this to refresh the timeout each time it happens ?

 

[T. D. W.]

call AddTimedStatBonus(unit, integer, integer, real)
like this?

 

[T. D. W.]

You want this to refresh the timeout each time it happens ?

no each addition is individual

 

[Malhorne]

call TimedStats.AddTimedStatBonus(targ,amount,typeOfStats,timeout)

 

[Malhorne]

Holy shit made a mistake in DoT :

library DoT
    globals
        private constant real FPS = 0.100
    endglobals
    
    struct DoT extends array
        private unit caster
        private unit target
        private real interval   
        private real during
        private real dmg
        private real temp
        private static integer instanceCount
        private thistype prev
        private thistype next
        private static timer period
        
        private static method iterate takes nothing returns nothing
            local thistype this = thistype(0)
            loop
                set this = this.next
                exitwhen this == 0
                set this.temp = this.temp + FPS
                if this.temp > this.interval then
                    call UnitDamageTarget(this.caster, this.target, this.dmg, true, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, null)
                    set this.temp = this.temp-this.interval
                endif
                set this.during = this.during - FPS
                if this.during < 0 then
                    call this.destroy()
                endif
            endloop
        endmethod
        
        static method add takes unit cast, unit targ, real dur, real inter, real dm returns nothing
            local thistype this
            
            if thistype(0).prev == 0 then
                set instanceCount = instanceCount + 1
                set this = instanceCount
            else
                set this = thistype(0).prev
                set thistype(0).prev = thistype(0).prev.prev
            endif
            
            if thistype(0).next == 0 then
                call TimerStart(period, FPS, true, function thistype.iterate)
            else
                set thistype(0).next.prev = this
            endif
            
            set this.next = thistype(0).next
            set thistype(0).next = this
            set this.prev = thistype(0)
            
            set this.caster = cast
            set this.target = targ
            set this.interval = inter
            set this.during = dur
            set this.dmg = dm
            set this.temp = 0
        endmethod

        private method destroy takes nothing returns nothing
            if this.next != 0 then
            set this.next.prev = this.prev
        endif
            
        set this.prev.next = this.next
        set this.prev = thistype(0).prev
        set thistype(0).prev = this
        
        if thistype(0).next == 0 then
            call PauseTimer(period)
        endif

        set this.caster = null
        set this.target = null
        endmethod
        
        private static method onInit takes nothing returns nothing
            set instanceCount = 0
            set period = CreateTimer()
        endmethod
    endstruct
endlibrary

 

[T. D. W.]

Okay don't worry, i didn't implemented it yet

 

[chobibo]

What were you talking about at VM dude? Where?

 

[Malhorne]

See the code of the DoT last page
Linked list for allocate/deallocate/iterat

 

[chobibo]

Oh, the circularly linked list? It's cool! But it's rather pointless now that I know globals need nulling, the supposed advantage over Knuth shuffle (thanks to Nestharus for this piece of info) is negligible. I'm no longer a speed freak, so...

Anyways, congratulations to you for having written your linked list iteration in vjass haha xD.

Add a debug allocator dude, it sucks to not know if that one is failing, and believe me, fuckups happen all the time, speed isn't an issue in object allocation, since your not going to allocate en masse. The list iteration is good though. Oh and don't use a real for an iterator countdown, use an integer, calculate the numbers of iteration the DoT requires to damage the unit. The unit must also be damaged on cast so you should decrement the iteration counter by one when starting the DoT. A 1/32 period isn't good for a DoT period, try 1/10, the precision is pointless.

Oh and sorry for my rumblings, I'm just happy today that old people are coming back to modding.

 

[Malhorne]

OK I'll change the period

Oh and don't use a real for an iterator countdown

I'm using an integer if I see well

 

[T. D. W.]

Malhorne, DoT causes a bug, since the DoT is applied when units take damage from a specific dummy... the caster will deal the DoT... but it weirdly interferes with damage event by LFH

 

[Malhorne]

I you have a DDS ...
SO yes it bugs with DDS...

 

[Vinz]

It's weird I never use it..

 

[T. D. W.]

why should it bug????
if i don't apply the DoT, the damage occurs normally

 

[Malhorne]

What do you mean ?

 

[T. D. W.]

if i don't use the function to apply DoT, the damage detected by the DDS works normally, with the system implemented
BUT when i apply the DoT, the damage detected by the DDS doesn't work

 

[Vinz]

The DDS bugs for me. I think it's the criminal. :/

 

[T. D. W.]

Oh, wait, i think i have an idea of why the DDS bugs... Just gonna check it and i'll reply on it

 

[T. D. W.]

nevermind, i thought it was caused because the actions where in a condition, but it's the same with action
now the question is:

WHY does it bug with the DDS???

 

[Malhorne]

Because it is code dmg I think ...

 

[T. D. W.]

Wait, does your Dot system's first damaging starts when the Dot is appllied or after the first interval?

 

[Malhorne]

Yes I added this now.

 

[T. D. W.]

mmmm, try to remove it: like:

Apply >> no damage
after first period >> damages
>> continues till end