Black Hole Real [v2.0]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

20:46, 10th Oct 2011
Pharaoh_: Rejected for being too simple.

GroupClear() doesn't destroy the group. Use set bj_wantDestroyGroup = true before the enumeration action. Currently leaks this part and most of the point variables.

Remove the wait from the loop.

Rejected, since it's not MUI and it leaks.

 

[Magtheridon96]

spet

??

• Custom script: set bj_wantDestroyGroup = true
• -------- -------------------------------------------- --------
• -------- Knockback starts here / a dummy will do the knockback. Just follow the trigger, I think its easy to be understand. --------
• -------- -------------------------------------------- --------
• Custom script: set bj_wantDestroyGroup = true

Why are you doing it twice?
Do it once.

You should use unit variables to store data like (Last created unit) so you don't have to repeat the functions again and again and again ...

For example:

• Unit - Create 1 Casting Dummy / knockback for (Owner of (Triggering unit)) at TargetLoc facing 0 degrees
• Unit - Add Knockback to (Last created unit)
• Unit - Set level of Knockback for (Last created unit) to 1
• Unit - Order (Last created unit) to Human Mountain King: Storm Ray (Picked unit)
• Unit - Add a 3.00 second Generico expiration timer to (Last created unit)

->

• Unit - Create 1 Casting Dummy / knockback for (Owner of (Triggering unit)) at TargetLoc facing 0 degrees
• Set TempUnit = (Last created unit)
• Unit - Add Knockback to TempUnit
• Unit - Set level of Knockback for TempUnit to 1
• Unit - Order TempUnit to Human Mountain King: Storm Ray (Picked unit)
• Unit - Add a 3.00 second Generico expiration timer to TempUnit

You could do the same thing for Owner of Triggering Unit for the entire trigger.

Oh and your screenshot seems Photoshopped

 

[Kratoz-X]

i dont like use variables for now im learning that confuses my brain :S
anywways it works and a friend of mine from w3 campaigns telled to me i need do that twice i dont know why :S

i taked screenshot from ingame bit site bont support tga so i used a tool i downloaded here

 

[Magtheridon96]

anywways it works and a friend of mine from w3 campaigns telled to me i need do that twice i dont know why :S

Using it twice would be pointless.
It's like doing this:

set i = 0
set i = 0

If i is already 0, why should I set it to 0?

i dont like use variables for now im learning that confuses my brain :S

Well, you better get used to it :/

 

[Kratoz-X]

Using it twice would be pointless.
It's like doing this:

set i = 0
set i = 0

If i is already 0, why should I set it to 0?



Well, you better get used to it :/

about variables i use it PURE LUCK i make it target point and with 3 hours
about set it twice is true but im learning so........

 

[Magtheridon96]

Remember to update your triggers in the description when you make an update.

 

[Kratoz-X]

and that means...........?
what you mean with that

 

[Zaio]

The triggers you posted in [ TRIGGER ] [ /TRIGGER ] tags in the spells description, he means to update them when you change the triggers so we can view the new code without comenting on the old code.

 

[Maximum_Evil]

Looks great, but I got instant killed when cast onself

 

[maddeem]

1. Instant knock back.
2. Doesn't effect units who just decide to walk in.
3. Why do you have 2 Custom script: set bj_wantDestroyGroup = true. One is literally placed right after the other. Plus this is supposed to right before you use a unit group. Hell, I'm not sure, but it might leak if you don't put right before a unit group.
4. The "I'm learning" thing, fix your mistakes
5. If your spell fits into about 20 lines of code, it ain't worth downloading.

My criticism may not be entirely uplifting but it's pretty straight forward. Now if you were to add/fix the things I mentioned, this spell would actually be quite nice. Also when making spells please try to stay away from imports.

 

[GangSpear]

I suggest before you posting spell go Trigger & Scripts put there and give maker check or Pharoah

 

[Gopinich]

lol
The spell is good if you make only one spell. The Death and Decay and the Knocback aren't need to be casted by dummy. You can make a looping trigger kill any unit in the core and knockback the targets. Some little idea: 1)Hide the unit which killed in the core. 2)What do you think about spiral knockback?
Like the models.

 

[Vladadamm]

The knockback happen only when spell is cast and not after if an enemy enter spell area of effect. The spell affect allyes (caster include).

 

[makai]

the wave model was created by mello.. credit him for it...

 

[Vercas]

There ain't no blue black-holes!

 

[Kratoz-X]

@makai ok mello? ok i will do it
@Vladadamm working on that i mastered circular points ^^
@Gopinich spiral? that is a gooood idea
@maddeem man is my first be patient i will fix it

 

[xIceShotx]

You can put reals that always stay the same in a spell init. ||| Or if you ever change the number again, you can still do the same thing but only the first sets of them for example:
Set bla bla bla[1] = 532
Set bla bla bla[2] = 536
Set bla bla bla[3] = 538
-----------------------
Set bla bla bla[1] = 632
Set bla bla bla[2] = 836
Set bla bla bla[3] = 938
-- -- -- -- -- -- -- -- --
The first set of variables can go in a spell init, while the second set stays in the main trigger.

 

[Kratoz-X]

i think tht will be tooo many triggers
im currently watching over jass to make it mui nd leakless easly
plus that (original idea) is to use damage formulas

• Set BH_Damage[1] = (Int Of BH_Caster)x(3)

And i hav the plan of an "spell init" but i think tht will be too many triggers

 

[xIceShotx]

i think tht will be tooo many triggers
im currently watching over jass to make it mui nd leakless easly
plus that (original idea) is to use damage formulas

• Set BH_Damage[1] = (Int Of BH_Caster)x(3)

And i hav the plan of an "spell init" but i think tht will be too many triggers

No, you only need need to add "One" more trigger only witch is the "Spell Init" and having a spell init is better than putting the settings in the main trigger because every time you cast the spell, it resets it and it isn't even required, just put it in spell init so then it doesn't have to reset itself for no reason
-Edit-
Its okay to add one more trigger because its only a one time thing, That's if you use Map initialization ofc.

 

[xIceShotx]

btw, when i cast it on myself, it knocks me back too and stuns me...

 

[forthelols]

some units not pulled in!

I noticed that only organic units were being pulled in. Buildings, mechanical and air should also be affected. Also can you get rid of that chronosphere model...unecessary... the black hole looks cool without it. Anyway good job on the spell. Definitely UNIQUE!

 

[Kratoz-X]

I noticed that only organic units were being pulled in. Buildings, mechanical and air should also be affected. Also can you get rid of that chronosphere model...unecessary... the black hole looks cool without it. Anyway good job on the spell. Definitely UNIQUE!

i think it looks good with cronosphere and currently learning jass to make it MUI beause i fing not-too-easy make it MUI on GUi beause one you learn JASS gui becames useless for you in spells