Binding Poison 1.3.2

[Moderator]

Moderator: Pharaoh_ Date: 18:59, 22nd Apr 2012 Could be further improved, but it's approvable. Useful Old review • The way you are damaging the units is not user-friendly. If one user wants to damage for 50 static damage, the loop trigger forces that damage to be multiplied by the level of the caster's ability. Store the damage with the array, like BP_RealDamage[BP_integer]. • Storing the AoE_Effect, when you instantly destroy it is not needed. Just use Special Effect - Destroy (Last created special effect). • You still don't configure the special effects' paths, such as AnimateDeadTarget, ImmolationTarget and AnimateDeadTarget in your BPDuration trigger. • The Pause's duration (Storm bolt ability) should be 0 in the Object Editor, so that a user can manage everything in the spell only by triggers. Do not forget to check if the target has other instances running on it, before removing the buff, otherwise previous endings of duration will dissolve the effect of the newer instances. • Skip remaining actions is not necessary, especially when they are in the end of an if then else branch and after a trigger turn-off. • Set Art - Death time of the dummy to 0. • You don't need to store the caster's special effect, especially when you use the AnimateDeadTarget effect. It does not have a stand animation anyway. Just destroy it right after it has been used in BPCasting (don't forget to additionally remove the action of destruction in the BPDuration trigger). Older review • Rename the triggers; their names are too generic (speaking of the ones specifically used by this spell). • Use global variables in the map initialization trigger (or even better, create a map initialization trigger for this spell only, to init values), in order to configure special effect paths (string variables). Mark the "duration" variable with a comment, to let a user noticeably know that this variable pertains to duration of the spell per level. • Stun the unit, like Maker suggested in his review. Use Storm Bolt-based ability, with a duration of 0 and remove the buff, when the instance has ended. Make sure you check if that particular index'd target has more than one instances running on it, before removing the buff. This will help you a) to avoid removing the buff, in case other instances are used on the same unit, b) avoid spamming the special effects on the target more than once. • Use Stats - Hide Minimap Display = True for the dummy. • Avoid posting the triggers over and over again in the description, for every update. Use the triggers of the current version. • It's more preferable to use the sfx on the target, not on a dummy, this will save performance. Make configurable values for the attachment points as well (e.g. "origin"/"chest"/etc.). Spell is good otherwise.

 

[Adiktuz]

It is not MUI... learn how to use dynamic indexing or hashtables...

and use Triggering Unit rather than Casting unit, its better...

 

[eubz]

I can't save maps in versions with hastables. That's actually the problem.

 

[Adiktuz]

why? you can still use dynamic indexing...

 

[Tank-Commander]

I'd also suggest adding some height onto that lightning effect by using AddLightningEx - this is so that it won't stick to the ground.
If you need to know how to use it I'd suggest looking at other spells with it, there are quite a few.

Also if you have problems with hashtables, just use dynamic indexing.

 

[eubz]

I have found the dynamic indexing. I'll update this soon. BTW, thanks for the comments.
EDIT:
that still uses hash...

 

[Adiktuz]

mind telling us what happens when u use hashes?

 

[eubz]

mind telling us what happens when u use hashes?

When I try to save in the TFT version that can use hastables, all triggers are being disabled. It says there are some errors and plenty of them. Even the triggers used for melee maps cannot be saved. IDK.

 

[Adiktuz]

what version is your wc3? and are you using JNGP?

and oh, you can use dynamic indexing without hashes... dynamic indexing was already there versions before hashes were added...

 

[eubz]

I am still using 1.23 because of that problem.

 

[Adiktuz]

update to 1.26 and if ur using JNGP, make sure you get the latest download...

JNGP using Cohadar's Jass helper

 

[Chaosy]

You gave me a nice idea for my spell to the 2012 challange here. Sorry for stealing your idea

 

[Matarael]

I had problems with Hashtables until I started using JassNewGenPack you might want to try using that, eubz.

 

[maddeem]

If anyone leaves good advice on how to make something MUI let me be the first. If you simply cannot use hashtables then use a indexing system without hashtables.
Example: Bribe's Indexer
Or, use JNPG and do custom script hashtables (Or regular editor for that matter, though it might not compile without jasshelper)
Example:

• Custom script: call SaveInteger( udg_Hashtable, 0, 0, 100 )

Either way will work, if possible update Warcraft 3 to the latest patch as well.

 

[eubz]

Hello, here is the new trigger for this spell. I guess, there is still something wrong. Could someone tell me why the effect per second is disabled when some other hero cast the same spell here?

TheNewTrigger

• Start
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Binding Poison
  • Actions
    • -------- Dont change anyhting here --------
    • Set Index[0] = (Index[0] + 1)
    • Set TimeIndex = Index[0]
    • Set EffectIndex = (Custom value of Target[Index[0]])
    • Set time_multiplier[TimeIndex] = 2.00
    • Game - Display to (All players) for 3.00 seconds the text: (String(Index[0]))
    • -------- I am setting some thing her to fire in the next trigger --------
    • Set Caster[Index[0]] = (Triggering unit)
    • Set TempCasterPosition[Index[0]] = (Position of (Triggering unit))
    • Set Target[Index[0]] = (Target unit of ability being cast)
    • Set TempTargetPosition[Index[0]] = (Position of (Target unit of ability being cast))
    • -------- Now adding some effects --------
    • Special Effect - Create a special effect at TempTargetPosition[Index[0]] using Abilities\Spells\NightElf\Immolation\ImmolationTarget.mdl
    • Set SpecialEffect_chest[EffectIndex] = (Last created special effect)
    • Special Effect - Create a special effect attached to the origin of Target[Index[0]] using Abilities\Spells\NightElf\CorrosiveBreath\ChimaeraAcidTargetArt.mdl
    • Set SpecialEffect_origin[EffectIndex] = (Last created special effect)
    • Lightning - Create a Mana Flare lightning effect from source TempCasterPosition[Index[0]] to target TempTargetPosition[Index[0]]
    • Set Lightning[EffectIndex] = (Last created lightning effect)
    • -------- I also set the damage for easy reach --------
    • -------- you can reset the values below --------
    • Set DamageGiven[Index[0]] = 20.00
    • Set DamageMultiplier[Index[0]] = 15.00
    • -------- don't touch here --------
    • Set PoisonLevel[Index[0]] = (Level of Binding Poison for Caster[Index[0]])
    • Set Damage_A[Index[0]] = ((Real(PoisonLevel[Index[0]])) + DamageMultiplier[Index[0]])
    • Set Damage = (Damage_A[Index[0]] + DamageGiven[Index[0]])
    • Set time[TimeIndex] = (((Real(PoisonLevel[Index[0]])) x time_multiplier[Index[0]]) + 5.00)
    • -------- custom script below will remove leaking locations --------
    • Custom script: call RemoveLocation(udg_TempCasterPosition[udg_Index[0]])
    • Custom script: call RemoveLocation(udg_TempTargetPosition[udg_Index[0]])
    • -------- everything is ready to fire on the next trigger --------
    • Trigger - Turn on Casted <gen>
    • -------- now, the ability will take effect --------
• Casted
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • -------- starting the effect by setting the time --------
    • Set time[TimeIndex] = (time[TimeIndex] - 1.00)
    • Game - Display to (All players) for 1.50 seconds the text: (String(time[TimeIndex]))
    • -------- the effect of the ability --------
    • -------- I decided to pause the unit affected by the ability --------
    • Unit - Pause Target[Index[(Integer A)]]
    • -------- below is how the target gets the damage --------
    • Unit - Cause Caster[Index[0]] to damage Target[Index[(Integer A)]], dealing Damage damage of attack type Spells and damage type Normal
    • -------- -------------------------------------------------------------------------------------------------------- --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • time[TimeIndex] Greater than or equal to 1.00
      • Then - Actions
        • Lightning - Destroy Lightning[EffectIndex]
      • Else - Actions
    • -------- -------------------------------------------------------------------------------------------------------- --------
    • -------- if everything is done, this trigger will close for the next use of this ability --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • time[TimeIndex] Less than or equal to 0.00
            • (Life of Target[Index[0]]) Equal to 0.00
      • Then - Actions
        • Unit - Unpause Target[Index[0]]
        • -------- Special effects destroyed at this point --------
        • Special Effect - Destroy SpecialEffect_chest[EffectIndex]
        • Special Effect - Destroy SpecialEffect_origin[EffectIndex]
        • -------- ------------------------------------------------------------------------------------------------------------ --------
        • -------- \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ --------
        • -------- AoE Units are affected just once --------
        • -------- Units sorrounding the enemy unit as target of ability being cast are also affected but after the effect of the ability. The AoE is set to 512.00 as default. --------
        • -------- You can disable or delete the actions below that runs the AoEso the ability will not have AoE --------
        • -------- \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ --------
        • -------- Setting something good for AoE --------
        • -------- You can reset the values below --------
        • Set AreaMultiplier[Index[0]] = 10
        • Set Damage_Area[Index[0]] = 390.00
        • -------- Don't try to touch anything below --------
        • Set AoE[Index[0]] = (PoisonLevel[Index[0]] x AreaMultiplier[Index[0]])
        • Set AoEReal[Index[0]] = ((Real(AoE[Index[0]])) + Damage_Area[Index[0]])
        • Set DamagedUnits[Index[0]] = (Units within AoEReal[Index[0]] of (Position of Target[Index[0]]))
        • Unit Group - Pick every unit in DamagedUnits[Index[(Integer A)]] and do (Actions)
          • Loop - Actions
            • Unit - Cause Caster[Index[0]] to damage (Picked unit), dealing Damage damage of attack type Spells and damage type Normal
        • Custom script: call DestroyGroup(udg_DamagedUnits[udg_Index[0]])
        • -------- ------------------------------------------------------------------------------------------------------------ --------
        • -------- and turned off this trigger --------
        • Trigger - Turn off (This trigger)
      • Else - Actions
    • -------- Spell Done --------
    • -------- -------------------------------------------------------------------------------------------------------- --------

 

[Adiktuz]

Well you still only run the last instance and are not looping thru all of them... the one referenced with Index[0]... and oh, Integer A is non-existent on your trigger becoz its not inside a For integer A loop...

 

[eubz]

Thanks, I have updated the spell.

 

[Adiktuz]

You should make Abil level an array too if you will be using it that way... and maybe separate the triggers into three blocks?

and position of caster causes a leak...

you should do this:

add this line at the cast trigger before you create the dummy
set TempPoint = Position of Caster[index]

use TempPoint on the dummy creation action

then add this line at the end of the trigger

Custom script: call RemoveLocation(udg_TempPoint)

 

[eubz]

Yeah, I haven't seen that in a rush.

 

[Adiktuz]

TempPosition whatsoever and DamageGroup should not be an array... AbilLevel is the one that needs to be an array...

I suggest removing the checking part which checks if the dummy is dead and move those actions inside of it to the second if-then-else, before anything that is currently on that block... and so remove the life timer too...

and as the mods suggest, use stun rather than pausing coz pausing is bad...

 

[Mgeterno11]

Good spell. Simple but cool. 4/5.
I have found a bug: at the last line of the trigger at the custom script you have missed the "a" letter for the Location. So please fix that.

Pic

 

[eubz]

I don't really know how to cast a stun. This new update uses dynamic indexer.

 

[Adiktuz]

You create a dummy ability based on storm bolt, edit it... make a dummy unit in-game, add the dummy storm bolt, order the dummy to cast...

 

[eubz]

Thanks Adiktuz. I did that on this update, actually I did so much update today to include: using storm bolt to stun target, some edits that the moderator requires including renaming the triggers and putting up some comments. Also, some stuff on the dummy thingy, and other updates to the spell.

 

[Pharaoh_]

eubz, please fix the damage part, just like your Frozen Shards spell, use an array to damage the units.

I am not sure by the way, why is it that when the target dies, the aoe damage effect triggers. It shouldn't trigger at all, if he died during the spell's effect.

 

[eubz]

If the target is dead and if the time is reached, both triggers the AoE Effect. Updated. Stored the damage as an array.

 

[Pharaoh_]

AoE should also be configurable with an array. You can't really use a formula within the loop trigger. Everything should be configurable on cast.

 

[Pharaoh_]

AoE + Level would result 251, 252, 253, etc. aoe, while the main comment for the aoe states 250, 500, 750, etc.. Is this indeed what you're after?
You can guide yourself through this, for future reference, because frankly, the current formula is too overpowered to use.
http://world-editor-tutorials.thehelper.net/formula.php

Damn, didn't see this:

• Set BP_DamageInflict[BP_integer] = (BP_RealDamage x (Real((Level of Binding Poison for BP_Caster[BP_integer]))))

Use this in the cast trigger, not the looping one. Also, Level of ability is already saved; use that variable for reference.

Update it with the changes I told you, it would be a lot better.

 

[eubz]

Oops, sorry 'bout the formula. Now changed.
EDIT:
Thanks, spell updated.

 

[Pharaoh_]

In the enumeration, check if matching unit belongs to an enemy of caster, not an ally of target, so as to include every enemy possible. It's early in the morning here, I didn't really spot these stuff. Make sure you update your rest spells with the same fixes.

 

[eubz]

Thanks, I'll do the updates.
EDIT:
Update done:

• Set BP_DamagedGroup = (Units within BP_AoE[BP_integer] of BP_TempTargetPosition matching (((Matching unit) belongs to an enemy of (Owner of BP_Caster[BP_integer])) Equal to True))

A slight change for the spell.

 

[Pharaoh_]

Thank you for your patience, once again. Spammed you a lot ^^