Atack Speed Library v1.01

[Moderator]

19:32, 15th Mar 2016
BPower: Rejected because there are already 3
code submission for bonus manipulation. For more information see the
conversation in the thread comments.

 

[Arad MNK]

It would be nice if you also add a 1000 ability as well. Nice library btw.

Just a suggestion:

            call UnitAddAbility(u, BonusAbilitySth)
            call SetUnitAbilityLevel(u, BonusAbilitySth, a)
            call UnitMakeAbilityPermanent(u, true, BonusAbilitySth)

I see this too repetitive. You can just use this custom BJ:

function AddAbility takes integer Abil, unit u, integer a returns nothing
    call UnitAddAbility(u, Abil)
    call SetUnitAbilityLevel(u, Abil, a)
    call UnitMakeAbilityPermanent(u, true, Abil)
endfunction

Or make u a dynamic global:

globals
    private unit u //has to be private as it's too general
endglobals

function AddAbility takes integer Abil, integer a returns nothing
    call UnitAddAbility(u, Abil)
    call SetUnitAbilityLevel(u, Abil, a)
    call UnitMakeAbilityPermanent(u, true, Abil)
endfunction

 

[zv27]

if this works with bloodlust , ufrenzy, berserk...etc? I mean, if there are any conflicts with the above.
Have you tested?

When I saw the title I thought this was an attempt to detect the attack speed but this is quite something else.Nothing interesting to me.

 

[BPower]

Please check out BonusMod and reflect if your library offers something BonusMod doesn't do.
BonusMod exists since 2009.

 

[ZiBitheWand3r3r]

@Arad MNK Thanks for suggestion
@zv27 of course it works with any AS abilities like bloodlust unholy frenzy slow, etc. It stacks: unit with slow (-25%) and with +100% AS from this library will have +75%AS
@BPower No, this Lib doesnt offer anything more then BonusMod do. True.
BonusMod works, but it is in graveyard. It has 2 math mistakes that user must fix yourself (it was commented on 1st page). Btw Im not sure but does Object Merger work with all new Windows versions?
This Lib is easy to import /3 custom abilities/. User can switch between maps and CnP abilities without macros.

Imagine what if someone wants to upload spell to spell section where hero's AS varies during this spell. Should he force users to additionally download BonusMod and expand it with AS, and tell the user to fix those 2 math mistakes?

If you decide this Lib should not be uploaded here I respect it and will remove Library.

 

[Ardenian]

Well, I am not sure what you two refer to, BonusMod-wise, but the http://www.hiveworkshop.com/forums/spells-569/jass-custom-stat-system-css-v1-5g-229885/ it more or less the same.

 

[zv27]

From the above it can be concluded the following. Constantly repeating the same systems, same shit from day to day , from year to year.What this then means?Should we remove half or more from this section?Of course not!
This system should be approved because it is very easy to import and could also be useful to people who do not like complicated things .(Of course , if everything works right)

 

[userid907]

I think you should create a timed AS modifier, this Library only give permanent AS modifier.

 

[Chaosy]

Nest also made his version of Bonusmod, he just named it Bonus though.
https://github.com/nestharus/JASS/blob/master/jass/Systems/Bonus/script.j

library Bonus /* v2.0.0.2
*************************************************************************************
*
*   Adds bonuses to units. In the ini area, these bonuses can be enabled and disabled.
*   Ranges of bonus values can also be modified.
*
*   Bonuses
*       -   Armor                   any unit                        non percent bonus
*       -   Damage                  units with attack only          non percent bonus
*       -   Agility                 hero only                       non percent bonus
*       -   Strength                hero only                       non percent bonus
*       -   Intelligence            hero only                       non percent bonus
*       -   Life                    any unit                        non percent bonus
*       -   Life Regeneration       any unit                        non percent bonus
*       -   Mana                    any unit                        non percent bonus
*       -   Mana Regeneration       units with mana only            percent bonus
*       -   Sight Range             any unit                        non percent bonus
*       -   Attack Speed            units with attack only          percent bonus
*
*************************************************************************************
*
*   */uses/*
*       */ UnitIndexer /*       hiveworkshop.com/forums/jass-resources-412/system-unit-indexer-172090/
*       */ Table /*             hiveworkshop.com/forums/jass-resources-412/snippet-new-table-188084/
*
************************************************************************************
*   SETTINGS
*/
globals
    /*************************************************************************************
    *
    *                                   PRELOAD
    *
    *   Preloads all bonus abilities. This will add a hefty load time to the map but will
    *   prevent lag in game.
    *
    *************************************************************************************/
    private constant boolean PRELOAD = false
endglobals
/*
*************************************************************************************
*
*   Bonuses
*
*       constant integer BONUS_ARMOR
*       constant integer BONUS_DAMAGE
*       constant integer BONUS_AGILITY
*       constant integer BONUS_STRENGTH
*       constant integer BONUS_INTELLIGENCE
*       constant integer BONUS_LIFE
*       constant integer BONUS_LIFE_REGEN
*       constant integer BONUS_MANA
*       constant integer BONUS_MANA_REGEN
*       constant integer BONUS_ATTACK_SPEED
*       constant integer BONUS_SIGHT
*
*   Functions
*
*       function GetUnitBonus takes unit whichUnit, integer whichBonus returns integer
*       function SetUnitBonus takes unit whichUnit, integer whichBonus, integer value returns nothing
*       function AddUnitBonus takes unit whichUnit, integer whichBonus, integer value returns nothing
*
************************************************************************************/
    //! runtextmacro BONUS_SCRIPT()
    function SetUnitBonus takes unit u, integer b, integer v returns nothing
        local boolean n
        local integer a
        local integer p
        local integer on
        local integer i
        local integer nch
        local integer nb
        debug if (not IsUnitIndexed(u)) then
            debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 60, "UNIT BONUS ERROR: INVALID UNIT")
            debug return
        debug endif
        debug if (0==pm[b]) then
            debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 60, "UNIT BONUS ERROR: INVALID BONUS TYPE")
            debug return
        debug endif
        set i=GetUnitUserData(u)
        if (v != cb[i][b]) then
            set nch=0
            if (ir[b]) then
                set n=0>v
                set cb[i][b]=v
                set p=b+pm[b]-1
                set on=p+1
                call UnitRemoveAbility(u,bo[on])
                if (n) then
                    set v=v-ps[on]
                endif
                loop
                    if (0>v-ps) then
                        call UnitRemoveAbility(u,bo)
                    else
                        call UnitAddAbility(u,bo)
                        call UnitMakeAbilityPermanent(u,true,bo)
                        set v=v-ps
                    endif
                    exitwhen p==b
                    set p=p-1
                endloop
                if (n) then
                    call UnitAddAbility(u,bo[on])
                    call UnitMakeAbilityPermanent(u,true,bo[on])
                endif
            else
                set nb=v
                set v=v-cb[i][b]
                set cb[i][b]=nb
                set a=bo[b]
                set on=b+pm[b]+1
                loop
                    loop
                        exitwhen 0<v
                        set v=v-ps[on]
                        set nch=nch+1
                    endloop
                    set p=b+pm[b]
                    loop
                        if (0<=v-ps) then
                            set v=v-ps
                            call UnitAddAbility(u,a)
                            call SetUnitAbilityLevel(u,a,bp+2)
                            call UnitRemoveAbility(u,a)
                        else
                            set p=p-1
                            exitwhen p==b
                        endif
                    endloop
                    exitwhen 0==v
                endloop
                loop
                    exitwhen 0==nch
                    set nch=nch-1
                    call UnitAddAbility(u,a)
                    call SetUnitAbilityLevel(u,a,(-bp[on])+2)
                    call UnitRemoveAbility(u,a)
                endloop
            endif
        endif
    endfunction
    function GetUnitBonus takes unit u, integer b returns integer
        return cb[GetUnitUserData(u)][b]
    endfunction
    function AddUnitBonus takes unit u, integer b, integer v returns nothing
        call SetUnitBonus(u,b,GetUnitBonus(u,b)+v)
    endfunction
endlibrary

 

[BPower]

BonusMod works, but it is in graveyard.

BonusMod is submitted on wc3.net, what is in the graveyard is not the actual version.

It has 2 math mistakes that user must fix yourself (it was commented on 1st page).

Can you link me to the comment?

Btw Im not sure but does Object Merger work with all new Windows versions?

Yes it works.

Imagine what if someone wants to upload spell to spell section where hero's AS varies during this spell. Should he force users to additionally download BonusMod and expand it with AS, and tell the user to fix those 2 math mistakes?

BonusMod is very powerful, also useful. Furthermore you can disable all bonus types you don't need.

If you decide this Lib should not be uploaded here I respect it and will remove Library.

Personally, if BonusMod is flawed ( I'm not aware of that ), I would appreciate if someone
makes a similar working resource. I'm also fine with yours. I just feel it's incomplete.

 

[ZiBitheWand3r3r]

BonusMod is submitted on wc3.net, what is in the graveyard is not the actual version.

I didnt know that. Maybe I depend on Hive to much And can't we just delete this old graveyarded version to not confuse people. Btw I also didn't know about Nestharus version on his web side. Sorry.

With 2 math mistakes I refer to this graveyarded version on Hive.
http://www.hiveworkshop.com/forums/graveyard-418/system-bonus-mod-setunitmaxstate-65622/#post1028553

for macros I found this: http://www.hiveworkshop.com/forums/spells-569/jass-custom-stat-system-css-v1-5g-229885/#post2288086

Personally I'm fan of small snippets / libraries, when user can install only those acctually needed. It seems to me I said all I want to. Do as you want.

 

[BPower]

Bonus and BonusMod can be reduced to the purpose of your submission.
You can actually decided which Bonus types should be created,
by running or not running the respective textmacro.

Then there is CSS, which is also very similar.

I'll put this one to Need Fix because I dislike the Rejected status for resources.
Contact me if you disagree.