Astral Force V1.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

12:20, 7th Apr 2015
IcemanBo: Read my post in thread.

 

[Meatmuffin]

Seems cool, but please, post the triggers.

 

[The10th-X]

Seems cool, but please, post the triggers.

Ah sorry, added them

 

[Meatmuffin]

Firstly, the oversized gif makes it harder to browse. If you could make it a little bit smaller, that would be lovely.

In the second chunk of your loop triggers, you use Picked Unit a lot of times. Better store the picked unit(s) into a variable before you call any functions with it, that way, you save some functions.

I'm not sure about this, but when checking conditions if the picked unit is alive, or an enemy, or is not a structure etc. you don't make 1 long line. You use a group (Units in range) and then make an If Then Else statement to check the conditions, and if the actions meet the conditions, they are executed.

Store Last Created Unit into a variable as well, for the same reason as for Picked Unit(s).

 

[btdonald]

You shouldn't use a FOR loop. It's seem easy to do but It's very slow. Try to use Unit Indexer or Hanky Indexer Template.

 

[The10th-X]

You shouldn't use a FOR loop. It's seem easy to do but It's very slow. Try to use Unit Indexer or Hanky Indexer Template.

Why?

It would help saying why it's bad not just saying it.

 

[IcemanBo]

Some quick notes:

- Create a config trigger, where user can define certain aspects of the spell to his needs.
- Don't hardcode, if not needed. Try to make as much configurable/setable as possible.
- OwnerOfCaster could be indexed as well.
- Something like "MUI" doesn't really belong in a variable name. It's not really matching. Current/Max -Index is much better.
- Please add some import instructions.

 

[NightSkyAurora]

You shouldn't use a FOR loop. It's seem easy to do but It's very slow. Try to use Unit Indexer or Hanky Indexer Template.

Nearly every GUI spell that is not instant needs either a for loop or unit indexer to be MUI and there is a lot of it on hive. Does that mean that every single GUI spell must use an indexer?

Why?

It would help saying why it's bad not just saying it.

If you convert for loop to custom text, you'll see that it is actually using the following syntax:

 loop
        exitwhen udg_Temp_Int > udg_Index
        // do stuff
        set udg_Temp_Int = udg_Temp_Int + 1
    endloop

Basicly the computer checks everytime if Temp_Int > Index and if not, increases Temp_Int by one. The de-index part's coding also takes a lot of space and is less inefficient. A unit indexer assign a unique custom value to every unit in a map. In that way, you can store data in an array in the same element (the container number of stored data in an array) that the unit's custom value that relates to that unit. This can be used to improve efficiency because it doesn't need that index/de-index method.