-
Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
-
Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.
Assassinate v1.1
- Status
- Joined
- Apr 24, 2012
- Messages
- 9,797
So is there a problem with the spell or you want to optimize the code?
E: Oh, okay. In the deindexing part, deindex every variable you use in the loop. Such as Slashes, etc.
E: Oh, okay. In the deindexing part, deindex every variable you use in the loop. Such as Slashes, etc.
- Joined
- Oct 16, 2011
- Messages
- 306
i'm expecting that someone will do the job for me. hahaha 
Spell Reviewer
- Joined
- Jan 18, 2005
- Messages
- 27,258
Problem 1.
Removal of non-existent group, severity unclear. Only remove a group if you actually make one as at best it will waste CPU resources and at worst could result in unknown and unwanted behaviour.
Problem 2.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. You forgot to move the slash count member resulting in corruption of slash count member which will cause incorrect and hard to predict behaviour.
Problem 3.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. A code error resulted in assignation target destination being assigned itself rather than the value of object being moved. This will result in incorrect and had to predict behaviour.
A brief test of the ability with 3 heroes owned by the same player casting at the same time demonstrates expected behaviour with no noticeable faults or errors occurring.
Here is your map. I accept both Master Card and PayPal.
(no I am not expecting a payment for this, that is a joke that should not be taken seriously)
Removal of non-existent group, severity unclear. Only remove a group if you actually make one as at best it will waste CPU resources and at worst could result in unknown and unwanted behaviour.
Problem 2.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. You forgot to move the slash count member resulting in corruption of slash count member which will cause incorrect and hard to predict behaviour.
Problem 3.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. A code error resulted in assignation target destination being assigned itself rather than the value of object being moved. This will result in incorrect and had to predict behaviour.
A brief test of the ability with 3 heroes owned by the same player casting at the same time demonstrates expected behaviour with no noticeable faults or errors occurring.
Here is your map. I accept both Master Card and PayPal.
(no I am not expecting a payment for this, that is a joke that should not be taken seriously)
- Joined
- Apr 24, 2012
- Messages
- 9,797
Problem 2 and 3 is the same? Good job DSG anyways. xD
Spell Reviewer
- Joined
- Jan 18, 2005
- Messages
- 27,258
No they are different errors. One was a missing member copy while the other was a incorrect variable error. They resulted in what could be considered the same fault however they were quite different.
I added comment lines above what was changed.
- Joined
- Oct 16, 2011
- Messages
- 306
OMG! Thankyou so much DSG. You helped me alot. btw, I almost taken your joke seriously. maybe there's something i can do to help you? (if about money, i can't)
- Status
