[Solved] Missile System Bug [GUI]

[xorkatoss]

I'm not sure what is causing the system to not work properly...
so i decided to post the map with the missile system here and hope that somebody will magically fix this

thnx in advance and +rep to anybody that helps me!!

and no i will NOT use Bribe's Unit Indexer , thnx

 

[Pharaoh_]

Except that you didn't post the map

 

[Bannar]

God, thank you.
I was waiting for about 8mins Pharaoh_ untill you replay with post with such message.
It's funny that I was right :S

 

[Zaio]

Not long ago you predicted maggy would make that QQ post on baassee's spell, i believe you have got psychic powers Spinnaker.

 

[Magtheridon96]

Spinnaker can predict the future and Pharaoh_ can be inactive for 2 DAYS!
I wonder what's my special power?
I know! My power is: Being really off-topic and suddenly posting something useful to avoid neg rep :3
Like this:

Possible problems:
Your missile is not moving:
- Make sure it has the Amov ability and a movement speed greater than 0
- For debugging purposes, select the missile when you create it

Your missile is not exploding when it collides with the target:
- Checking to see if the distance is 0 is a wrong approach if the missile has a non-0 collision ;P

Your missile is exploding at the wrong time:
- This is a logic error. You should make sure the conditions for exploding are correct.
- The distance must be re-calculated every 0.031250000 seconds.

Misc:
- Referencing undefined variables will cause a thread to crash:

local integer i
local integer k = 0
// We referenced i here and since it's value is undefined (not even null), the thread crashes and the entire trigger will fail.
set k=k+i

 

[Bannar]

Zaio; to be honest, ofen the same ppl answer help requests on hive all the time. After sitting here for 5 months helping others I'm pretty good with what given "helper" will start his post.

Maggy's style goes around: we start first sentence with something not thread related, rather funny and then eventually we move to busines.
Pharaoh_/TrollBrain/Bribe/Maker always respond on "empty" post (like that one) with: what's the problem? no triggers posted actually? where is map? And I mostly never respond to such thread in case it just increases my post count, it's better to actually wait untill guy says something important. When I came here knowing none, I was spamming posts all around but now; I know when to wait untill someone else asks: whats the problem actually man?"

Probably there are few users who does exectly the same thing (=
It's somehow funny since I'm pretty much predictable in World Editor Help zone too. But I wont tell how ;P

 

[baassee]

Not long ago you predicted maggy would make that QQ post on baassee's spell, i believe you have got psychic powers Spinnaker.

I don't get it lol

 

[Zaio]

I don't get it lol

GT? D:
That's hurtful

T32? D:
That's insulting

Status? D:
That's a crime

That speaks for itself.

 

[xorkatoss]

oops, sry for that, here is the map...

 

[baassee]

That speaks for itself.

he speaks the truth lol nothing else yet I used those resources anyway

 

[Zaio]

he speaks the truth lol nothing else yet I used those resources anyway

Hehe was saying that anyway because spinnaker said he knew maggy would say that

 

[baassee]

It's not that difficult foreseeing what maggy is going to say, simple formula: notusingnestsresource -> complain

 

[xorkatoss]

since you have time to chat. can you pls take a look at my missile system too pls? xD

 

[Pharaoh_]

•

• Set MissileSystem_Point[1] = (Position of MissileSystem_Dummy[3])

->

• Set MissileSystem_Point[1] = (Position of MissileSystem_Dummy[MissileSystem_MUI[3]])

•

• MissileSystem_Distance[MissileSystem_MUI[3]] Less than or equal to 10.00

•

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • MissileSystem_Distance[MissileSystem_MUI[3]] Less than or equal to 10.00
  • Then - Actions
    • Unit - Kill MissileSystem_Dummy[MissileSystem_MUI[3]] <------------ Add this line
    • Set MissileSystem_Boolean[MissileSystem_MUI[3]] = False
    • Set MissileSystem_MUI[1] = (MissileSystem_MUI[1] - 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • MissileSystem_MUI[1] Equal to 0
      • Then - Actions
        • Set MissileSystem_MUI[2] = 0
        • Trigger - Turn off (This trigger)
      • Else - Actions
  • Else - Actions

 

[Bannar]

Your missile system still requires much to be actually efficient and clear:

- replace this old indexing system with dynamic indexing
- deallocation/killing missile/instance finish shouldn't be in GroupEnum; if you do, trigger loops those actions few times, one time per unit picked ;/
- 'MissileSystem_Caster[]' parameter should be nulled at instance finish since it's unit array variable.
- loop trigger leaks group, use either 'bj_wantDestroyGroup = true' or create custom group and create/destroy it manually.
- point variables shouldn't be array types; use two non-araays instead - right now you waste a lot of memory
- in 'Fire Missile' trigger: you set variables to unit, angle etc. but later you still call (Triggering unit)/(Facing of (Triggering unit)) etc. Whats the point? Use the vars instead;
- (Owner of (Triggering unit)) -> (Triggering player)
- in loop trigger: check if trigger should be turned off only once; less code -> more speed

Those statements I've posted above leads to actually rewritting whole system/spell.

 

[xorkatoss]

thnx for the help!!
i can't believe i didn't notice that on my own *_*
anyway thnx and +rep to both

 

[baassee]

where was the link lol?

 

[xorkatoss]

where was the link lol?

in post number 9 ;p