Artillery Strike V 2.00

[Moderator]

12.12
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

When setting up the hashtable, use "Map Initialization" as the event. A 0.01 second timer is just for setting up multiboards.

0.05 seconds is bad for a periodic timer, 0.03 is best.

(Key (Picked unit)) store into an integer variable, you reference it a lot which makes it quite slow as opposed to referencing a variable pointer.

(Owner of (Triggering unit)) -> (Triggering player)

Instead of referencing (Target point of ability being cast) to ArtilleryPoint, referencing it once and then removing it, save ArtilleryPoint into the hashtable and delete the "removelocation" custom script in that trigger. That way you only call (Target point of ability being cast) once and only have to remove it once, instead of calling it twice and removing it twice.

(Dying unit) -> (Triggering unit)

(Key (Last created unit)) -> set to a variable, it involves 3 function calls. So does (Key (Triggering unit)).

(Owner of (Dying unit)) -> (Triggering player)

Lots of room for improvement.

 

[Laserdude]

EDIT:
The problem was my own, this resource functions properly.

 

[Klingo]

I believe my resource is bugged...
I don't seem to be able to open it...
It might just be me however.
If this problem persists for someone else, thought, I will delete this resource and reupload it once the resource is fixed.
Post a comment if you can't open the file.

Well... I had no problem to open it

 

[Laserdude]

Well... I had no problem to open it

That's a relief...
I recently got a new computer and I copied over all Wc3 files, so I am having some problems with opening maps outside the WE.
I will probably reinstall WC3 in order to fix this.

 

[Maker]

The tooltip is good, effect is ok and the spell is MUI. Good job.

Other stuff.

Leaks:

• Unit - Create 1 Artillery for (Owner of (Dying unit)) at ((Load (Key Point) of (Key (Dying unit)) in Hashtable) offset by Offset towards Degrees degrees) facing Default building facing degrees

These shouldn't be inside loops:

• Set ArtilleryGroup = (Last created unit group)
• Custom script: call DestroyGroup ( udg_ArtilleryGroup )

Use ... at 0.

• Animation - Change (Picked unit) flying height to (Default flying height of (Picked unit)) at 1000000.00

Load the damage into a variable before the loop.

• Unit - Cause (Dying unit) to damage (Picked unit), dealing (Load (Key Damage) of (Key (Dying unit)) from Hashtable) damage of attack type Chaos and damage type Universal

The spell is difficult to configure.

The movement of units in the air isn't smooth.

The dummy has food cost. It doesn't need to have invulnerability ability, it is invulnerable due to having locust.

You can use triggering unit instead of dying unit.

Remember to always add at least two caster in a test map so testing MUI is possible without the user having to add another unit.

 

[Laserdude]

The tooltip is good, effect is ok and the spell is MUI. Good job.

Other stuff.

Leaks:

• Unit - Create 1 Artillery for (Owner of (Dying unit)) at ((Load (Key Point) of (Key (Dying unit)) in Hashtable) offset by Offset towards Degrees degrees) facing Default building facing degrees

These shouldn't be inside loops:

• Set ArtilleryGroup = (Last created unit group)
• Custom script: call DestroyGroup ( udg_ArtilleryGroup )

Use ... at 0.

• Animation - Change (Picked unit) flying height to (Default flying height of (Picked unit)) at 1000000.00

Load the damage into a variable before the loop.

• Unit - Cause (Dying unit) to damage (Picked unit), dealing (Load (Key Damage) of (Key (Dying unit)) from Hashtable) damage of attack type Chaos and damage type Universal

The spell is difficult to configure.

The movement of units in the air isn't smooth.

The dummy has food cost. It doesn't need to have invulnerability ability, it is invulnerable due to having locust.

You can use triggering unit instead of dying unit.

Remember to always add at least two caster in a test map so testing MUI is possible without the user having to add another unit.

For the actions that should not be looped... I think I will use bjsetwantdestroygroup = true, then. (Or whatever it is called)

Use at 0? Do you mean I should use set flying height to 0? I did not do that because of the fact that air units would be bugged.

Damage will be in a variable in the next version. Thanks for the tip.

I forgot the food cost. I will change it.

The unit can be attacked if it does not have invulnerability.
Test this by adding a unit with locust in your map, and then create a creep near it. It will be attacked, unless that have been changed recently.

 

[Maker]

The unit can be attacked if it does not have invulnerability.
Test this by adding a unit with locust in your map, and then create a creep near it. It will be attacked, unless that have been changed recently.

The footman won't be attacked with this:

Trig

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Unit - Create 1 Footman for Player 1 (Red) at (Center of Region 003 <gen>) facing Default building facing degrees
    • Custom script: call UnitAddAbility( bj_lastCreatedUnit , 'Aloc' )
    • Wait 2.00 seconds
    • Unit - Create 1 Dire Wolf for Neutral Hostile at (Center of Region 003 <gen>) facing Default building facing degrees

 

[Laserdude]

The footman won't be attacked with this:

Trig

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Unit - Create 1 Footman for Player 1 (Red) at (Center of Region 003 <gen>) facing Default building facing degrees
    • Custom script: call UnitAddAbility( bj_lastCreatedUnit , 'Aloc' )
    • Wait 2.00 seconds
    • Unit - Create 1 Dire Wolf for Neutral Hostile at (Center of Region 003 <gen>) facing Default building facing degrees

No, because you are adding locust after. Add it inside OE and create them manually before running the map, or atleast create the creep before you run the map. If it does not get attacked even then, I will remove the Invulnerability.

 

[Maker]

I added locust to a footman in object editor. A added a footman to a map in the editor. I added a neutral hostile unit in the editor.

Then I added a trigger that orders the creep to attack-move to the position of the footman.

The creep didn't attack the footman.

 

[Laserdude]

I added locust to a footman in object editor. A added a footman to a map in the editor. I added a neutral hostile unit in the editor.

Then I added a trigger that orders the creep to attack-move to the position of the footman.

The creep didn't attack the footman.

Next version will contain dummy units without Invulnerability.

 

[xorkatoss]

Artillery Strike v1.00
very nice spell dude!! 5/5 +rep
another idea for this kind of spell is to make it attack in a line instead of attacking in a circle around the point...but that's just a suggestion ;p

Artillery Strike v2.00
Im glad that you liked my idea and created it!!
And i got another idea!! XD
How about this time create the artillery strike spell to fire at an X?
i don't think that you understand what i meant...
so when i find a better way to explain ill tell you

 

[GIANT_CRAB]

You should loop the artillery continue part.
otherwise, it will be very long.

 

[Laserdude]

You should loop the artillery continue part.
otherwise, it will be very long.

I told you about looping in your spell, and you are right, this can be looped.
If I loop it, however, the spell will loose its ability to be edited in a wide array of ways.
For example:
The Area of Effect can only be normal, doubled or trippled, and not customized.
For example:
This way I am currently using can use 100 range, 250 range and 450, or anything else you'll like.
Looping this will ruin the ability to do this, for example:
100 range
200 range
300 range
The numbers can never differ, since this is what the pick all unit action will look like:

• Loop - For each [Integer A], from 1 to 3, do (Actions)
  • Unit Group - Pick every unit within ([Integer A] x 100) and do (Actions)

Therefore I am not having it looped.

EDIT 2:

HUGE UPDATE!
Version 2.00 has come!
Fixed all the leaks Maker spotted, and followed his suggestions.
Followed Xorkatoss's suggestion and added a linear Artillery Strike, aswell as my own idea for the circular Artillery Strike!

Enjoy!

 

[Coolty44]

I told you about looping in your spell, and you are right, this can be looped.
If I loop it, however, the spell will loose its ability to be edited in a wide array of ways.
For example:
The Area of Effect can only be normal, doubled or trippled, and not customized.
For example:
This way I am currently using can use 100 range, 250 range and 450, or anything else you'll like.
Looping this will ruin the ability to do this, for example:
100 range
200 range
300 range
The numbers can never differ, since this is what the pick all unit action will look like:

• Loop - For each [Integer A], from 1 to 3, do (Actions)
  • Unit Group - Pick every unit within ([Integer A] x 100) and do (Actions)

Therefore I am not having it looped.

EDIT 2:

HUGE UPDATE!
Version 2.00 has come!
Fixed all the leaks Maker spotted, and followed his suggestions.
Followed Xorkatoss's suggestion and added a linear Artillery Strike, aswell as my own idea for the circular Artillery Strike!

Enjoy!

For the loop idea, you -could- create a new real global array and use it to set the damage, along with an integer to count how many times its cycled, increasing the array size by one, and allowing user customization of damage,

 

[Laserdude]

For the loop idea, you -could- create a new real global array and use it to set the damage, along with an integer to count how many times its cycled, increasing the array size by one, and allowing user customization of damage,

That is not a good idea.
That is an indexing system, and if I add an indexing system, I have to remove the Hashtable, and basically re-create the whole spell.
And no, index and hashtables should not be combined.