Antares' Hero Selection v1.5

[Antares]

You can write custom code into the HeroSelectionOnPick function. The whichHero parameter in the vJASS version or the ahs_hero variable in the GUI version specifies the hero that was selected. Now you should be able to write your custom logic and disable heroes based on which hero was selected with BanHeroFromSelection.

 

[P3in]

How can i fix players overlapping on the circle? I am trying with 1 user(me) and 5 computers to use it, player 2 and player 3 get's well put the heroes, but player 4 get stacked on player 3 circle, while players 5 and 6 aren't showed when they pick, and there are created only 3 circles, 1 for user and 2 for computers, instead of a total of 7.

And also, the tooltips of abilities and from hero description, aren't showed either when i have the mouse over them like in the template.

 

[Antares]

The locations of the background heroes are controlled by the GetPlayerBackgroundHeroLocation function / SetPlayerBackgroundHeroLocations trigger.

The reason the tooltips do not show up is most likely because you forgot to import the CustomTooltip.fdf file or imported it to the wrong path.

 

[P3in]

Ah, yeah, the path was wrong for customtooltip, didn't saw it.

And about locations, shouldn't it get the same way it does in the template? I am using the vjass version, and i copied it the exact same way and tried to test it with computers, shouldn't it behave the same way?

 

[Antares]

If you take a look at the default hero location function, it looks at the player's slot in his or her respective team, puts the hero on the first location if the player is in the first slot, into the second location if it's the second slot, and in the third location otherwise. Then, if the player is in team 2, it reflects the angle so it appears on the other side.

        --Example code:
        local angle ---@type number
        local dist ---@type number
        local BACKGROUND_HERO_OFFSET_BACKROW      = 1425 ---@type number
        local BACKGROUND_HERO_OFFSET_FRONTROW     = 1250 ---@type number

        if teamSize == 1 then
            angle = 9
            dist = BACKGROUND_HERO_OFFSET_BACKROW
        elseif slotInTeam == 1 then
            angle = 5
            dist = BACKGROUND_HERO_OFFSET_BACKROW
        elseif slotInTeam == 2 then
            angle = 13
            dist = BACKGROUND_HERO_OFFSET_BACKROW
        else
            angle = 9
            dist = BACKGROUND_HERO_OFFSET_FRONTROW
        end

        if whichTeam == 2 then
            angle = -angle
        end

So, in your map, you must have changed the team compositions and therefore the hero locations.

 

[P3in]

Ah, makes perfect sense now.

Yeah, it's a hero defense type of map so I have just 1 team and I changed that.

Thanks for clarifying!

 

[Illbean]

Was a pleasure to work on the terrain for the project. Now that I'm trying to install it in my own map, I can why it was awarded "Directors Cut"

There are so many things to this, so many layers that Shrek would be in awe.

Im having difficulties installing it properly because I don't speak Lua, but i'm getting there... slowly... And boy oh boy does my map seem a lot more proffesional with this system only half implemented!

 

[DarkePacific]

How come you set Tooltip as an ability instead of just a string?
I set it to be a string and found it much easier to manage.

set Warden.tooltipAbility             = "Cunning Hero, adept at ..."
...
string tooltipAbility
...
            call BlzFrameSetText(heroSelectionButtonTooltipText[whichHero.index] , whichHero.tooltipAbility)

 

[DarkePacific]

So am having a wierd issue when setting the flag unavailableToTeam = true, for heroes on team 2 only, across my two teams.

For team 1 (horde) everything appears to be working correctly. These images should show how it should be, and how I'd expect it to work for team 2.

(Page 1 & 2)

However,

For team 2 (alliance). When I first load in, I immediately see that the rows are off. There should only ever 3 heroes per row.

Once I change to the second page, we can a see bit more clearly that some of the horde heroes are still displaying. This is despite setting them all unavailable to team 2. (And yes I tripled checked this)
e.g:
set Arcane_Mage_H.unavailableToTeam[2] = true

(Team 2, page 2)

Finally, going back to the 1st page on team 2, we can now see the unavailable heroes are now populating. However, it appears to be just the last hero in that respective category for team 1 is being displayed.

So I am not sure what is happening here.


I double-checked these variables to see if one team was loading differently than the other, but they are exactly the same across teams.

I know something is likely going wrong in InitMenu and DisplayNewPage, but can't figure out exactly where.

probably dealing with call BlzFrameSetVisible(heroSelectionButton but I haven't been able to figure out where. (Jass)

    private function DisplayNewPage takes integer P returns nothing
        local integer i
        call BlzFrameSetVisible(heroSelectionButtonHighlight, PAGE_OF_CATEGORY[Hero.list[preselectedHeroIndex[P]].category] == currentPage)
        set i = 1
        loop
            exitwhen i > NUMBER_OF_CATEGORIES
            call BlzFrameSetVisible(heroSelectionCategory[i], PAGE_OF_CATEGORY[i] == currentPage)
            set i = i + 1
        endloop
        set i = 1
        loop
            exitwhen i > NUMBER_OF_HEROES
            call BlzFrameSetVisible(heroSelectionButton[i], PAGE_OF_CATEGORY[Hero.list[i].category] == currentPage)
            set i = i + 1
        endloop
    endfunction

 

[Antares]

Can you pm me your map? It'll make it much easier for me to debug.

 

[DarkePacific]

Can you pm me your map? It'll make it much easier for me to debug.

Ofc, can I just PM you the Jass instead? My map has literally tens of thousands of lines of code and it's really only your 5 parts that are relevant

 

[Antares]

Ofc, can I just PM you the Jass instead? My map has literally tens of thousands of lines of code and it's really only your 5 parts that are relevant

Sure, I'll copy your config into the test map.

 

[Antares]

Version 1.5

• Fixed a bug that occured when both heroes that are disabled for teams and multiple pages exist.
• Fixed a bug that caused the foreground hero's glow to not be colored to the local player's player color.
• Added the "LeftVerticalButton" page cycle button option.
• You can now choose between a tooltip ability or a tooltip string to generate the hero tooltips. This is not available in the GUI version. In the GUI version, you can now set the tooltip to the hero's unit tooltip by leaving the tooltipAbility field blank. It has been added to the documentation of all versions that the tooltipAbility can also point to a unit tooltip.

Thank you to @DarkePacific for bug reports and suggestions!