[vJASS] Charm and Fear Spellpack 1.00

[Moderator]

18:36, 21st Sep 2009
The_Reborn_Devil:

Triggering looks nice and it's well documented. Leaks are also fixed now.

Spells approved.
I give these spells the rating useful.

 

[Majin]

Yesterday when i completed the spell i was quite tired so i probably messed something up. Any comment or suggestion will be very appreciated

 

[Septimus]

Everything seems to be ok. But it would be better to let someone with more experience to judge it.

 

[Deuterium]

Deut's Brief Spell Review:

Charme and Fear Spellpack 0.9

[-]

1. Although your library PlayerChanger uses the HandleTimers library, you didn't use the requires keyword in PlayerChanger.

Thus,

library PlayerChanger initializer Init

Should be,

library PlayerChanger initializer Init requires HandleTimers

^{(I'm not sure if intializer comes before requires or vice versa)}



[+]

2. Bugless and scripting is well done


3. MUI


4. Leakless


5. Adjustable and user friendly


6. Documented


7. Some nice ideas



[*]

8. No big issue really, that's why it's not mentioned in the negative part, but you could replace this:

call PlaySound( "Sound\\Interface\\Error.wav" )

With:

    local sound s = CreateSound("Sound\\Interface\\Error.wav", false, false, true, 12700, 12700, "")
    call StartSound(s)
    call KillSoundWhenDone(s)
    set s = null

[*]

This is a well-done spell pack. I might not be a fan of the ideas myself, yet I won't deny the fact that they're nice and could be useful.
I'd advice people to use such spells.

Well, I liked most of the spells, except Turn Undead for it's a complicated one (well not complicated to use, but seems as if you've got 3 spells in one).

I skimmed through the trigger, and it seemed all fine - yet I might have missed some stuff as I only "skimmed".

Great job Majin!

 

[Majin]

I surely missed the "requires" and been lucky that the compiler (interpreter or whatev) put the code of the Handletimers library before the PlayerChanger library, i will fix that now i know i often forget to put requires but usually i get some warning, this time the error made his way till here unnoticed

Turn Undead is taken from a Role Playing Game called D&D (Dungeons and Dragons) so i took the idea from that (modified with some personal flavour and adapted to Warcraft mechanics).
In D&D Turn Undead depends on the level difference between the undead and the caster, they get feared or killed (if you are a good caster), Frightened (cowering in fear) or "mind-controlled" (if you are an evil caster), and that's how the idea came out

Thanks for your review Fixing that requires now

 

[Kwah]

IT USES vJASS SYNTAX, SO IT REQUIRES JASS NEW GEN PACK TO BE MODIFIED

Saved, not just modified.

 

[Majin]

Well, if you Modify it then you would probably want to save it, ergo...

 

[Kwah]

It also can't be imported into different maps, which is the technical purpose of it's existence.

 

[Majin]

It also can't be imported into different maps, which is the technical purpose of it's existence.

sorry, what?

 

[FranzFerenc]

Pls, I have to know how to export spells and use them...
It's stupid use them only in their map.
I can't understand how to do it...

 

[Deuterium]

Saved, not just modified.

Is this really worth mentioning and arguing upon? But yes you are right...

 

[Lambdadelta]

Umm..... I like the concept. But it didn't really interest me that much... lol... I'm a fan of eye-candy.

 

[Majin]

I'm a fan of coding instead

 

[Deuterium]

Well, you can have eye-candy alongside with coding

 

[Majin]

Or you can have great coding and put some effects just as example then let the final user choose his eye-candy special effects

Also those aren't the kind of spells that would require a lot of special effects, don't you think so?

 

[Deuterium]

Well that's why as you see I didn't mention SFX in the review... 'cause you can't include much eye-candy...

Yet, it usually is nice if the creator picks some great eye-candy by default... as a treat to the users

 

[Majin]

Yeah, surely eye-candy attracts users, but i'm not the kind of person that would put too many effects on a spell (I like simplicity)...Altough, should i ever make some "epic" spell, i'll spend much more time on the effects

By the Way, i've fixed both the requires on the library and the PlaySound function

 

[Deuterium]

Well I agree on the eye-candy part, I'm a fan of simplicity too...

Ummm, if you fixed those than it's all well-done! GoodJob!

 

[FranzFerenc]

Export spell etc

@majin


"It also can't be imported into different maps, which is the technical purpose of it's existence.

sorry what?"
-

the spell

I want to know it too. I've downloaded "jassnewgenpack5d" (right?) but I can't do it the same... I mean saving/import/export etc

HEEEEEEEELLLLLLLLLLLLLPPPPPPPPPPPPPPPPPPPPPPP

 

[Majin]

@majin


"It also can't be imported into different maps, which is the technical purpose of it's existence.

sorry what?"
-

the spell

I want to know it too. I've downloaded "jassnewgenpack5d" (right?) but I can't do it the same... I mean saving/import/export etc

HEEEEEEEELLLLLLLLLLLLLPPPPPPPPPPPPPPPPPPPPPPP

i had understood he was talking about the spell, but i don't see the meaning...if you are using Newgen and follow the instructions in each spell you should be able to easily import it.
What kind of problem are you having with the spell?

 

[.OmG.]

Could be usefull in map of Dota - style

 

[Fud]

@majin


"It also can't be imported into different maps, which is the technical purpose of it's existence.

sorry what?"
-

the spell

I want to know it too. I've downloaded "jassnewgenpack5d" (right?) but I can't do it the same... I mean saving/import/export etc

HEEEEEEEELLLLLLLLLLLLLPPPPPPPPPPPPPPPPPPPPPPP

unless im misunderstanding your problem you dont know how to copy and past spells from one map to another... Ive never had to export spells...

Turn Undead doesn't grant kill bounty and doesn't work on units affected by any of the other spells.

 

[hemmedo]

like+rep

 

[HERON]

Hi, how can I use the spell or add this to my map?
I need something for this?

 

[Majin]

Are you receiving any specific error?
As I said via DM, you need something that can parse vJASS, sadly I've been out of the warcraft 3 modding scene for too long, I know that nowadays there's no Jass New Gen Pack but I don't know what is being used instead. I think I heard that the latest editor supports vJASS by default but i'm not 100% sure.

For more specific instructions you can check the comments at the beginning of each trigger, you need to copy or re-create some of the spells in your map and then put the ids in the variables of the spells.

I'm not sure how many people will see a message here besides me, you can try your luck by posting directly on the forum and linking this spell there

 

[Elprede]

JNGP is still available and usable. You just need a version of Wc3 that contains the MPQs. I use JNGP Lua Edition.

On patches 1.30+, you don't need to use 3rd party tools anymore to compile vJASS code. JassHelper is now integrated into the vanilla World Editor.