12:08, 16th Jan 2010
ap0calypse: Rejected

You have enough leaks to cause this to be Rejected.

what bullshyt is tis

Aesthetics said:

You have enough leaks to cause this to be Rejected.

Click to expand...

trying 2 fix the leaks as we speak
its only 1.3 i mean come'on had 2 start somewhere lol

(reading up on how 2 remove leaks)

Edit:
tried 2 remove all leaks but when i tried 2 test the map it spit tons of errors at me... I'll try again tomorrow when I'm fully awake
PS. if u know of a really good tut on how to remove leaks PM me >_>

I'll do my best to explain it, I will skip all things that aren't needed when removing them (such as "What is a leak?" and stuff).


In this tutorial, I will use a location leak as an example!

Let's say you are creating a unit for a player and you use this trigger:
A very common trigger in most zombie-maps and all maps that use spawns.

The "(Center of (Playable map area))" creates a leak (it's a location).
The first thing you need to do is set it to a variable, I normally use the variable "loc" (with array).

Variable Info:

Okay, we have the variable, we need to set the variable to the location now.
Like this:
We forgot 1 thing here: though we have set the location to a variable, we didn't actually use the variable, making it completely useless (and I explicitly show this because I have seen people who remove leaks correctly, but don't use the variables which clear the leaks, so they still have leaks).

We have set the leak to a variable and used that variable instead of the location, great...
But we still didn't remove the leak.

We need the action "Custom script" for that (Custom script is actually a JASS-line, used in GUI-format).
This line always starts with "call" when removing leaks and is case sensitive.
Afterwards, we need a variable-specific line...

Variable types + Remove code
Those are the only 3 you'll probably need.
We use a location, so it becomes:
Looking good so far, but we have to tell the code which location we need to remove.
Since we used the variable "loc", we need to remove that one.
Variables in GUI are User Defined Globals (shortened as udg), so we need to put "udg_" in front of our variable (not the actual varaible name =.=).
Also, you need to put the variable you want to remove between brackets.
It becomes:
Note: now the variable would've been cleared if we didn't use an array...
(this is the standard form for variables without array).
The array needs to be put between square brackets, we have used loc[1], so it becomes:
And we're done!

The leak is succesfully removed and won't cause lag now.

Additional Notes:

Multiple Leaks:

When using multiple locations, you need to remove them all, point with offset is the mot common cause, here is an example:

Easy leaks:

There are also a few easy leaks, these include Special Effect and Sound leaks.
The way to remove them is a lot easier, since there is a GUI-command for it:
The special effect will still show it's Birth Animation (which is often the only animation you need, note that not all special effects will show though).


Important Note:

Never remove the player group "All Players", it literally removes the standard force, so it will be empty afterwards!


Loop Arrays

I don't know if it's useful, but I'll show it anyway:
You might as well have used "loc[1]" in this case, but I've got a system where I have to do it this way.

Oh ap0c I hope you don't type that for every map that has leaks.

Aesthetics said:

Oh ap0c I hope you don't type that for every map that has leaks.

Click to expand...

Not really, he asked for an explanation so I give one xD
Leaks are the most basic things a mapper should learn =.= (and I saved the "tutorial" in notepad, so I don't have to rewrite it the entire time )

thx, that's alot easier reading that the tut i had found
now mayB i can get somewhere lol
(is it better 2 use the variable "Unit" or just add it 2 a unit group then destroy the unit group?)
((is it also better 2 use above answer instead of "Sold Unit" ect?))

Obadiah332 said:

thx, that's alot easier reading that the tut i had found
now mayB i can get somewhere lol
(is it better 2 use the variable "Unit" or just add it 2 a unit group then destroy the unit group?)
((is it also better 2 use above answer instead of "Sold Unit" ect?))

Click to expand...

Oh, no: you only need to remove unit group leaks when you actually use a unit group.
When you sell/buy a unit, you don't actually use a unit group, you're just using 1 single unit... (you can't form a group on your own, can you? O_O).

Edit: okay, here's a trigger (to give you an example):
This could be used in an AoE ability such as war stomp: it picks all units around the caster and damages them...
That's when unit groups should be used

ap0calypse said:

Oh, no: you only need to remove unit group leaks when you actually use a unit group.
When you sell/buy a unit, you don't actually use a unit group, you're just using 1 single unit... (you can't form a group on your own, can you? O_O).

Click to expand...

nvr know....give some noobs 2 much beer and they'll try
just thought I'd ask cuzz i saw 1 map that did it that way and all the triggers were really goofy lookin

Obadiah332 said:

nvr know....give some noobs 2 much beer and they'll try
just thought I'd ask cuzz i saw 1 map that did it that way and all the triggers were really goofy lookin

Click to expand...

Lol xD

Well, some maps use different triggers... I don't really know what you're talking about, so I can't say whether the triggers were good or not, but I think it's best to use unit groups as in the example I've given in my previous post (which I just edited btw :X).

found more Leaks >_> shh dey invis ^^ think i got them all this time tho

btw if u have any suggestions for heroes/items ect let me know...this map runs on that kinda stuff

Edit:
can rejected maps get approved if fixed or is it a perm thing? (just asking cuzz I'm trying hard)

Edit2:
Since no response was given I'll continue to update map