• You have a location leak - Position of DA_Target. //Damn Arrow
• You have unit groups leak - CR_Group & CR_Group2. //Convenient Ritual
• You have more location leaks - SsRg_Point1 & SsRg_Point2. //Skeletal Satanic Ritual Target
• I'm afraid your Skeletal Satanic Ritual is not MUI and it also has many leaks.

Rheiko said:

Please post the triggers using the [trigger]YourTriggerHere[/trigger] tags.

• You have a location leak - Position of DA_Target. //Damn Arrow
• You have unit groups leak - CR_Group & CR_Group2. //Convenient Ritual
• You have more location leaks - SsRg_Point1 & SsRg_Point2. //Skeletal Satanic Ritual Target
• I'm afraid your Skeletal Satanic Ritual is not MUI and it also has many leaks.

Click to expand...

Tank-Commander said:

I went over it pretty quickly, here are some pointers:

Major:
- There's a lot of leaks (DA_PointLoop, DA_Group, etc.) they need to be cleaned before they're reused every time, not just at the end of the trigger
- Dummies should be made for a neutral player as to not interfere with scorescreens
- Constant configurables should be set in a separate trigger, not every time a unit starts the effect of the ability as these values will always be the same
- Only create unique variables for things like points and groups as are needed simultaneously (notably you have 6 location variables for "Damn arrow" when at most 2 are needed
- As said by Reiko Skeletal Satanic Ritual is not MUI and needs to be reworked

Minor:
- Store things such as last created unit into temporary variables if they're used more than twice to reference the same unit, this makes your program run faster
- Try to calculate numbers needed multiple times only once, restructure your codes to do this e.g. the line "Set DA_AoE_Total = (DA_AoE_Initial + (DA_Distance x (Real(DA_LvAbility))))" could be outside of its loop as this doesn't change
- Your group filtering is structured inefficiently - group in range into a group, then pick all the units, store the picked unit in a variable and then use an if-then-else structure to filter the units
- Don't use "Do nothing" functions
- Floating text should be optional (as there is a 100 floating texts per client limit)
- use a 0.03 timer speed instead of a 0.02 timer speed (you don't need 40 frames per second when humans can only see 30 - it adds needless processing)
- Your dummy unit type should be configurable as should all of your abilities used by both the spells and dummies
- I'd also suggest naming your folder the match the spell pack so that when people import it the folder is in an intuitive location (your import guide should also be in the same folder)

You also lack a proper description on the site - describe the spells that you've submitted

Click to expand...

KILLCIDE said:

On top of what Tank said, please consider looking at the Spell Submission Rules before posting. Also consider looking at the other approved GUI submissions and see how they did some things like a "config" trigger or how they set up their descriptions.

Click to expand...